From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 305BC78003C for ; Mon, 3 Jun 2024 18:47:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nNr8cXBIIbSd5iMs0I4B5k6zB20fdrsHrUlIEiIOSLM=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240206; t=1717440430; v=1; b=pY8d0FT7f6QMs5CsKJ1NoIYyo+ZJ0GFKIlVInP2KFQ6p6Dnv9PWycg+06tm1L8S7gv0I99Vt j6ELpQdu8ewEXe7D5nl9BorCai2iDjYNU/LdKuKYME6DTfD2cnTHHrhgVsyUSlFwHSOHcGJRP+w VK/lCfpRB7Hvmyi/m82BFz7/31s19/qSb4DlbGpYHPhVFqoBkfcf54e6eo53tKzmCj801bFmA87 +mAnT5Wd2JFSzj0vNnD9ATre7fyp7e0Fkh8AGhGyuHLDd/YN0bJg896SY6e7neBxcbl+22iYHi8 bbvIwbfjCzVXryVMGkODON1ZEZisakYhmBE81tF6oVR3g== X-Received: by 127.0.0.2 with SMTP id GDHSYY7687511xMgiqsYCI5F; Mon, 03 Jun 2024 11:47:09 -0700 X-Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by mx.groups.io with SMTP id smtpd.web11.145.1717440428837487833 for ; Mon, 03 Jun 2024 11:47:09 -0700 X-Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a68c8b90c85so256434066b.2 for ; Mon, 03 Jun 2024 11:47:08 -0700 (PDT) X-Gm-Message-State: 7S85MZMXdgN4IruJZvxl6N2Cx7686176AA= X-Google-Smtp-Source: AGHT+IGTRK90dgrAg0EQaxL6bPJVsDmqw+CIxHmbmHMPjbxDLU2mlLeA/3NBjD+6qaYxlVNi4bWEG8Hcbs5c8Qc3PGA= X-Received: by 2002:a17:907:940b:b0:a69:2bce:e41e with SMTP id a640c23a62f3a-a692bcee4bemr177474666b.9.1717440426397; Mon, 03 Jun 2024 11:47:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Neal Gompa" Date: Mon, 3 Jun 2024 14:46:30 -0400 Message-ID: Subject: Re: [edk2-devel] GitHub PR Code Review process now active To: devel@edk2.groups.io, michael.d.kinney@intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 03 Jun 2024 11:47:09 -0700 Resent-From: ngompa13@gmail.com Reply-To: devel@edk2.groups.io,ngompa13@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=pY8d0FT7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hmm, I don't see a setting for it anymore, maybe that's not a thing anymore= ? I seemingly recall that draft PRs didn't get CI runs, but if that's not a thing anymore, then that's fine. That said, draft PRs cannot be reviewed, so we should not be telling people to make draft PRs. On Mon, Jun 3, 2024 at 12:26=E2=80=AFPM Michael D Kinney via groups.io wrote: > > CI jobs are dispatched to both GitHub Actions and Azure Pipelines. > > For Draft PRs, I see both GitHub Actions and Azure Pipelines jobs running= . > > This must imply that edk2 repo allows this. Do you happen to know where > this is configurable or a link to GitHub docs for configuration? > > Mike > > > -----Original Message----- > > From: Neal Gompa > > Sent: Monday, June 3, 2024 9:13 AM > > To: devel@edk2.groups.io; Kinney, Michael D > > Subject: Re: [edk2-devel] GitHub PR Code Review process now active > > > > On Tue, May 28, 2024 at 2:53=E2=80=AFPM Michael D Kinney via groups.io > > wrote: > > > > > > Hello, > > > > > > The GitHub PR code review process is now active. Please > > > use the new PR based code review process for all new > > > submissions starting today. > > > > > > * The Wiki has been updated with the process changes. > > > > > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Develo= pment- > > Process > > > > > > Big thanks to Michael Kubacki for writing up all the > > > changes based on the RFC proposal and community discussions. > > > > > > We will learn by using, so if you see anything missing or > > > incorrect or clarifications needed, please send feedback > > > here so the Wiki pages can be updated quickly for everyone. > > > > > > * The edk2 repo settings have been updated to require > > > a GitHub PR code review approval before merging and > > > all conversations must be resolved before merging. > > > > > > * A PR has been opened that removes the requirement for > > > Cc: tags in the commit messages and is the first PR > > > that will use the new process. This PR needs to be > > > reviewed and merged to support the revised commit > > > message format. > > > > > > https://github.com/tianocore/edk2/pull/5688 > > > > > > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Messag= e- > > Format > > > > > > * Please use "Draft" PRs to run CI without any reviews. > > > Once ready for reviews, convert from "Draft" to > > > "Ready for Review". > > > > > > > Generally GitHub doesn't allow CI to run on PRs created as draft pull > > requests. Was this changed for edk2? > > > > > > -- > > =E7=9C=9F=E5=AE=9F=E3=81=AF=E3=81=84=E3=81=A4=E3=82=82=E4=B8=80=E3=81= =A4=EF=BC=81/ Always, there's only one truth! > > >=20 > > -- =E7=9C=9F=E5=AE=9F=E3=81=AF=E3=81=84=E3=81=A4=E3=82=82=E4=B8=80=E3=81=A4=EF= =BC=81/ Always, there's only one truth! -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119433): https://edk2.groups.io/g/devel/message/119433 Mute This Topic: https://groups.io/mt/106355103/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-