From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x229.google.com (mail-it0-x229.google.com [IPv6:2607:f8b0:4001:c0b::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 08B128030A for ; Thu, 9 Mar 2017 09:32:36 -0800 (PST) Received: by mail-it0-x229.google.com with SMTP id h10so132702240ith.1 for ; Thu, 09 Mar 2017 09:32:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UZjxR8Ru1LA7vDilvX2ytiuWrFHHARXC3mAeKDMQHDE=; b=ZBVHa1omki4XaNyPbRPzdKrresbljfz+tiGShj9FnG5+J8sh0iSPlCqb/P2Wy9pG5t OmuFv+QMjrJdpAwu5P8dNmGdTFQV46dameOAo6kedBs53seVyLE/KqkmFQPTa2S/miF4 N9Lpzc/kfLjfMUvmMwuZCvGiZPcBNGOska7+o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UZjxR8Ru1LA7vDilvX2ytiuWrFHHARXC3mAeKDMQHDE=; b=IBvFzMkQfsP/j8TSgGckMcSW7EXKq3XvOYU62D2Oi3cad9ExzfidXa9nS7taczHZZ7 ulIIrhtD5s9RtW+BTNn5y7ZEW+j6CRCyrhXJ9DbP9OmS+dco/KlQOJ/adtoDHrjJ3kJ5 /1XeYNRVx3yubjfbTRajkd3KfxzTMrSonFBiWWlGHmMv17xFxduY/aTkDfNsnJX60Wt+ 1pBXMjQxer+K2+UmBB48j6tlZyxMQvM+k2Yymr4/jSP+aysJEp2h2rbbM8SUVdLvUGiA NnnmVlzf7juKZCAjD1rY6zWhdPr8JqCx5BGzON23fYxE/1AD00djobn2ug3dkNFRGGV5 Pnug== X-Gm-Message-State: AMke39m8oZrfSAzoufegSDbeUiHrDdyvp3F9ZNbpilnWUs8w/4O2SPn6D1hbxfW/NIw02Q03SowuLT4uyYZGiWpZ X-Received: by 10.36.116.7 with SMTP id o7mr33506939itc.31.1489080755402; Thu, 09 Mar 2017 09:32:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.124.34 with HTTP; Thu, 9 Mar 2017 09:32:34 -0800 (PST) Received: by 10.64.124.34 with HTTP; Thu, 9 Mar 2017 09:32:34 -0800 (PST) In-Reply-To: References: <1489080073-13328-1-git-send-email-ard.biesheuvel@linaro.org> <1489080073-13328-2-git-send-email-ard.biesheuvel@linaro.org> From: Leif Lindholm Date: Thu, 9 Mar 2017 18:32:34 +0100 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Ard Biesheuvel , drjones@redhat.com X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH v2 1/4] ArmVirtPkg/FdtClientDxe: supplement missing EFIAPI calling conv specifiers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 17:32:36 -0000 Content-Type: text/plain; charset=UTF-8 Reviewed-by: Leif Lindholm On 9 Mar 2017 6:29 pm, "Laszlo Ersek" wrote: > On 03/09/17 18:21, Ard Biesheuvel wrote: > > From: Laszlo Ersek > > > > Add missing EFIAPI calling convention specifiers to STATIC function > > that are exposed via the FdtClientProtocol interface. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Laszlo Ersek > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Ard Biesheuvel > > --- > > ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c > b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c > > index 7cc0c44ca12a..547a29fce62c 100644 > > --- a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c > > +++ b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c > > @@ -29,6 +29,7 @@ STATIC VOID *mDeviceTreeBase; > > > > STATIC > > EFI_STATUS > > +EFIAPI > > GetNodeProperty ( > > IN FDT_CLIENT_PROTOCOL *This, > > IN INT32 Node, > > @@ -55,6 +56,7 @@ GetNodeProperty ( > > > > STATIC > > EFI_STATUS > > +EFIAPI > > SetNodeProperty ( > > IN FDT_CLIENT_PROTOCOL *This, > > IN INT32 Node, > > @@ -267,6 +269,7 @@ FindMemoryNodeReg ( > > > > STATIC > > EFI_STATUS > > +EFIAPI > > GetOrInsertChosenNode ( > > IN FDT_CLIENT_PROTOCOL *This, > > OUT INT32 *Node > > > > Well, I can't exactly "review" or "ACK" my own patch (or patches mostly > derived from my patches). Leif, can you pls R-b this? > > Thanks > Laszlo >