public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] OptionRomPkg: .dsc fixes for ARM/AARCH64 and USB drivers
@ 2016-09-04 13:16 Leif Lindholm
  2016-09-06 15:50 ` Leif Lindholm
  2016-09-07  0:34 ` Ni, Ruiyu
  0 siblings, 2 replies; 3+ messages in thread
From: Leif Lindholm @ 2016-09-04 13:16 UTC (permalink / raw)
  To: edk2-devel; +Cc: Ruiyu Ni, Ard Biesheuvel

Drivers under OptionRomPkg wouldn't build standalone, since ARM and
AARCH64 were missing from SUPPORTED_ARCHITECTURES. So add them.
Also, add some compiler libraries needed for ARM/AARCH64 GCC
toolchains (CompilerIntrinsicsLib and BaseSwStackCheckLib).

Also, the UsbNetworking drivers were not listed under [Components],
so failed to build standalone. This patch adds them.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
 OptionRomPkg/OptionRomPkg.dsc | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/OptionRomPkg/OptionRomPkg.dsc b/OptionRomPkg/OptionRomPkg.dsc
index 03592f8..3365556 100644
--- a/OptionRomPkg/OptionRomPkg.dsc
+++ b/OptionRomPkg/OptionRomPkg.dsc
@@ -7,6 +7,7 @@
 # A single driver can support mixes of EFI 1.1, UEFI 2.0 and UEFI 2.1.
 #
 # Copyright (c) 2007 - 2013, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
 #
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
@@ -29,7 +30,7 @@ [Defines]
   PLATFORM_VERSION               = 0.1
   DSC_SPECIFICATION              = 0x00010005
   OUTPUT_DIRECTORY               = Build/OptionRomPkg
-  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64|EBC
+  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64|EBC|ARM|AARCH64
   BUILD_TARGETS                  = DEBUG|RELEASE
   SKUID_IDENTIFIER               = DEFAULT
 
@@ -60,6 +61,12 @@ [LibraryClasses]
   UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
   UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
 
+[LibraryClasses.AARCH64, LibraryClasses.ARM]
+  NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
+
+[LibraryClasses.ARM]
+  NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
+
 ################################################################################
 #
 # Pcd Section - list of all EDK II PCD Entries defined by this Platform
@@ -105,6 +112,8 @@ [Components]
   OptionRomPkg/CirrusLogic5430Dxe/CirrusLogic5430Dxe.inf
   OptionRomPkg/UndiRuntimeDxe/UndiRuntimeDxe.inf
   OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDxe.inf
+  OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf
+  OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
 
 [Components.IA32, Components.X64, Components.IPF]
   OptionRomPkg/Application/BltLibSample/BltLibSample.inf
-- 
2.9.3



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] OptionRomPkg: .dsc fixes for ARM/AARCH64 and USB drivers
  2016-09-04 13:16 [PATCH] OptionRomPkg: .dsc fixes for ARM/AARCH64 and USB drivers Leif Lindholm
@ 2016-09-06 15:50 ` Leif Lindholm
  2016-09-07  0:34 ` Ni, Ruiyu
  1 sibling, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2016-09-06 15:50 UTC (permalink / raw)
  To: edk2-devel (edk2-devel@lists.01.org); +Cc: Ruiyu Ni, Ard Biesheuvel

Ruiyu - any comments?

Regards,

Leif

On 4 September 2016 at 14:16, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> Drivers under OptionRomPkg wouldn't build standalone, since ARM and
> AARCH64 were missing from SUPPORTED_ARCHITECTURES. So add them.
> Also, add some compiler libraries needed for ARM/AARCH64 GCC
> toolchains (CompilerIntrinsicsLib and BaseSwStackCheckLib).
>
> Also, the UsbNetworking drivers were not listed under [Components],
> so failed to build standalone. This patch adds them.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>  OptionRomPkg/OptionRomPkg.dsc | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/OptionRomPkg/OptionRomPkg.dsc b/OptionRomPkg/OptionRomPkg.dsc
> index 03592f8..3365556 100644
> --- a/OptionRomPkg/OptionRomPkg.dsc
> +++ b/OptionRomPkg/OptionRomPkg.dsc
> @@ -7,6 +7,7 @@
>  # A single driver can support mixes of EFI 1.1, UEFI 2.0 and UEFI 2.1.
>  #
>  # Copyright (c) 2007 - 2013, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
>  #
>  # This program and the accompanying materials
>  # are licensed and made available under the terms and conditions of the BSD License
> @@ -29,7 +30,7 @@ [Defines]
>    PLATFORM_VERSION               = 0.1
>    DSC_SPECIFICATION              = 0x00010005
>    OUTPUT_DIRECTORY               = Build/OptionRomPkg
> -  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64|EBC
> +  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64|EBC|ARM|AARCH64
>    BUILD_TARGETS                  = DEBUG|RELEASE
>    SKUID_IDENTIFIER               = DEFAULT
>
> @@ -60,6 +61,12 @@ [LibraryClasses]
>    UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
>    UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
>
> +[LibraryClasses.AARCH64, LibraryClasses.ARM]
> +  NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> +
> +[LibraryClasses.ARM]
> +  NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> +
>  ################################################################################
>  #
>  # Pcd Section - list of all EDK II PCD Entries defined by this Platform
> @@ -105,6 +112,8 @@ [Components]
>    OptionRomPkg/CirrusLogic5430Dxe/CirrusLogic5430Dxe.inf
>    OptionRomPkg/UndiRuntimeDxe/UndiRuntimeDxe.inf
>    OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDxe.inf
> +  OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf
> +  OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
>
>  [Components.IA32, Components.X64, Components.IPF]
>    OptionRomPkg/Application/BltLibSample/BltLibSample.inf
> --
> 2.9.3
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] OptionRomPkg: .dsc fixes for ARM/AARCH64 and USB drivers
  2016-09-04 13:16 [PATCH] OptionRomPkg: .dsc fixes for ARM/AARCH64 and USB drivers Leif Lindholm
  2016-09-06 15:50 ` Leif Lindholm
@ 2016-09-07  0:34 ` Ni, Ruiyu
  1 sibling, 0 replies; 3+ messages in thread
From: Ni, Ruiyu @ 2016-09-07  0:34 UTC (permalink / raw)
  To: Leif Lindholm, edk2-devel@lists.01.org; +Cc: Ard Biesheuvel

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Regards,
Ray

>-----Original Message-----
>From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
>Sent: Sunday, September 4, 2016 9:16 PM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
>Subject: [PATCH] OptionRomPkg: .dsc fixes for ARM/AARCH64 and USB drivers
>
>Drivers under OptionRomPkg wouldn't build standalone, since ARM and
>AARCH64 were missing from SUPPORTED_ARCHITECTURES. So add them.
>Also, add some compiler libraries needed for ARM/AARCH64 GCC
>toolchains (CompilerIntrinsicsLib and BaseSwStackCheckLib).
>
>Also, the UsbNetworking drivers were not listed under [Components],
>so failed to build standalone. This patch adds them.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>---
> OptionRomPkg/OptionRomPkg.dsc | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
>diff --git a/OptionRomPkg/OptionRomPkg.dsc b/OptionRomPkg/OptionRomPkg.dsc
>index 03592f8..3365556 100644
>--- a/OptionRomPkg/OptionRomPkg.dsc
>+++ b/OptionRomPkg/OptionRomPkg.dsc
>@@ -7,6 +7,7 @@
> # A single driver can support mixes of EFI 1.1, UEFI 2.0 and UEFI 2.1.
> #
> # Copyright (c) 2007 - 2013, Intel Corporation. All rights reserved.<BR>
>+# Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
> #
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the BSD License
>@@ -29,7 +30,7 @@ [Defines]
>   PLATFORM_VERSION               = 0.1
>   DSC_SPECIFICATION              = 0x00010005
>   OUTPUT_DIRECTORY               = Build/OptionRomPkg
>-  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64|EBC
>+  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64|EBC|ARM|AARCH64
>   BUILD_TARGETS                  = DEBUG|RELEASE
>   SKUID_IDENTIFIER               = DEFAULT
>
>@@ -60,6 +61,12 @@ [LibraryClasses]
>   UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
>   UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
>
>+[LibraryClasses.AARCH64, LibraryClasses.ARM]
>+  NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
>+
>+[LibraryClasses.ARM]
>+  NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>+
> ################################################################################
> #
> # Pcd Section - list of all EDK II PCD Entries defined by this Platform
>@@ -105,6 +112,8 @@ [Components]
>   OptionRomPkg/CirrusLogic5430Dxe/CirrusLogic5430Dxe.inf
>   OptionRomPkg/UndiRuntimeDxe/UndiRuntimeDxe.inf
>   OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDxe.inf
>+  OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf
>+  OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
>
> [Components.IA32, Components.X64, Components.IPF]
>   OptionRomPkg/Application/BltLibSample/BltLibSample.inf
>--
>2.9.3



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-09-07  0:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-04 13:16 [PATCH] OptionRomPkg: .dsc fixes for ARM/AARCH64 and USB drivers Leif Lindholm
2016-09-06 15:50 ` Leif Lindholm
2016-09-07  0:34 ` Ni, Ruiyu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox