From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-x235.google.com (mail-yb0-x235.google.com [IPv6:2607:f8b0:4002:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BB7151A1E5F for ; Tue, 6 Sep 2016 08:50:50 -0700 (PDT) Received: by mail-yb0-x235.google.com with SMTP id x93so86782648ybh.1 for ; Tue, 06 Sep 2016 08:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uL6n4OJOk5Hr7z+gDONapag225TE9ncAA99X48rF3qU=; b=DJ9DYoGCT2M52i5xvVYS9x8JaQFas/zHDLf6Snxw0bPYGm4l2F3vC0Hrgho/1fv4c+ WWJElzfwhZtaiKMcjvmUHShTnLrb1Hh7z6IcfWLqU0Pc8eOUMRrKGVJbt/sD/WucPsFU XoVTRbANfkp10XlqiLLN+h9M41I6YvTKSgzFU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uL6n4OJOk5Hr7z+gDONapag225TE9ncAA99X48rF3qU=; b=YitIGGn6CNyWGD5XCs/ZQNamHlY5/022kxp9bTThpFLi5sivD3kuTw194lcqEyhIDf OenIfh4JynXAze07N/n7fjlSF4V7ruQNMZPqYm2UFrvNzo4vMtgCVznTMwwSSnnKtvlh Nj/3fsGR5em6eTIMVxdP+nINS2o/Uw4yk8bX9Bw1bNXFItvgh109QxvfjJi17HpYBJJH aTS4fWaiYLgBtOhxYV+xfu5nxsfs4W/CQLVx4PcMN7rgsLvkrprYI8vma5IR27CBxSux HfDhyG6bG5oZNYVsIqVJUYUBD8wFV1NUfTzJxqy6mVwVc9kt6uRhGnBNPUgG9wJJ1qJW 4Tyg== X-Gm-Message-State: AE9vXwPx+ZAn7wFyLTG0pi83EMe2tSMKAZPYarCJSLI8pBYluOSW9QOqThyy65GK1jn8ksYrndG7UaFFPgzoG3iw X-Received: by 10.107.129.94 with SMTP id c91mr5278047iod.154.1473177049628; Tue, 06 Sep 2016 08:50:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.15.133 with HTTP; Tue, 6 Sep 2016 08:50:49 -0700 (PDT) In-Reply-To: <20160904131619.1263-1-leif.lindholm@linaro.org> References: <20160904131619.1263-1-leif.lindholm@linaro.org> From: Leif Lindholm Date: Tue, 6 Sep 2016 16:50:49 +0100 Message-ID: To: "edk2-devel (edk2-devel@lists.01.org)" Cc: Ruiyu Ni , Ard Biesheuvel Subject: Re: [PATCH] OptionRomPkg: .dsc fixes for ARM/AARCH64 and USB drivers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Sep 2016 15:50:51 -0000 Content-Type: text/plain; charset=UTF-8 Ruiyu - any comments? Regards, Leif On 4 September 2016 at 14:16, Leif Lindholm wrote: > Drivers under OptionRomPkg wouldn't build standalone, since ARM and > AARCH64 were missing from SUPPORTED_ARCHITECTURES. So add them. > Also, add some compiler libraries needed for ARM/AARCH64 GCC > toolchains (CompilerIntrinsicsLib and BaseSwStackCheckLib). > > Also, the UsbNetworking drivers were not listed under [Components], > so failed to build standalone. This patch adds them. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leif Lindholm > --- > OptionRomPkg/OptionRomPkg.dsc | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/OptionRomPkg/OptionRomPkg.dsc b/OptionRomPkg/OptionRomPkg.dsc > index 03592f8..3365556 100644 > --- a/OptionRomPkg/OptionRomPkg.dsc > +++ b/OptionRomPkg/OptionRomPkg.dsc > @@ -7,6 +7,7 @@ > # A single driver can support mixes of EFI 1.1, UEFI 2.0 and UEFI 2.1. > # > # Copyright (c) 2007 - 2013, Intel Corporation. All rights reserved.
> +# Copyright (c) 2016, Linaro Ltd. All rights reserved.
> # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > @@ -29,7 +30,7 @@ [Defines] > PLATFORM_VERSION = 0.1 > DSC_SPECIFICATION = 0x00010005 > OUTPUT_DIRECTORY = Build/OptionRomPkg > - SUPPORTED_ARCHITECTURES = IA32|IPF|X64|EBC > + SUPPORTED_ARCHITECTURES = IA32|IPF|X64|EBC|ARM|AARCH64 > BUILD_TARGETS = DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > > @@ -60,6 +61,12 @@ [LibraryClasses] > UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf > UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf > > +[LibraryClasses.AARCH64, LibraryClasses.ARM] > + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > + > +[LibraryClasses.ARM] > + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > + > ################################################################################ > # > # Pcd Section - list of all EDK II PCD Entries defined by this Platform > @@ -105,6 +112,8 @@ [Components] > OptionRomPkg/CirrusLogic5430Dxe/CirrusLogic5430Dxe.inf > OptionRomPkg/UndiRuntimeDxe/UndiRuntimeDxe.inf > OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDxe.inf > + OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf > + OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > [Components.IA32, Components.X64, Components.IPF] > OptionRomPkg/Application/BltLibSample/BltLibSample.inf > -- > 2.9.3 >