From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=O8/y0UZt; spf=pass (domain: linaro.org, ip: 209.85.167.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by groups.io with SMTP; Thu, 18 Jul 2019 09:27:37 -0700 Received: by mail-lf1-f66.google.com with SMTP id h28so19642251lfj.5 for ; Thu, 18 Jul 2019 09:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BR4nCYwx6O4/3pncdFH8fx0tE+CyQDWR55hytDgHMdM=; b=O8/y0UZt+y7XD7QL5ly27B0o7o+cy6yyK0YA687TgB2Ip170bw05tntM/Jc2NBZfyq 9MkikJyvTD6pZvRtBYzjvp2yaS8mt+7Rki2pKIg6xqxhmCsqk6mXN5sG9JnxT51kJ5Cl g7xH3qh8GwsmndKijpVAVzhLqxK8DNyIcnqkpjL/XpV84cVMULPbq6Vae5H8Api/KKVD QU03XFtbxOQhDSgXJTbshX2DWMKzRf/Ft4g3EEaUruPIEU8LS3I7xzAhVFBC/SNGzp4D ZCso7Pf6yCVfPuBRS+/16GXC/q+JqiK2Eox/p+tH99PZpWnSXsNFqP0WvT4VVCOA5ZMV cZ3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BR4nCYwx6O4/3pncdFH8fx0tE+CyQDWR55hytDgHMdM=; b=DToT+JiQC9sDrWjNBcDMqupVaKI2NXwMEgazzG45sjtFZvxVCvDabGgX9wjYzZM2Fs r2qekAq0K7JICNVF7+nsFrH4en7R5GMtDNw2AL84lNys2CIJU5CMfBxOLANx8mZOW8ka eQZb+MNgcN8F7akEYhTIAi1tyelJ1vXiXch/DdJTQd6C/lsao8tS0rjJqdyBAuVzdYmv 2m9eEfg47l19SqMthVTmuDrf8bcUqJMZUq+cPK09hnZB0YPpPLxlhbyXRwLGoU4LOWWo dWZ7+STSVxzLCniNsdq/y+Mr4oquMekbkjftZUeK2txux4av18Ei6QQ0xtebUllAUsWH LTag== X-Gm-Message-State: APjAAAX1OOpyVmDwMy74oAoR7vLVBMWtx5a6wsL7mz8ZSqjOQNUg5KZ2 GHhUFghd5AiMM3iDBx+HWWi8pgUvMEq3G8xrywe0wcOxmrk= X-Google-Smtp-Source: APXvYqw4u74ihwh5lMFD5ITa9R8ak7vDpJ92Ox+r97h5+RQUBuD7UuroCKIBwwAKXsRoUvTWXrBFGehGnFvgkzHEcD0= X-Received: by 2002:ac2:4c37:: with SMTP id u23mr7663082lfq.119.1563467254919; Thu, 18 Jul 2019 09:27:34 -0700 (PDT) MIME-Version: 1.0 References: <20190712170128.6495-1-leif.lindholm@linaro.org> In-Reply-To: <20190712170128.6495-1-leif.lindholm@linaro.org> From: "Leif Lindholm" Date: Thu, 18 Jul 2019 17:27:21 +0100 Message-ID: Subject: Re: [PATCH 0/3] add GetMaintainer.py helper script To: edk2-devel-groups-io Cc: Andrew Fish , Laszlo Ersek , Michael D Kinney , Philippe Mathieu-Daude , Bob Feng , Liming Gao , "Wu, Hao A" , Stefan Berger Content-Type: multipart/alternative; boundary="000000000000590b8d058df716e8" --000000000000590b8d058df716e8 Content-Type: text/plain; charset="UTF-8" Laszlo, Hao - I have prepared a set for pushing as below. (Reviewed-by: Leif Lindholm for all of your patches.) *But*, I need a review from Bob and/or Liming before I push the final one: "BaseTools: add GetMaintainer.py script" - https://edk2.groups.io/g/devel/message/43666 I have verified reviews/acks by all affected reviewers, except for Stefan Berger for Ovmf TCG/TPM2. While I would prefer to have that too, this is a file format shift - not a change in responsibility areas. Laszlo, do you agree? If so, I can push 1-7/8 as is. / Leif Hao A Wu (1): Maintainers.txt: Fine-grained review ownership for MdeModulePkg Laszlo Ersek (4): Maintainers.txt: split out section "ArmVirtPkg: modules used on Xen" Maintainers.txt: split out section "OvmfPkg: Xen-related modules" Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related modules" Maintainers.txt: split out section "OvmfPkg: CSM modules" Leif Lindholm (3): Maintainers.txt: update for filesystem area descriptions Maintainers.txt: add wildcard path association for Arm/AArch64 BaseTools: add GetMaintainer.py script On Fri, 12 Jul 2019 at 18:01, Leif Lindholm wrote: > Changes are available directly from: > > https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=upstreaming/git-maintainer-v1 > > This series adds new tags to the Maintainers.txt format, making it possible > to describe which filesystem paths are looked after by which people, and > hence automating the extraction of a list over who should be cc:d on a > patch > submission. > > Remaining shorcomings in v1: > - Will still be misparsing OvmfPkg and MdeModulePkg due to non-tag lines > interspersed with the tag lines. These lines will be removed as areas of > responsibility is formally rewritten as tags. > - * Wildcard support is not fully filesystem compliant except in first or > last position in the file pattern (it translates as regex .* elsewhere). > However, actual cases of mismatch are expected to be unlikely, and they > will be false positives rather than false negatives - so I think this is > good enough at least for a start. > - Provides no information of why certain people or meiling lists were > picked - it just bundles all recipients up, deduplicates them, and > prints them out. > > Using the script requires the gitpython module to be installed. > > Worthwhile mentioning outside the ChangeLog is the added -l flag, which > lets you look up what a given path would return in the way of matches. > E.g. "python BaseTools/Scripts/GetMaintainer.py -l Non/Existing/Path" > would return: > --- > Non/Existing/Path > "Non/Existing/Path": no maintainers found, looking for default > Andrew Fish > Laszlo Ersek > Leif Lindholm > Michael D Kinney > devel@edk2.groups.io > --- > > This series would still result in GetMaintainers.py missing some > maintainers/reviewers due to descriptions in prose rather than filename > patterns. My preferred way of handling this would be to merge 1-2/3 as > soon as found acceptable, following up and merging patches to update > ArmVirtPkg, MdeModulePkg, and OvmfPkg, and finally once the file is > consistent, proceed to merge 3/3. > > Changelog: > v1: > - Rebase to current Maintainers.txt. > - Fix typos and missed bits in Maintainers.txt. > - Get rid of the magic '' filename, let the single-char '*' > wildcard resolve this (_using_ the magic '' filename in the > script, but treating it as if it was a file in the top-level directory). > - Add -l flag to script to look up which maintainers would be returned for > a given path (which need not exist). > rfc: > - Split patches up > - one for new Maintainers.txt format (documentation and F: tags). > - one for adding a new wilcards responsibility area for */Arm, */AArch64 > - one for the GetMaintainer.py script > - Reworked wildcard handling based on Laszlo's explanation > - Trailing / covers everything under that directory > - Trailing * does not cover subdirectories > - Added support for X: tag > - Added support for magic '' pathname > - Also prints mailing list addresses for matching L: tags > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Michael D Kinney > Cc: Bob Feng > Cc: Liming Gao > Cc: Philippe Mathieu-Daude > Cc: "Wu, Hao A" > > Leif Lindholm (3): > Maintainers.txt: update for filesystem area descriptions > Maintainers.txt: add wildcard path association for Arm/AArch64 > BaseTools: add GetMaintainer.py script > > BaseTools/Scripts/GetMaintainer.py | 190 +++++++++++++++++++++++++++++ > Maintainers.txt | 54 ++++++++ > 2 files changed, 244 insertions(+) > create mode 100644 BaseTools/Scripts/GetMaintainer.py > > -- > 2.20.1 > > --000000000000590b8d058df716e8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Laszlo, Hao - I have prepared a set for pushing as be= low.

(Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> for all of = your patches.)
*But*, I need a review from=C2=A0 Bob and/or L= iming before I push the final one:
"BaseTools: add GetMainta= iner.py script" - https://edk2.groups.io/g/devel/message/43666

<= div>I have verified reviews/acks by all affected reviewers, except for Stef= an Berger for Ovmf TCG/TPM2.
While I would prefer to have that to= o, this is a file format shift - not a change in responsibility areas.
Laszlo, do you agree?
If so, I can push 1-7/8 as is.

/
=C2=A0=C2=A0=C2=A0 Leif
Hao A Wu (1):
=C2=A0 Maintainers.txt: Fine-grained review o= wnership for MdeModulePkg

Laszlo Ersek (4):
=C2=A0 Maintainers.tx= t: split out section "ArmVirtPkg: modules used on Xen"
=C2=A0 = Maintainers.txt: split out section "OvmfPkg: Xen-related modules"=
=C2=A0 Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-= related
=C2=A0 =C2=A0 modules"
=C2=A0 Maintainers.txt: split out= section "OvmfPkg: CSM modules"

Leif Lindholm (3):
=C2= =A0 Maintainers.txt: update for filesystem area descriptions
=C2=A0 Main= tainers.txt: add wildcard path association for Arm/AArch64
=C2=A0 BaseTo= ols: add GetMaintainer.py script


On Fri, 12 Jul 2019 at 18:01= , Leif Lindholm <leif.lindho= lm@linaro.org> wrote:
Changes are available directly from:
https://g= it.linaro.org/people/leif.lindholm/edk2.git/log/?h=3Dupstreaming/git-mainta= iner-v1

This series adds new tags to the Maintainers.txt format, making it possible=
to describe which filesystem paths are looked after by which people, and hence automating the extraction of a list over who should be cc:d on a patc= h
submission.

Remaining shorcomings in v1:
- Will still be misparsing OvmfPkg and MdeModulePkg due to non-tag lines =C2=A0 interspersed with the tag lines. These lines will be removed as area= s of
=C2=A0 responsibility is formally rewritten as tags.
- * Wildcard support is not fully filesystem compliant except in first or =C2=A0 last position in the file pattern (it translates as regex .* elsewhe= re).
=C2=A0 However, actual cases of mismatch are expected to be unlikely, and t= hey
=C2=A0 will be false positives rather than false negatives - so I think thi= s is
=C2=A0 good enough at least for a start.
- Provides no information of why certain people or meiling lists were
=C2=A0 picked - it just bundles all recipients up, deduplicates them, and =C2=A0 prints them out.

Using the script requires the gitpython module to be installed.

Worthwhile mentioning outside the ChangeLog is the added -l flag, which
lets you look up what a given path would return in the way of matches.
E.g. "python BaseTools/Scripts/GetMaintainer.py -l Non/Existing/Path&q= uot;
would return:
---
Non/Existing/Path
"Non/Existing/Path": no maintainers found, looking for default =C2=A0 Andrew Fish <afish@apple.com>
=C2=A0 Laszlo Ersek <lersek@redhat.com>
=C2=A0 Leif Lindholm <leif.lindholm@linaro.org>
=C2=A0 Michael D Kinney <michael.d.kinney@intel.com>
=C2=A0 devel@edk2= .groups.io
---

This series would still result in GetMaintainers.py missing some
maintainers/reviewers due to descriptions in prose rather than filename
patterns. My preferred way of handling this would be to merge 1-2/3 as
soon as found acceptable, following up and merging patches to update
ArmVirtPkg, MdeModulePkg, and OvmfPkg, and finally once the file is
consistent, proceed to merge 3/3.

Changelog:
v1:
- Rebase to current Maintainers.txt.
- Fix typos and missed bits in Maintainers.txt.
- Get rid of the magic '<default>' filename, let the single-c= har '*'
=C2=A0 wildcard resolve this (_using_ the magic '<default>' f= ilename in the
=C2=A0 script, but treating it as if it was a file in the top-level directo= ry).
- Add -l flag to script to look up which maintainers would be returned for<= br> =C2=A0 a given path (which need not exist).
rfc:
- Split patches up
=C2=A0 - one for new Maintainers.txt format (documentation and F: tags). =C2=A0 - one for adding a new wilcards responsibility area for */Arm, */AAr= ch64
=C2=A0 - one for the GetMaintainer.py script
- Reworked wildcard handling based on Laszlo's explanation
=C2=A0 - Trailing / covers everything under that directory
=C2=A0 - Trailing * does not cover subdirectories
- Added support for X: tag
- Added support for magic '<default>' pathname
- Also prints mailing list addresses for matching L: tags

Cc: Andrew Fish <af= ish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Bob Feng <= bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Philippe Mathieu-Daude <philmd@redhat.com>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>

Leif Lindholm (3):
=C2=A0 Maintainers.txt: update for filesystem area descriptions
=C2=A0 Maintainers.txt: add wildcard path association for Arm/AArch64
=C2=A0 BaseTools: add GetMaintainer.py script

=C2=A0BaseTools/Scripts/GetMaintainer.py | 190 ++++++++++++++++++++++++++++= +
=C2=A0Maintainers.txt=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 |=C2=A0 54 ++++++++
=C2=A02 files changed, 244 insertions(+)
=C2=A0create mode 100644 BaseTools/Scripts/GetMaintainer.py

--
2.20.1

--000000000000590b8d058df716e8--