public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Pete Batard <pete@akeo.ie>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
Subject: Re: [edk2-platforms][PATCH v2 0/7] Platform/RPi: Early Raspberry Pi 4 groundwork
Date: Tue, 19 Nov 2019 18:20:41 +0000	[thread overview]
Message-ID: <CAF7UmSxF3AGZwyTygKZQ4vZcu=04dTLkWUCQR8pEtZcq6y_o3Q@mail.gmail.com> (raw)
In-Reply-To: <20191119113809.2472-1-pete@akeo.ie>

[-- Attachment #1: Type: text/plain, Size: 3538 bytes --]

On Tue, 19 Nov 2019 at 11:38, Pete Batard <pete@akeo.ie> wrote:
>
> Changes from v1 (https://edk2.groups.io/g/devel/message/50689 - 50697):
> - Split missing "Raspberry Pi Compute Module 3+" model from the "model
name" patch
> - Update Samer's e-mail address
> - Drop leading __ in new header guards
> - List new PCDs, headers and LibraryClasses in alphabetical order where
possible
> - Use a single PCD for the SoC registers base address and use offsets to
derive
>   the other registers address from that PCD
> - Add a comment in RaspberryPiHelper.S to indicate that x1 keeps its value
> - Mention that RaspberryPiMem.c is derived from code from ArmJunoMem.c
>
> Pete Batard (3):
>   Silicon/Broadcom: Add Bcm2711 header
>   Platform/RPi: Read more variables from VideoCore during early init
>   Platform/RPi: Clean up and improve early memory init
>
> Samer El-Haj-Mahmoud (4):
>   Platform/RPi: Add missing model name
>   Platform/RPi: Add model family detection
>   Platform/RPi: Replace Bcm283x SoC base register address with a PCD
>   Platform/RPi: Use offsets for Bcm238x SoC register addresses

For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 6dfc9b39cc2e..61b6c05bdf3e.

Thanks!

/
    Leif

>  Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf   |
2 +
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf                 |
2 +
>  Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf           |
4 +
>  Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwcHw.h                    |
4 +-
>  Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c         |
 64 +++++
>  Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.inf       |
5 +-
>  Platform/RaspberryPi/Drivers/SdHostDxe/SdHostDxe.inf                 |
2 +
>  Platform/RaspberryPi/Include/IndustryStandard/RpiMbox.h              |
1 +
>  Platform/RaspberryPi/Include/Library/RPiMem.h                        |
 26 ++
>  Platform/RaspberryPi/Include/Protocol/RpiFirmware.h                  |
8 +
>  Platform/RaspberryPi/Library/MemoryInitPeiLib/MemoryInitPeiLib.c     |
 94 ++++---
>  Platform/RaspberryPi/Library/MemoryInitPeiLib/MemoryInitPeiLib.inf   |
1 +
>  Platform/RaspberryPi/Library/PlatformLib/AArch64/RaspberryPiHelper.S |
 76 +++++-
>  Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf             |
6 +-
>  Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c            |
256 +++++++++++---------
>  Platform/RaspberryPi/RPi3/RPi3.dsc                                   |
7 +-
>  Platform/RaspberryPi/RaspberryPi.dec                                 |
1 +
>  Silicon/Broadcom/Bcm27xx/Bcm27xx.dec                                 |
 22 ++
>  Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h          |
 15 ++
>  Silicon/Broadcom/Bcm283x/Bcm283x.dec                                 |
7 +
>  Silicon/Broadcom/Bcm283x/Drivers/InterruptDxe/InterruptDxe.inf       |
4 +-
>  Silicon/Broadcom/Bcm283x/Drivers/RngDxe/RngDxe.inf                   |
5 +
>  Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h          |
 11 +-
>  Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Sdio.h      |
4 +-
>  Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf                 |
4 +
>  25 files changed, 459 insertions(+), 172 deletions(-)
>  create mode 100644 Platform/RaspberryPi/Include/Library/RPiMem.h
>  create mode 100644 Silicon/Broadcom/Bcm27xx/Bcm27xx.dec
>  create mode 100644
Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h
>
> --
> 2.21.0.windows.1
>

[-- Attachment #2: Type: text/html, Size: 4473 bytes --]

      parent reply	other threads:[~2019-11-19 18:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19 11:38 [edk2-platforms][PATCH v2 0/7] Platform/RPi: Early Raspberry Pi 4 groundwork Pete Batard
2019-11-19 11:38 ` [edk2-platforms][PATCH v2 1/7] Platform/RPi: Add missing model name Pete Batard
2019-11-19 12:02   ` Philippe Mathieu-Daudé
2019-11-19 12:14     ` [edk2-devel] " Leif Lindholm
2019-11-19 12:25       ` Philippe Mathieu-Daudé
2019-11-19 12:50         ` Leif Lindholm
2019-11-19 12:25     ` Pete Batard
2019-11-19 11:38 ` [edk2-platforms][PATCH v2 2/7] Platform/RPi: Add model family detection Pete Batard
2019-11-19 11:38 ` [edk2-platforms][PATCH v2 3/7] Platform/RPi: Replace Bcm283x SoC base register address with a PCD Pete Batard
2019-11-19 11:43   ` Philippe Mathieu-Daudé
2019-11-19 11:57     ` Pete Batard
2019-11-19 12:16       ` Philippe Mathieu-Daudé
2019-11-19 12:44         ` Leif Lindholm
2019-11-19 12:51           ` Ard Biesheuvel
2019-11-19 11:38 ` [edk2-platforms][PATCH v2 4/7] Platform/RPi: Use offsets for Bcm238x SoC register addresses Pete Batard
2019-11-19 11:46   ` Philippe Mathieu-Daudé
2019-11-19 11:38 ` [edk2-platforms][PATCH v2 5/7] Silicon/Broadcom: Add Bcm2711 header Pete Batard
2019-11-19 11:51   ` Philippe Mathieu-Daudé
2019-11-19 11:38 ` [edk2-platforms][PATCH v2 6/7] Platform/RPi: Read more variables from VideoCore during early init Pete Batard
2019-11-19 11:38 ` [edk2-platforms][PATCH v2 7/7] Platform/RPi: Clean up and improve early memory init Pete Batard
2019-11-19 18:20 ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAF7UmSxF3AGZwyTygKZQ4vZcu=04dTLkWUCQR8pEtZcq6y_o3Q@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox