From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by mx.groups.io with SMTP id smtpd.web09.481.1574187655551021094 for ; Tue, 19 Nov 2019 10:20:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=c/sGF27M; spf=pass (domain: linaro.org, ip: 209.85.208.194, mailfrom: leif.lindholm@linaro.org) Received: by mail-lj1-f194.google.com with SMTP id m4so19510914ljj.8 for ; Tue, 19 Nov 2019 10:20:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1atTYsfVnV5nHZMd8pIxpuxuBM5qTyK9f9vyZ9H0X+o=; b=c/sGF27M3cmWiLaz6u3nYGyoOj5AURgvzWOZ1YF9kUtQXJNFy2OJq9UzyWT97kE10H IYgZw1dJ54vkcA6XoU/eylc2w7X0cL3+v6xSrrAxVbL1psPCsy5dozk/vy0cOTlg9N0s 8sdw6JjkToaPgo6L27f+wAWBi1omSNBgEGZB6itZm/IsUYcEZyozFhxSVPabvw9EB/xQ BszPN/ZnrPtGTo1mT2FMi4/TTLA4vOT8JsbtfrfCpEImxRJzcG1Th1A8DsqkIDx5aPXa Tv77r7VET2U2aiSIx4NVz7a08gvIjKrPQbvi/Urbjmdv2saGqL+5dlJGp7qzZ8WjGFLh vNBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1atTYsfVnV5nHZMd8pIxpuxuBM5qTyK9f9vyZ9H0X+o=; b=r/oY15DPaXLHY6TJl3hZN6pyLNfzYUQtUHTOGMRx2x259LbSC2sbX2n2fYuojNCzz3 gYMANY6fAYxjS+KG5eXpfnbpyffViiCHgGFpI8kjUR0WRAG+pd1B7KyW4Kjr7UPOsa3e P/Wm6u1f78L5o2dJ0d/hksR67GDaMSSgpe8AhZ0D8zVeht4wPEER8Y0PO4/ZweiXeHjE 5HYPK1/0Z2sqi58+29jVuAtNmhtKcE3SUWoq8G4gxz5HDUpA6yV3edJ4+1LnS5ZyDe5K kKBRvf8LG6M4tHUbroBQ7lGFJGpTN1z3gwE0DDrnijZHcYsafCnsyBexiO+Q3C25h2kL a7MQ== X-Gm-Message-State: APjAAAVVM3rfchH3tfYiAEqfNz7JYYsVvjx+gakJpw0EoeL24SsE5dc7 SH5A0Ajb1H1f8U1L4Pir+D/ya7hh1XifatfW5pYiCA== X-Google-Smtp-Source: APXvYqychISL9pMg03RLmHl8oZfsEUTQdNsGlAwtnqoJoUxzb9G6MNv6mnEYIy+eYu4hNqxwVJKu3L5ZuDtDn3ifuyY= X-Received: by 2002:a2e:6a10:: with SMTP id f16mr5371038ljc.100.1574187653749; Tue, 19 Nov 2019 10:20:53 -0800 (PST) MIME-Version: 1.0 References: <20191119113809.2472-1-pete@akeo.ie> In-Reply-To: <20191119113809.2472-1-pete@akeo.ie> From: "Leif Lindholm" Date: Tue, 19 Nov 2019 18:20:41 +0000 Message-ID: Subject: Re: [edk2-platforms][PATCH v2 0/7] Platform/RPi: Early Raspberry Pi 4 groundwork To: Pete Batard Cc: edk2-devel-groups-io , Ard Biesheuvel , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Samer El-Haj-Mahmoud Content-Type: multipart/alternative; boundary="000000000000e9b2a00597b71f22" --000000000000e9b2a00597b71f22 Content-Type: text/plain; charset="UTF-8" On Tue, 19 Nov 2019 at 11:38, Pete Batard wrote: > > Changes from v1 (https://edk2.groups.io/g/devel/message/50689 - 50697): > - Split missing "Raspberry Pi Compute Module 3+" model from the "model name" patch > - Update Samer's e-mail address > - Drop leading __ in new header guards > - List new PCDs, headers and LibraryClasses in alphabetical order where possible > - Use a single PCD for the SoC registers base address and use offsets to derive > the other registers address from that PCD > - Add a comment in RaspberryPiHelper.S to indicate that x1 keeps its value > - Mention that RaspberryPiMem.c is derived from code from ArmJunoMem.c > > Pete Batard (3): > Silicon/Broadcom: Add Bcm2711 header > Platform/RPi: Read more variables from VideoCore during early init > Platform/RPi: Clean up and improve early memory init > > Samer El-Haj-Mahmoud (4): > Platform/RPi: Add missing model name > Platform/RPi: Add model family detection > Platform/RPi: Replace Bcm283x SoC base register address with a PCD > Platform/RPi: Use offsets for Bcm238x SoC register addresses For the series: Reviewed-by: Leif Lindholm Pushed as 6dfc9b39cc2e..61b6c05bdf3e. Thanks! / Leif > Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf | 2 + > Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf | 2 + > Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf | 4 + > Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwcHw.h | 4 +- > Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 64 +++++ > Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.inf | 5 +- > Platform/RaspberryPi/Drivers/SdHostDxe/SdHostDxe.inf | 2 + > Platform/RaspberryPi/Include/IndustryStandard/RpiMbox.h | 1 + > Platform/RaspberryPi/Include/Library/RPiMem.h | 26 ++ > Platform/RaspberryPi/Include/Protocol/RpiFirmware.h | 8 + > Platform/RaspberryPi/Library/MemoryInitPeiLib/MemoryInitPeiLib.c | 94 ++++--- > Platform/RaspberryPi/Library/MemoryInitPeiLib/MemoryInitPeiLib.inf | 1 + > Platform/RaspberryPi/Library/PlatformLib/AArch64/RaspberryPiHelper.S | 76 +++++- > Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf | 6 +- > Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c | 256 +++++++++++--------- > Platform/RaspberryPi/RPi3/RPi3.dsc | 7 +- > Platform/RaspberryPi/RaspberryPi.dec | 1 + > Silicon/Broadcom/Bcm27xx/Bcm27xx.dec | 22 ++ > Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h | 15 ++ > Silicon/Broadcom/Bcm283x/Bcm283x.dec | 7 + > Silicon/Broadcom/Bcm283x/Drivers/InterruptDxe/InterruptDxe.inf | 4 +- > Silicon/Broadcom/Bcm283x/Drivers/RngDxe/RngDxe.inf | 5 + > Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h | 11 +- > Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Sdio.h | 4 +- > Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf | 4 + > 25 files changed, 459 insertions(+), 172 deletions(-) > create mode 100644 Platform/RaspberryPi/Include/Library/RPiMem.h > create mode 100644 Silicon/Broadcom/Bcm27xx/Bcm27xx.dec > create mode 100644 Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h > > -- > 2.21.0.windows.1 > --000000000000e9b2a00597b71f22 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, 19 Nov 2019 at 11:38, Pete Batard <pete@akeo.ie> wrote:
>
> Cha= nges from v1 (http= s://edk2.groups.io/g/devel/message/50689 - 50697):
> - Split miss= ing "Raspberry Pi Compute Module 3+" model from the "model n= ame" patch
> - Update Samer's e-mail address
> - Drop = leading __ in new header guards
> - List new PCDs, headers and Librar= yClasses in alphabetical order where possible
> - Use a single PCD fo= r the SoC registers base address and use offsets to derive
> =C2=A0 t= he other registers address from that PCD
> - Add a comment in Raspber= ryPiHelper.S to indicate that x1 keeps its value
> - Mention that Ras= pberryPiMem.c is derived from code from ArmJunoMem.c
>
> Pete B= atard (3):
> =C2=A0 Silicon/Broadcom: Add Bcm2711 header
> =C2= =A0 Platform/RPi: Read more variables from VideoCore during early init
&= gt; =C2=A0 Platform/RPi: Clean up and improve early memory init
>
= > Samer El-Haj-Mahmoud (4):
> =C2=A0 Platform/RPi: Add missing mod= el name
> =C2=A0 Platform/RPi: Add model family detection
> =C2= =A0 Platform/RPi: Replace Bcm283x SoC base register address with a PCD
<= div>> =C2=A0 Platform/RPi: Use offsets for Bcm238x SoC register addresse= s

For the series:
Reviewed-by: Leif = Lindholm <leif.lindholm@lina= ro.org>
Pushed as 6dfc9b39cc2e..61b6c05bdf3e.

Thanks!

/
=C2=A0=C2=A0= =C2=A0 Leif

> =C2=A0Platform/RaspberryPi/Drivers/ArasanMmcH= ostDxe/ArasanMmcHostDxe.inf =C2=A0 | =C2=A0 2 +
> =C2=A0Platform/Rasp= berryPi/Drivers/ConfigDxe/ConfigDxe.inf =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 | =C2=A0 2 +
> =C2=A0Platform/RaspberryPi/Driver= s/DwUsbHostDxe/DwUsbHostDxe.inf =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0= 4 +
> =C2=A0Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwcHw.h =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 4 += -
> =C2=A0Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.= c =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A064 +++++
> =C2=A0Platform/Raspb= erryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.inf =C2=A0 =C2=A0 =C2=A0 | =C2= =A0 5 +-
> =C2=A0Platform/RaspberryPi/Drivers/SdHostDxe/SdHostDxe.inf= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 2 +
&g= t; =C2=A0Platform/RaspberryPi/Include/IndustryStandard/RpiMbox.h =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 1 +
> =C2=A0Platform/R= aspberryPi/Include/Library/RPiMem.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A026 ++
> =C2=A0Pl= atform/RaspberryPi/Include/Protocol/RpiFirmware.h =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 8 +
> =C2=A0Platform/R= aspberryPi/Library/MemoryInitPeiLib/MemoryInitPeiLib.c =C2=A0 =C2=A0 | =C2= =A094 ++++---
> =C2=A0Platform/RaspberryPi/Library/MemoryInitPeiLib/M= emoryInitPeiLib.inf =C2=A0 | =C2=A0 1 +
> =C2=A0Platform/RaspberryPi/= Library/PlatformLib/AArch64/RaspberryPiHelper.S | =C2=A076 +++++-
> = =C2=A0Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 6 +-
> =C2=A0Platform/Raspbe= rryPi/Library/PlatformLib/RaspberryPiMem.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0| 256 +++++++++++---------
> =C2=A0Platform/RaspberryPi/RPi= 3/RPi3.dsc =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 7 +-
&g= t; =C2=A0Platform/RaspberryPi/RaspberryPi.dec =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 | =C2=A0 1 +
> =C2=A0Silicon/Broadcom/Bcm27xx/Bcm27xx.dec = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A022 ++
> =C2=A0Silicon/= Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0| =C2=A015 ++
> =C2=A0Silicon/Broadcom/Bcm283x/Bcm283x.d= ec =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 7 +
> =C2=A0Silico= n/Broadcom/Bcm283x/Drivers/InterruptDxe/InterruptDxe.inf =C2=A0 =C2=A0 =C2= =A0 | =C2=A0 4 +-
> =C2=A0Silicon/Broadcom/Bcm283x/Drivers/RngDxe/Rng= Dxe.inf =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | = =C2=A0 5 +
> =C2=A0Silicon/Broadcom/Bcm283x/Include/IndustryStandard/= Bcm2836.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A011 +-
> =C2=A0Sil= icon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Sdio.h =C2=A0 =C2=A0 = =C2=A0| =C2=A0 4 +-
> =C2=A0Silicon/Broadcom/Bcm283x/Library/GpioLib/= GpioLib.inf =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2= =A0 4 +
> =C2=A025 files changed, 459 insertions(+), 172 deletions(-)=
> =C2=A0create mode 100644 Platform/RaspberryPi/Include/Library/RPiM= em.h
> =C2=A0create mode 100644 Silicon/Broadcom/Bcm27xx/Bcm27xx.dec<= br>> =C2=A0create mode 100644 Silicon/Broadcom/Bcm27xx/Include/IndustryS= tandard/Bcm2711.h
>
> --
> 2.21.0.windows.1
>
--000000000000e9b2a00597b71f22--