Hi Leif,

I will see if we can add a proper file header with a description.

I may break this out into its own patch since it is useful to
install these pip modules to run CI tests and builds locally.
The pip modules are not only use in a CI agent.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Leif Lindholm
> Sent: Tuesday, October 29, 2019 8:03 PM
> To: devel@edk2.groups.io; sean.brogan@microsoft.com
> Subject: Re: [edk2-devel] [Patch v3 03/22]
> requirements.txt: Add python pip requirements file
>
> OK, if it makes a difference for tools (and security
> updates), let's try to keep it. (*grumble*)
>
> *But* given its too-generic name, can we add a big bold
> comment header to the file explaining what it is?
> Some quick searching suggests lines starting with # are
> ignored, so hopefully this should be possible?
>
> Best Regards,
>
> Leif
>
> On Tue, Oct 29, 2019 at 07:52:48PM -0700, Sean via
> Groups.Io wrote:
> > It is a convention for projects using python.  It
> definitely isn't required but there are some features
> that come for free when using that filename.
> >
> > https://github.blog/2018-07-12-security-vulnerability-
> alerts-for-pytho
> > n/
> > and
> > https://help.github.com/en/github/visualizing-
> repository-data-with-gra
> > phs/listing-the-packages-that-a-repository-depends-on
> >
> > You can also get more insight from github into
> dependencies and dependents.
> > example:
> > https://github.com/tianocore/edk2-pytool-
> extensions/network/dependenci
> > es
> >
> > I did notice on the example from above that github
> picked up the requirements.publisher.txt so i don't know
> what their pattern matching does exactly.
> >
> >
> >
>
>