From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by mx.groups.io with SMTP id smtpd.web12.2022.1572497951273087374 for ; Wed, 30 Oct 2019 21:59:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=sTHeu4yv; spf=pass (domain: linaro.org, ip: 209.85.208.181, mailfrom: leif.lindholm@linaro.org) Received: by mail-lj1-f181.google.com with SMTP id t5so5194173ljk.0 for ; Wed, 30 Oct 2019 21:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b8usvab/EmV5SIp4PvFcP1G+L6rNiRnCYB7YExqaypQ=; b=sTHeu4yvA1hco0YbYoxqfTyGSBvGFUgndgXUbQ1h4obCKXojNAKPBsykFk9/COHjdZ BQz8SW0Dd86ph4fJ4qIq7wWvrYAw39AB/1W9eYKACM+9ohLfwXS/oGBTsWiM5JgK+KpA 9J+96iY6wTu/EfzPj4e2Gx59Nyi+M4/QD8xGmxz5ZDLRFGqFyx4Qx3OilX2UFlb8ZXf9 uSbEG2VZ1Ko00i5WIN5arLo8slwv2AYdUJvYZmk6FTru+7WXB/l/mIhLCseuLbtvtT2J Pi4H8LOGAB4z1IZT2CG60ZvduUbcfAWs+W048IU27f0Rw1pwKIzeot8L68wtcNe6Wsu9 wAsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b8usvab/EmV5SIp4PvFcP1G+L6rNiRnCYB7YExqaypQ=; b=IOJrYaVeyKO3bOz0t/qxVO53AZnKgOSpJNAzeQz1FNJfzm7L5GCv0bODmi1rOBsVPH d76k/yOfwWfIDbIK8p8Hia1RV7kcnpEk/W0EEuRsbWfDv4Kvvq7KvRCirP+hMyQT3AgL WEG2e+spYqsUjBjAwYYmGmJqc5l92cB4rwewmhN5vcXV09bWQ+ekDUn6Ze7UjcevBkYq EMWbDxvTY+3QF7+ElblMI2oYHq+alsV1rhiX0FRXSQyrBQzHw2983GB4Yicv+xruTFhZ WJOA2c96lFS18SrNT4k80u9nRA/y0WT+hFRANbzONoVVVXgTZLthfgCOz7Fn1Mq5FygS wujg== X-Gm-Message-State: APjAAAUw3nD2kyiz0dqHwTB24leNCsQmQsJzJIIpsUzc1o9T2DA/R21s ROCPD0R4tBdsMnFwKqLyQHOlwI8G41Xo43ATMCml+w== X-Google-Smtp-Source: APXvYqy1GlXOnGDTRYpI6zSD28rVD/OwcwwoOtBZuRLk9DSD1AgkM0yWnRkUAJ6LGPCAv6lrYNSII/88UD9e/gzNNws= X-Received: by 2002:a2e:819a:: with SMTP id e26mr2424509ljg.26.1572497949411; Wed, 30 Oct 2019 21:59:09 -0700 (PDT) MIME-Version: 1.0 References: <20191030022757.GS16820@bivouac.eciton.net> <2748.1572403968433015098@groups.io> <20191030030302.GW16820@bivouac.eciton.net> In-Reply-To: From: "Leif Lindholm" Date: Thu, 31 Oct 2019 12:58:57 +0800 Message-ID: Subject: Re: [edk2-devel] [Patch v3 03/22] requirements.txt: Add python pip requirements file To: "Kinney, Michael D" Cc: edk2-devel-groups-io , Sean Brogan Content-Type: multipart/alternative; boundary="000000000000af608c05962db5f6" --000000000000af608c05962db5f6 Content-Type: text/plain; charset="UTF-8" Agreed. On Thu, 31 Oct 2019, 12:39 Kinney, Michael D, wrote: > Hi Leif, > > I will see if we can add a proper file header with a description. > > I may break this out into its own patch since it is useful to > install these pip modules to run CI tests and builds locally. > The pip modules are not only use in a CI agent. > > Mike > > > -----Original Message----- > > From: devel@edk2.groups.io On > > Behalf Of Leif Lindholm > > Sent: Tuesday, October 29, 2019 8:03 PM > > To: devel@edk2.groups.io; sean.brogan@microsoft.com > > Subject: Re: [edk2-devel] [Patch v3 03/22] > > requirements.txt: Add python pip requirements file > > > > OK, if it makes a difference for tools (and security > > updates), let's try to keep it. (*grumble*) > > > > *But* given its too-generic name, can we add a big bold > > comment header to the file explaining what it is? > > Some quick searching suggests lines starting with # are > > ignored, so hopefully this should be possible? > > > > Best Regards, > > > > Leif > > > > On Tue, Oct 29, 2019 at 07:52:48PM -0700, Sean via > > Groups.Io wrote: > > > It is a convention for projects using python. It > > definitely isn't required but there are some features > > that come for free when using that filename. > > > > > > https://github.blog/2018-07-12-security-vulnerability- > > alerts-for-pytho > > > n/ > > > and > > > https://help.github.com/en/github/visualizing- > > repository-data-with-gra > > > phs/listing-the-packages-that-a-repository-depends-on > > > > > > You can also get more insight from github into > > dependencies and dependents. > > > example: > > > https://github.com/tianocore/edk2-pytool- > > extensions/network/dependenci > > > es > > > > > > I did notice on the example from above that github > > picked up the requirements.publisher.txt so i don't know > > what their pattern matching does exactly. > > > > > > > > > > > > > > > --000000000000af608c05962db5f6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Agreed.

On Thu, 31 Oct 2019, 12:39 Kinney, Michael D, <= michael.d.kinney@intel.com> wrote:
Hi Leif,

I will see if we can add a proper file header with a description.

I may break this out into its own patch since it is useful to
install these pip modules to run CI tests and builds locally.
The pip modules are not only use in a CI agent.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io>= ; On
> Behalf Of Leif Lindholm
> Sent: Tuesday, October 29, 2019 8:03 PM
> To: devel@edk2.groups.io; sean.brogan@microsoft.com<= br> > Subject: Re: [edk2-devel] [Patch v3 03/22]
> requirements.txt: Add python pip requirements file
>
> OK, if it makes a difference for tools (and security
> updates), let's try to keep it. (*grumble*)
>
> *But* given its too-generic name, can we add a big bold
> comment header to the file explaining what it is?
> Some quick searching suggests lines starting with # are
> ignored, so hopefully this should be possible?
>
> Best Regards,
>
> Leif
>
> On Tue, Oct 29, 2019 at 07:52:48PM -0700, Sean via
> Groups.Io wrote:
> > It is a convention for projects using python.=C2=A0 It
> definitely isn't required but there are some features
> that come for free when using that filename.
> >
> > https://github.blog/2018= -07-12-security-vulnerability-
> alerts-for-pytho
> > n/
> > and
> > https://help.github.com/en/gi= thub/visualizing-
> repository-data-with-gra
> > phs/listing-the-packages-that-a-repository-depends-on
> >
> > You can also get more insight from github into
> dependencies and dependents.
> > example:
> > https://github.com/tianocore/edk2-pyt= ool-
> extensions/network/dependenci
> > es
> >
> > I did notice on the example from above that github
> picked up the requirements.publisher.txt so i don't know
> what their pattern matching does exactly.
> >
> >
> >
>
>

--000000000000af608c05962db5f6--