Re: [PATCH] MdeModulePkg: add ARM/AARCH64 requirements to .dsc

[Leif Lindholm <leif.lindholm@linaro.org>]

On 19 October 2016 at 23:56, Kinney, Michael D
<michael.d.kinney@intel.com> wrote:
> Yes.  Please commit.

Thanks - pushed as b752e8a3fb685ae04155bf6a34a9aac83810613f

> I see this was rb 3 weeks ago, and was not picked up by the MdeModulePkg maintainers.
>
> Are you aware of any tools to help us notice if a commit like this is missed so
> we can ping the maintainers?

Not really. It'd be tricky to pick up on which patchsets should go in
and which shouldn't.
Although I'd be happy to hear suggestions from others for tools to
help maintainers keep track.

/
    Leif

> Mike
>
>> -----Original Message-----
>> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
>> Sent: Wednesday, October 19, 2016 11:58 PM
>> To: Andrew Fish <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>
>> Cc: edk2-devel-01 <edk2-devel@lists.01.org>; Ard Biesheuvel
>> <ard.biesheuvel@linaro.org>; Tian, Feng <feng.tian@intel.com>; Zeng, Star
>> <star.zeng@intel.com>
>> Subject: Re: [PATCH] MdeModulePkg: add ARM/AARCH64 requirements to .dsc
>>
>> Andrew, Mike - are you OK with me committing this?
>>
>> On 27 September 2016 at 03:24, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>> > On 26 September 2016 at 18:15, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>> >> Some LibraryClasses entries are missing to enable standalone builds
>> >> of MdeModulePkg components for ARM/AARCH64. Add those.
>> >>
>> >> Contributed-under: TianoCore Contribution Agreement 1.0
>> >> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>> >
>> > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> >
>> >> ---
>> >>
>> >> Tying back to the conversation in
>> >> https://lists.01.org/pipermail/edk2-devel/2016-August/000733.html
>> >>
>> >> If we are not going to refactor the DxeIpl code, would this be an
>> >> acceptable fix to enable standalone HelloWorld builds on ARM/AARCH64?
>> >>
>> >> BaseStackCheckLib is unrelated to the DxeIpl issue, but needed in
>> >> practice on ARM and in theory on AARCH64.
>> >>
>> >>  MdeModulePkg/MdeModulePkg.dsc | 9 +++++++++
>> >>  1 file changed, 9 insertions(+)
>> >>
>> >> diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
>> >> index 05120c7..3eb55db 100644
>> >> --- a/MdeModulePkg/MdeModulePkg.dsc
>> >> +++ b/MdeModulePkg/MdeModulePkg.dsc
>> >> @@ -160,6 +160,9 @@ [LibraryClasses.common.UEFI_APPLICATION]
>> >>    DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
>> >>
>> >>  [LibraryClasses.ARM, LibraryClasses.AARCH64]
>> >> +  ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
>> >> +  ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
>> >> +
>> >>    #
>> >>    # It is not possible to prevent ARM compiler calls to generic intrinsic
>> functions.
>> >>    # This library provides the instrinsic functions generated by a given compiler.
>> >> @@ -167,6 +170,12 @@ [LibraryClasses.ARM, LibraryClasses.AARCH64]
>> >>    #
>> >>    NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
>> >>
>> >> +  #
>> >> +  # Since software stack checking may be heuristically enabled by the compiler
>> >> +  # include BaseStackCheckLib unconditionally.
>> >> +  #
>> >> +  NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>> >> +
>> >>  [LibraryClasses.EBC]
>> >>    LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
>> >>
>> >> --
>> >> 2.9.3
>> >>