From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 480121A1E2A for ; Thu, 20 Oct 2016 01:18:04 -0700 (PDT) Received: by mail-it0-x22c.google.com with SMTP id 66so76826279itl.1 for ; Thu, 20 Oct 2016 01:18:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=CZp4fB+fYnxfqPau1a2qZS7zjM7DidWF1rBtbchdQEQ=; b=Isy1M3bODpZaKAhxBNR5jme1DUHX4Y7sm2GEmN+hnJh7SDvBdYJNbjvOOAgwzej0n1 9Qtgh1MlWGCVqhIDhCy2KFUZZuKntA54I28QDMygyQKm3XquFZF+7lYvYXzy8la2MCg7 s7t59lLDzCX6VXa2T3x5w/udZWUDVLFiU5VrU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=CZp4fB+fYnxfqPau1a2qZS7zjM7DidWF1rBtbchdQEQ=; b=eY/voTCCQslXju/aiZXhZjl6QqCIEdehKffAsWxXix6AFWTb/DNOq8o0TGGMcc/oc8 WSVmJC/AL4sN5qswmDvUlVdB1lSkTVS1+XH9Mc5S4Zbh9MtTXKLU8ieqIWZD3UiBWbBL wovNsUdkjPAd5sT50oSo4kPKl97WGcrxdH3F1rKZPkFrb3sH3gOq4w5lxd5/D4jlw1xA GGjT8uqDlJ+5lnis49MRrXnxsz8E1akJrDtdZRv1i/PsqD5ih/CZdqvgkxR5eU6DN/F3 O+lMwSnyq+RfDXMQDXwURJP3xYsvGVqwJ43FuN+olw/LZcMFOP53mguk981UUJ8D6PKx VE4Q== X-Gm-Message-State: AA6/9RkZevVLZLNnGzfyicDjzqnUEQc4FiccItd9vG5S0oDHIIEESRk5eLgAy3K9R7wAeYvrO/j1HH0uf3Mav8zF X-Received: by 10.36.130.135 with SMTP id t129mr10963362itd.31.1476951476551; Thu, 20 Oct 2016 01:17:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.110.99 with HTTP; Thu, 20 Oct 2016 01:17:55 -0700 (PDT) In-Reply-To: References: <20160927011552.20384-1-leif.lindholm@linaro.org> From: Leif Lindholm Date: Thu, 20 Oct 2016 09:17:55 +0100 Message-ID: To: "Kinney, Michael D" Cc: Andrew Fish , edk2-devel-01 , Ard Biesheuvel , "Tian, Feng" , "Zeng, Star" Subject: Re: [PATCH] MdeModulePkg: add ARM/AARCH64 requirements to .dsc X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2016 08:18:04 -0000 Content-Type: text/plain; charset=UTF-8 On 19 October 2016 at 23:56, Kinney, Michael D wrote: > Yes. Please commit. Thanks - pushed as b752e8a3fb685ae04155bf6a34a9aac83810613f > I see this was rb 3 weeks ago, and was not picked up by the MdeModulePkg maintainers. > > Are you aware of any tools to help us notice if a commit like this is missed so > we can ping the maintainers? Not really. It'd be tricky to pick up on which patchsets should go in and which shouldn't. Although I'd be happy to hear suggestions from others for tools to help maintainers keep track. / Leif > Mike > >> -----Original Message----- >> From: Leif Lindholm [mailto:leif.lindholm@linaro.org] >> Sent: Wednesday, October 19, 2016 11:58 PM >> To: Andrew Fish ; Kinney, Michael D >> Cc: edk2-devel-01 ; Ard Biesheuvel >> ; Tian, Feng ; Zeng, Star >> >> Subject: Re: [PATCH] MdeModulePkg: add ARM/AARCH64 requirements to .dsc >> >> Andrew, Mike - are you OK with me committing this? >> >> On 27 September 2016 at 03:24, Ard Biesheuvel wrote: >> > On 26 September 2016 at 18:15, Leif Lindholm wrote: >> >> Some LibraryClasses entries are missing to enable standalone builds >> >> of MdeModulePkg components for ARM/AARCH64. Add those. >> >> >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> >> Signed-off-by: Leif Lindholm >> > >> > Reviewed-by: Ard Biesheuvel >> > >> >> --- >> >> >> >> Tying back to the conversation in >> >> https://lists.01.org/pipermail/edk2-devel/2016-August/000733.html >> >> >> >> If we are not going to refactor the DxeIpl code, would this be an >> >> acceptable fix to enable standalone HelloWorld builds on ARM/AARCH64? >> >> >> >> BaseStackCheckLib is unrelated to the DxeIpl issue, but needed in >> >> practice on ARM and in theory on AARCH64. >> >> >> >> MdeModulePkg/MdeModulePkg.dsc | 9 +++++++++ >> >> 1 file changed, 9 insertions(+) >> >> >> >> diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc >> >> index 05120c7..3eb55db 100644 >> >> --- a/MdeModulePkg/MdeModulePkg.dsc >> >> +++ b/MdeModulePkg/MdeModulePkg.dsc >> >> @@ -160,6 +160,9 @@ [LibraryClasses.common.UEFI_APPLICATION] >> >> DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf >> >> >> >> [LibraryClasses.ARM, LibraryClasses.AARCH64] >> >> + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf >> >> + ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf >> >> + >> >> # >> >> # It is not possible to prevent ARM compiler calls to generic intrinsic >> functions. >> >> # This library provides the instrinsic functions generated by a given compiler. >> >> @@ -167,6 +170,12 @@ [LibraryClasses.ARM, LibraryClasses.AARCH64] >> >> # >> >> NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf >> >> >> >> + # >> >> + # Since software stack checking may be heuristically enabled by the compiler >> >> + # include BaseStackCheckLib unconditionally. >> >> + # >> >> + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf >> >> + >> >> [LibraryClasses.EBC] >> >> LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf >> >> >> >> -- >> >> 2.9.3 >> >>