From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 75B261A1E56 for ; Wed, 19 Oct 2016 08:57:31 -0700 (PDT) Received: by mail-io0-x234.google.com with SMTP id j37so36108595ioo.3 for ; Wed, 19 Oct 2016 08:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LtXfBCwNb9fehZVzNUrFh78/T3MWNAkZOJrefrZPMJo=; b=QZRELXUyyI09Xx4pGc+YSyRlfPR/J9egj9Dhzi75Jmv/Jj/Ms0HJ4MmJbOPj4P3NJm w00s7WnH4eQIk58RP1hfB9n7KXS1tOxD+sTUu6uqYefdLKC7bl/OGciaGYwXcT0JvaHq RfiLYEBZWd4/yRhyeb8Dj+iiB6x0anYd0uIY4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LtXfBCwNb9fehZVzNUrFh78/T3MWNAkZOJrefrZPMJo=; b=YwpPbEykMCRN5T0aNgk0Pe0zDmezIedru7AXl+kGnXP9nO22yCOV3ls3mM4EkSxB/B 9qPkC6QaWmDxYk0G2yXfJ0XFkSL6ucAH/OO5PSGNX+TbHlMTAOJRr3Cf1M6aHLLx1K3Y CwgtjDRzcxcrR7+ZAmQsWQNSOYsZmHvnrGV9P8BGsjUGpIW/HL7lci7w+G6qYCr49IQa RQkxp4FMu48ae40O0Nyyg1FWSbm5SRn1dEyINQG91R5x4b8GIaUSYJJ5H3Z/yA4lqK4o U3p80gjsH8cjqM2uG3/WZgLQdG16+cKeUatX2yjAkauckHOV62YQCJVnqFEdTiGT5sMy G9eA== X-Gm-Message-State: AA6/9Rk+W7A6xyBDx9uxSSdtwwo719nQmddoMhWOcUzT2eH+QUNH5BIkYUgeXo2/410p55teJeTTBABaeD/l5iL7 X-Received: by 10.107.179.70 with SMTP id c67mr72345iof.169.1476892650805; Wed, 19 Oct 2016 08:57:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.110.99 with HTTP; Wed, 19 Oct 2016 08:57:30 -0700 (PDT) In-Reply-To: References: <20160927011552.20384-1-leif.lindholm@linaro.org> From: Leif Lindholm Date: Wed, 19 Oct 2016 16:57:30 +0100 Message-ID: To: Andrew Fish , Michael D Kinney Cc: edk2-devel-01 , Ard Biesheuvel , Feng Tian , Star Zeng Subject: Re: [PATCH] MdeModulePkg: add ARM/AARCH64 requirements to .dsc X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 15:57:31 -0000 Content-Type: text/plain; charset=UTF-8 Andrew, Mike - are you OK with me committing this? On 27 September 2016 at 03:24, Ard Biesheuvel wrote: > On 26 September 2016 at 18:15, Leif Lindholm wrote: >> Some LibraryClasses entries are missing to enable standalone builds >> of MdeModulePkg components for ARM/AARCH64. Add those. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Leif Lindholm > > Reviewed-by: Ard Biesheuvel > >> --- >> >> Tying back to the conversation in >> https://lists.01.org/pipermail/edk2-devel/2016-August/000733.html >> >> If we are not going to refactor the DxeIpl code, would this be an >> acceptable fix to enable standalone HelloWorld builds on ARM/AARCH64? >> >> BaseStackCheckLib is unrelated to the DxeIpl issue, but needed in >> practice on ARM and in theory on AARCH64. >> >> MdeModulePkg/MdeModulePkg.dsc | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc >> index 05120c7..3eb55db 100644 >> --- a/MdeModulePkg/MdeModulePkg.dsc >> +++ b/MdeModulePkg/MdeModulePkg.dsc >> @@ -160,6 +160,9 @@ [LibraryClasses.common.UEFI_APPLICATION] >> DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf >> >> [LibraryClasses.ARM, LibraryClasses.AARCH64] >> + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf >> + ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf >> + >> # >> # It is not possible to prevent ARM compiler calls to generic intrinsic functions. >> # This library provides the instrinsic functions generated by a given compiler. >> @@ -167,6 +170,12 @@ [LibraryClasses.ARM, LibraryClasses.AARCH64] >> # >> NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf >> >> + # >> + # Since software stack checking may be heuristically enabled by the compiler >> + # include BaseStackCheckLib unconditionally. >> + # >> + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf >> + >> [LibraryClasses.EBC] >> LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf >> >> -- >> 2.9.3 >>