From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x22b.google.com (mail-qt0-x22b.google.com [IPv6:2607:f8b0:400d:c0d::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BFA9421EB5283 for ; Thu, 31 Aug 2017 06:48:49 -0700 (PDT) Received: by mail-qt0-x22b.google.com with SMTP id h15so3116349qta.4 for ; Thu, 31 Aug 2017 06:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0pWKA8CII3dYtmusOXcl1dW6okaIpgfYxmMUm2/9iHk=; b=VAUJo8nILBSNRZELHOVNVlO/GeFUM0XQwTn2dBxrzNixqI3T0on4ifw0T9K0B7jduM O0PldE81nharpXw52gIlzFScIjYrWgu6zzPazCppeF/xo4VQTsXfNSDt5M6uqOfucEZf kNYKds0uTijhf+PwFdM5YJtsRHBlmziHwJRqg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0pWKA8CII3dYtmusOXcl1dW6okaIpgfYxmMUm2/9iHk=; b=p8NHzhWtjBZSuZWOz+FVDK/WKB5cgWhy7D0S7F+yUF9aBAbdIER6rpRZ0Rf2kXLhAN YONwr6pQpnommmQtM1j5OLds053rwJdteGBa4DxMiYunhlRcA2dzIpbv71zU3ObLLs9W 1jhI5y8H4n8hIrNeWLxQ1p7SZjWKslGYjXcQE79xbK1CG6PRHMumkGGBNkEcugDYksAO 9GeQHxnoIL+CUICVndROhfWQYUloAauS7Dd5zNYGyw5zGf3ew34AImviynr0x88/h1xD G/PrfdC63p1m35KPh3PD+7SgJ9fZNA56q+JcZBJcOcAUeEP1pnuVP2oi3GAbU1/KrzkS y7nQ== X-Gm-Message-State: AHYfb5j5lAF3VU+GiZtcOQD9eyWgGghQ/No99Ghtlgo71rS7DdzP0Z0Z pZrcwBi7lU+1R2RefxzEi8ujOAn1JGFr X-Google-Smtp-Source: ADKCNb5KN4vBghpQnAjHcK4MniWfmndxcn8krbdv/Kvr5PgmGT2cC3u8+FHVdEBlZmRpycrIT7p0vc7cKTNyhzKCenk= X-Received: by 10.200.56.84 with SMTP id r20mr6922100qtb.224.1504187492150; Thu, 31 Aug 2017 06:51:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.34.121 with HTTP; Thu, 31 Aug 2017 06:51:31 -0700 (PDT) In-Reply-To: References: <20170825122554.17819-1-ard.biesheuvel@linaro.org> <20170829154603.fvhfwp66asipxnoe@bivouac.eciton.net> From: Leif Lindholm Date: Thu, 31 Aug 2017 14:51:31 +0100 Message-ID: To: Ard Biesheuvel Cc: Marcin Wojtas , edk2-devel-01 Subject: Re: [PATCH] Platform/Armada/Pp2Dxe: switch to ArmDmaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2017 13:48:50 -0000 Content-Type: text/plain; charset="UTF-8" On 30 August 2017 at 14:26, Ard Biesheuvel wrote: > On 29 August 2017 at 18:01, Ard Biesheuvel wrote: >> On 29 August 2017 at 16:53, Marcin Wojtas wrote: >>> 2017-08-29 17:48 GMT+02:00 Ard Biesheuvel : >>>> On 29 August 2017 at 16:47, Marcin Wojtas wrote: >>>>> 2017-08-29 17:46 GMT+02:00 Leif Lindholm : >>>>>> On Fri, Aug 25, 2017 at 01:25:54PM +0100, Ard Biesheuvel wrote: >>>>>>> Instead of hardcoding the non-cache coherent nature of this device >>>>>>> by invoking UncachedMemoryAllocationLib directly for allocating >>>>>>> shared buffers, switch to DmaLib, which encapsulates this at a >>>>>>> more abstract level. This allows the driver to be shared with >>>>>>> platforms that are cache coherent (by simply switching to another >>>>>>> DmaLib implementation), and removes the hardcoded dependency on >>>>>>> UncachedMemoryAllocationLib, which will be removed from upstream >>>>>>> EDK2. >>>>>>> >>>>>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>>>>> Signed-off-by: Ard Biesheuvel >>>>>> >>>>>> Ah, and there is the non-bogus fix :) >>>>>> Reviewed-by: Leif Lindholm >>>>> >>>>> Please let me just run this on the HW before merge - I'll do it tomorrow. >>>>> >>>> >>>> Sure. Note that you will need to sync EDK2 after I merged the DmaLib >>>> changes (which I will do today) >>> >>> Ok, please let know once it's available and also it would be great if >>> this patch could be shared via github repo. >>> >> >> The prerequisite patches for DmaLib are in EDK2 now. >> >> https://git.linaro.org/people/ard.biesheuvel/edk2-platforms.git/log/?h=mvpp2-dmalib > > Note that I just updated this branch to use NonCoherentDmaLib rather > than ArmDmaLib For clarity - my Reviewed-by: still applies. / Leif