From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5A84081DFC for ; Mon, 14 Nov 2016 09:16:29 -0800 (PST) Received: by mail-it0-x22e.google.com with SMTP id q124so131366492itd.1 for ; Mon, 14 Nov 2016 09:16:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:from:date:message-id:subject:to:cc; bh=gTzVYbaj2SKakKFEo7UcYsu+5gr3i3zxhE/x27KV9do=; b=LZY5Lx7COE8cN8HDAU2KWbp8LBSiuanT9yqcw2Gj/jo44xaY0gNOUHO/qZZnyOLzDW LxvXY0C8h4NR4k0zzgIl+FDa/74qWi4xM1eJ0HsAKVcaz2tIhg3rOI9VbKsNgoTjZnOh 2EmcNB1upeYlCmWYtcSA0L6y9N/6Scr3EXD8M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=gTzVYbaj2SKakKFEo7UcYsu+5gr3i3zxhE/x27KV9do=; b=WLLzDS361r5IZa5Yk5JdUZL1lheSHrtpNphIyt3XTul2BLFQNcp0ATl/W3pOqCl/pv +W3HIFPfoRgMF7QOCoTVuz5tr2ttuia2YtqifatKZcLQgZwLPgVty/c1NSF1VbvZA7Dm VKjTGc+59w0I2WccS4XqhLtqTaem9ftb8rvXgoh58uHX1BPmD6l3L0afjQmb9dSwkGSQ 9KKDWuxmfCukjxwKgeWSeVK3eltrq0pjXihSksesw+NMwQkYe7IF4wMbKuMbUNV8RNd4 WqAnjySuNdRaGjTdhNSc2juIfVuY+EOKAT31SOdfqEWbaeClZTT7b02RQMf3bTq23HBi x99w== X-Gm-Message-State: ABUngvf9LJxurmeUEcH342aeSUAgh67Ch5EOfVZJ5svnqvYCrRilVisM3mdHOyA38igEXXf6ciiAsl7p6M0qIDLf X-Received: by 10.36.26.23 with SMTP id 23mr4210446iti.84.1479143793425; Mon, 14 Nov 2016 09:16:33 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.73.70 with HTTP; Mon, 14 Nov 2016 09:16:32 -0800 (PST) From: Leif Lindholm Date: Mon, 14 Nov 2016 17:16:32 +0000 Message-ID: To: "edk2-devel (edk2-devel@lists.01.org)" , "Gao, Liming" , Hao Wu Cc: Feng Tian , Star Zeng , Andrew Fish , "Kinney, Michael D" Subject: LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2016 17:16:29 -0000 Content-Type: text/plain; charset=UTF-8 Hi all, Digging through the tree, I spotted we have duplicate instances of the above - one set in MdeModulePkg/Library/ and one in IntelFrameworkModulePkg. Looking though the log, I found the commit message explaining the situation: --- MdeModulePkg: Add two library instances Copy below two library instances from IntelFrameworkModulePkg to MdeModulePkg. Then, Platform dsc can refer to them from MdeModulePkg, and remove the dependency of IntelFrameworkModulePkg. The ones in IntelFrameworkModulePkg are still kept for compatibility. 1. PeiDxeDebugLibReportStatusCode 2. LzmaCustomDecompressLib --- Even in the main tree, both versions of these are used. Diffing the clones, 1) has diverged, with 8f77081 going into MdeModulePkg and d5cbc27 into IntelFrameworkModulePkg. The functionality is identical, but the code is not. Can we re-evaluate the need to keep the "compatibility" copy around, to reduce risk of further diversion? Regards, Leif