From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::243; helo=mail-lj1-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3376321189FB5 for ; Thu, 1 Nov 2018 10:56:25 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id z21-v6so18852009ljz.0 for ; Thu, 01 Nov 2018 10:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RgY4ZzYW4WhjLak7rss9UjlBxAGCb/XMT/hvitfkjMM=; b=hcyHOiILtuagHUbhMPE5/GYXwNVHFlMf526R2rseTp5yXZI30Eb6S1ZlE0Sw+eldxn EwwPBCyJgOvANdIojfAfSlBVsquQ84/klOHM3qKl7YOwq4B5bQXXOEKYibBPSVy9VNI2 LNt6Lq3mXwP403jsKd2PRSD9lD+ScN3Iwnpis= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RgY4ZzYW4WhjLak7rss9UjlBxAGCb/XMT/hvitfkjMM=; b=PMCZcOv6cKk/LEkrU4G7UoscBYQOouQhGRsxCKwOa8z8VTesrd41v/sEU63D/yxWGV Dt1jhswkEVnf53j96x5AY+qHH/t3UmyHHgwPU2cJ2evdf5uDPpEWUJiFH3HbvgduZ8sy qXqn/dutx6Bj9UKQSJWortBk5OT0BIikxZ4URcrZqSuPStlRSRnbcBehCq+eAg0q/L9r TfEYkD41rh8YWV1Sdqna/ysGIaRrVElzYKkdfI874/SRlYSax43ovu7QUnCuORCwhwSK /ZiSQh3Uw7UIrCjU9dQOy3VYq8VUtYoaNIMQH4UgAl3FWyaDvYXe92F6AZ7sgjRl872c ZnHQ== X-Gm-Message-State: AGRZ1gICDTbQvbI9Fujx0Jn0je5sMjn9fN4KZa6l79HyXDKNRt2Oufvq gDRfEMabcXzoyUv16P1ksaRN4ZAFe8SVOSfTRHu6ZQ== X-Google-Smtp-Source: AJdET5fXSqR7gw3OCoUNhH2GFE0oRwQtPmvVitTznQxI1gHVqoOPXhVVkVVcpPNirYYcgqnN384aQVFUhZ73mThWspU= X-Received: by 2002:a2e:e09:: with SMTP id 9-v6mr5369282ljo.159.1541094982391; Thu, 01 Nov 2018 10:56:22 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a19:1dc3:0:0:0:0:0 with HTTP; Thu, 1 Nov 2018 10:56:21 -0700 (PDT) In-Reply-To: References: <20181101153642.11315-1-leif.lindholm@linaro.org> <20181101153642.11315-2-leif.lindholm@linaro.org> From: Leif Lindholm Date: Thu, 1 Nov 2018 17:56:21 +0000 Message-ID: To: "Kinney, Michael D" Cc: "edk2-devel@lists.01.org" , "Carsey, Jaben" , Daryl McDaniel X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH 1/6] AppPkg: fix webserver build for !Ia32/X64 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 17:56:25 -0000 Content-Type: text/plain; charset="UTF-8" On 1 November 2018 at 17:19, Kinney, Michael D wrote: > > Leif, > > The MSR definitions are only used by Mtrr.c, and Mtrr.c is only > used for IA32 and X64 builds in the INF file. Ah, yes, that actually means the rest of the application may be completely valid on ARM. > It would be simpler to move the #include > into Mtrr.c. That would avoid the use of #if. Yeah, that sounds like the better fix. I was being lazy :) Thanks, will do that for v2. Regards, Leif > Mike > > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel- > > bounces@lists.01.org] On Behalf Of Leif Lindholm > > Sent: Thursday, November 1, 2018 8:37 AM > > To: edk2-devel@lists.01.org > > Cc: Carsey, Jaben ; Daryl > > McDaniel > > Subject: [edk2] [PATCH 1/6] AppPkg: fix webserver build > > for !Ia32/X64 > > > > The WebServer application is really quite Ia32/X64 > > specific, but fundamentally > > it builds for other architectures as long as the > > architecture-specific > > #include > > header file is filtered out. > > So add an architecture-based filter on that to enable > > AppPkg.dsc to build for > > AARCH64/ARM (both listed in SUPPORTED_ARCHITECTURES). > > > > Cc: Daryl McDaniel > > Cc: Jaben Carsey > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Leif Lindholm > > --- > > > > Note: there is definitely a case here for just > > disabling this component > > for !Ia32/X64, but the _interesting_ bits of this > > application are > > completely architecture independent, so my > > preference would be to > > do this for now, and worry about remaining issues > > (like MTRR dump) > > at some point in the future. > > > > AppPkg/Applications/Sockets/WebServer/WebServer.h | 2 > > ++ > > 1 file changed, 2 insertions(+) > > > > diff --git > > a/AppPkg/Applications/Sockets/WebServer/WebServer.h > > b/AppPkg/Applications/Sockets/WebServer/WebServer.h > > index 21b07b63df..610abdcf9e 100644 > > --- a/AppPkg/Applications/Sockets/WebServer/WebServer.h > > +++ b/AppPkg/Applications/Sockets/WebServer/WebServer.h > > @@ -20,7 +20,9 @@ > > > > #include > > > > +#if defined(__x86_64__) || defined(__i386__) > > #include > > +#endif > > #include > > #include > > #include > > -- > > 2.11.0 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel