Re: [PATCH edk2-platforms v1 14/14] Hisilicon D03/D05: Update firmware version to 18.02

[Leif Lindholm <leif.lindholm@linaro.org>]

On 24 Jan 2018 01:17, "Huangming (Mark)" <huangming23@huawei.com> wrote:



On 2018/1/23 18:18, Leif Lindholm wrote:
> On Thu, Jan 18, 2018 at 11:01:43PM +0800, Ming Huang wrote:
>> Replace the old string with short one. The old one is
>> too long that can not be show integrallty in Setup nemu.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ming Huang <huangming23@huawei.com>
>> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
>
> NAK
>
> Anything that is not an official Linaro reference platform release is
> a development build. The fallback string needs to indicate this.
> The current one does this.
> The modified version does not.
>
> /
>     Leif
>

Is the below version string ok?
"Development build 18.02 for Hisilicon D03"


Sure, that works.

/
    Leif

>> ---
>>  Platform/Hisilicon/D03/D03.dsc | 2 +-
>>  Platform/Hisilicon/D05/D05.dsc | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.
dsc
>> index 6f1164e..b6b8086 100644
>> --- a/Platform/Hisilicon/D03/D03.dsc
>> +++ b/Platform/Hisilicon/D03/D03.dsc
>> @@ -171,7 +171,7 @@
>>    !ifdef $(FIRMWARE_VER)
>>      gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(
FIRMWARE_VER)"
>>    !else
>> -    gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development
build base on Hisilicon D03 UEFI 17.10 Release"
>> +    gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"RP 18.02
for Hisilicon D03"
>>    !endif
>>
>>    gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18"
>> diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.
dsc
>> index 52ffad5..a599c08 100644
>> --- a/Platform/Hisilicon/D05/D05.dsc
>> +++ b/Platform/Hisilicon/D05/D05.dsc
>> @@ -190,7 +190,7 @@
>>    !ifdef $(FIRMWARE_VER)
>>      gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(
FIRMWARE_VER)"
>>    !else
>> -    gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development
build base on Hisilicon D05 UEFI 17.10 Release"
>> +    gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"RP 18.02
for Hisilicon D05"
>>    !endif
>>
>>    gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18"
>> --
>> 1.9.1
>>
>
> .
>

--
Best Regards,

Ming