From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4010:c07::242; helo=mail-lf0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-lf0-x242.google.com (mail-lf0-x242.google.com [IPv6:2a00:1450:4010:c07::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9E3282238B59C for ; Tue, 23 Jan 2018 23:48:58 -0800 (PST) Received: by mail-lf0-x242.google.com with SMTP id w27so2687000lfd.6 for ; Tue, 23 Jan 2018 23:54:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zzVmHCXdQsfzPgDtWUpxNg4BAiTbhx9fJL36+vXmDfk=; b=cn4Vo1qOi6dyyDoUQJsygw+b1X9z5/ISYYAu/pyEUZE7s8kFOI2yVlKEcrrotXVCjk FD00Hu+RVxEqLKnvLsR2XNkfiAYnM052AkWdf2iT+BUQagpFiecSKEHA4zQDV3TRmoqb xz01WqQvS8p6/oZlFvFk+YH2Z/77z1o8W427o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zzVmHCXdQsfzPgDtWUpxNg4BAiTbhx9fJL36+vXmDfk=; b=TdvXo16U9isvF35tAjHi6WqLT/oKj7U2NBYpqDheuQGfOoH2fP2Jv8HScffIyFI9Py SLTRqsa5d8VsUQ2Ostlmn7oVFwqgItBbiIl7iUpteF4/JX2mmC9lkapDytCK60/FGutA bKNQ4uS4NfGCm9oR0TWb6P2iHqLVHo8eXxJ0esp7p1X4CBq37zJ/2VN646avAETWZDlo jam1gYgYhPwGBSQI1tKSrKHaTYeTlPy3Kwv9akGJyYrfC6S40pnJ6Kqn5g2RkBDTtnb1 p+7qzjU0WD2Z/MpRmpp4Ytp1JyD1H8lh0RRSgW8+TMNnYg7tXWyt+o1jfqHysd/y54Ti eSUg== X-Gm-Message-State: AKwxyteSQFu8TNFHhxYqe1JGBmcFP3KuRLIBG8GVriB7t1mQHPeGb9Qs IVCdDu2zNH1TtpOlfFtfn47euy3UDbhVtQEt8Lgm3w== X-Google-Smtp-Source: AH8x227c0iuz2wCyFjBBtTN9m4XCNH0nz0rwRTWt9UziQNHK2DO2CQfTPsrz6gMDAcp+U4EGbxEc5D/O/06NoVRtrac= X-Received: by 10.46.85.66 with SMTP id j63mr3220902ljb.55.1516780463773; Tue, 23 Jan 2018 23:54:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.156.148 with HTTP; Tue, 23 Jan 2018 23:54:22 -0800 (PST) Received: by 10.25.156.148 with HTTP; Tue, 23 Jan 2018 23:54:22 -0800 (PST) In-Reply-To: <1c488414-a363-6faa-3c73-474d59c451bb@huawei.com> References: <1516287703-35516-1-git-send-email-huangming23@huawei.com> <1516287703-35516-15-git-send-email-huangming23@huawei.com> <20180123101847.p65tfoeskt7jc7q7@bivouac.eciton.net> <1c488414-a363-6faa-3c73-474d59c451bb@huawei.com> From: Leif Lindholm Date: Wed, 24 Jan 2018 07:54:22 +0000 Message-ID: To: Ming Huang Cc: Heyi Guo , Linaro UEFI , edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, zhangjinsong2@huawei.com, mengfanrong@huawei.com, waip23@126.com X-Content-Filtered-By: Mailman/MimeDel 2.1.23 Subject: Re: [PATCH edk2-platforms v1 14/14] Hisilicon D03/D05: Update firmware version to 18.02 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 07:48:59 -0000 Content-Type: text/plain; charset="UTF-8" On 24 Jan 2018 01:17, "Huangming (Mark)" wrote: On 2018/1/23 18:18, Leif Lindholm wrote: > On Thu, Jan 18, 2018 at 11:01:43PM +0800, Ming Huang wrote: >> Replace the old string with short one. The old one is >> too long that can not be show integrallty in Setup nemu. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> Signed-off-by: Heyi Guo > > NAK > > Anything that is not an official Linaro reference platform release is > a development build. The fallback string needs to indicate this. > The current one does this. > The modified version does not. > > / > Leif > Is the below version string ok? "Development build 18.02 for Hisilicon D03" Sure, that works. / Leif >> --- >> Platform/Hisilicon/D03/D03.dsc | 2 +- >> Platform/Hisilicon/D05/D05.dsc | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03. dsc >> index 6f1164e..b6b8086 100644 >> --- a/Platform/Hisilicon/D03/D03.dsc >> +++ b/Platform/Hisilicon/D03/D03.dsc >> @@ -171,7 +171,7 @@ >> !ifdef $(FIRMWARE_VER) >> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$( FIRMWARE_VER)" >> !else >> - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build base on Hisilicon D03 UEFI 17.10 Release" >> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"RP 18.02 for Hisilicon D03" >> !endif >> >> gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" >> diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05. dsc >> index 52ffad5..a599c08 100644 >> --- a/Platform/Hisilicon/D05/D05.dsc >> +++ b/Platform/Hisilicon/D05/D05.dsc >> @@ -190,7 +190,7 @@ >> !ifdef $(FIRMWARE_VER) >> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$( FIRMWARE_VER)" >> !else >> - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build base on Hisilicon D05 UEFI 17.10 Release" >> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"RP 18.02 for Hisilicon D05" >> !endif >> >> gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" >> -- >> 1.9.1 >> > > . > -- Best Regards, Ming