From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::143; helo=mail-lf1-x143.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B806B210DBE65 for ; Mon, 6 Aug 2018 10:44:19 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id y200-v6so9667600lfd.7 for ; Mon, 06 Aug 2018 10:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NgRmZxYmUtdewdtA5x0WaSIPWEQ+0rauQrrRw4KtBNk=; b=DCEhCqvkeSmKsKgomNm9DAgGPMaCQNNIoNw2iQU3IsaRzxfALJzWyB1bCuQ4sCSWdb sM6QL3khNuCERvjD+edYd0onRso9mBzTmkaBc1Kaca5iZ3rIvcQIZFCazF8rBOSpjE3h A9iVig3YLxewJrBdBwSNrwtXod/K6zcn7LzkU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NgRmZxYmUtdewdtA5x0WaSIPWEQ+0rauQrrRw4KtBNk=; b=rFuu95i8X8MufgxlUjXBP++1+ItxVOfTJILxFkRUHpl/KwewZ3oJ/tP+sp2ZDcD3K5 MGiCP/s+Z0jzN3N/FTwNPsWVPpl9eahqdN8MQ+Pj333P/sTRwkotr9tO0d+pKmQwK2dg ZFytC73/Wlv9FaUsMKoSfw04Wk2QR0qhvyEADEyIflv1lAyJF0AAAzHTuAqAzgcBLqjD ArmQMoN72Eitoe7ksi5b+piTEi+VKv4UHS4vbfbH3TUWDf2QJRt3W74JaT+wUVBDb4bF 3HndNXnoMHjo4T2MipwJEhIcJcKU901+zvVz46V16nXh77yVdoFQuuX7oPnWFLYx0Y6r w5EA== X-Gm-Message-State: AOUpUlF6bmI50jhrxZCrYn55MPPQCCsma1Dmxt2RQ2BAkpbDDuDuou7R TwgS9difOPjL+KIn46LuT763acYscemvmwlZJZGZjg== X-Google-Smtp-Source: AAOMgpfY3Jqfa+f0fl+HE+1BsZhrmEMihNItgK1NbQKtdPSspmjsdtFf528pXX/Hqt8dvhJk/i6YozOgvPqb4LL+HFY= X-Received: by 2002:a19:5309:: with SMTP id h9-v6mr12457477lfb.86.1533577457007; Mon, 06 Aug 2018 10:44:17 -0700 (PDT) MIME-Version: 1.0 References: <1533511706-9344-1-git-send-email-mw@semihalf.com> <1533511706-9344-8-git-send-email-mw@semihalf.com> In-Reply-To: From: Leif Lindholm Date: Mon, 6 Aug 2018 18:44:04 +0100 Message-ID: To: Ard Biesheuvel Cc: Marcin Wojtas , "edk2-devel (edk2-devel@lists.01.org)" , Nadav Haklai , "jsd@semihalf.com" , Grzegorz Jaszczyk X-Content-Filtered-By: Mailman/MimeDel 2.1.27 Subject: Re: [platforms: PATCH 7/9] Marvell/Armada70x0Db: Enable ACPI support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Aug 2018 17:44:20 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 6 Aug 2018, 17:09 Ard Biesheuvel, wrote= : > On 6 August 2018 at 18:08, Marcin Wojtas wrote: > > HI Ard, > > > > pon., 6 sie 2018 o 13:54 Ard Biesheuvel > napisa=C5=82(a): > >> > >> On 6 August 2018 at 01:28, Marcin Wojtas wrote: > >> > This patch introduces DSDT table and adds necessary > >> > wiring in order to enable ACPI support on Armada 7040 DB. > >> > > >> > Contributed-under: TianoCore Contribution Agreement 1.1 > >> > Signed-off-by: Marcin Wojtas > >> > --- > >> > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | > 14 ++ > >> > Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | > 3 + > >> > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | > 12 + > >> > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/AcpiTables.inf | > 61 ++++++ > >> > Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf.inc | > 5 + > >> > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl | > 229 ++++++++++++++++++++ > >> > Silicon/Marvell/Documentation/PortingGuide.txt | > 22 ++ > >> > 7 files changed, 346 insertions(+) > >> > create mode 100644 > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/AcpiTables.inf > >> > create mode 100644 > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl > >> > > >> > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > >> > index f1ccda0..d4c67a2 100644 > >> > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > >> > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > >> > @@ -593,6 +593,20 @@ > >> > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > >> > !endif #$(INCLUDE_TFTP_COMMAND) > >> > > >> > +[Components.AARCH64] > >> > + # > >> > + # Generic ACPI modules > >> > + # > >> > + MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf > >> > + MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf { > >> > + > >> > + > PlatformHasAcpiLib|EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpi= Lib.inf > >> > + > >> > + > >> > + # support ACPI v5.0 or later > >> > + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x= 20 > >> > + } > >> > + > >> > > [BuildOptions.common.EDKII.DXE_CORE,BuildOptions.common.EDKII.DXE_DRIVER,= BuildOptions.common.EDKII.UEFI_DRIVER,BuildOptions.common.EDKII.UEFI_APPLIC= ATION] > >> > GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 > >> > > >> > diff --git a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc > b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc > >> > index d3dffb0..f6faff1 100644 > >> > --- a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc > >> > +++ b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc > >> > @@ -51,6 +51,9 @@ > >> > [Components.common] > >> > Silicon/Marvell/Armada7k8k/DeviceTree/Armada70x0Db.inf > >> > > >> > +[Components.AARCH64] > >> > + Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/AcpiTables.inf > >> > + > >> > > #########################################################################= ####### > >> > # > >> > # Pcd Section - list of all EDK II PCD Entries defined by this > Platform > >> > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf > b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf > >> > index 909ad3e..c064a43 100644 > >> > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf > >> > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf > >> > @@ -215,6 +215,12 @@ FvNameGuid =3D > 5eda4200-2c5f-43cb-9da3-0baf74b1b30c > >> > # DTB > >> > INF EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.inf > >> > > >> > +!if $(ARCH) =3D=3D AARCH64 > >> > + # ACPI support > >> > + INF MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.i= nf > >> > + INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf > >> > +!endif > >> > + > >> > !include $(BOARD_DXE_FV_COMPONENTS) > >> > > >> > # PEI phase firmware volume > >> > @@ -408,3 +414,9 @@ READ_LOCK_STATUS =3D TRUE > >> > FILE FREEFORM =3D $(NAMED_GUID) { > >> > RAW BIN |.dtb > >> > } > >> > + > >> > +[Rule.Common.USER_DEFINED.ACPITABLE] > >> > + FILE FREEFORM =3D $(NAMED_GUID) { > >> > + RAW ASL |.aml > >> > + RAW ACPI |.acpi > >> > + } > >> > diff --git > a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/AcpiTables.inf > b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/AcpiTables.inf > >> > new file mode 100644 > >> > index 0000000..8732e10 > >> > --- /dev/null > >> > +++ > b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/AcpiTables.inf > >> > @@ -0,0 +1,61 @@ > >> > +## @file > >> > +# Component description file for PlatformAcpiTables module. > >> > +# > >> > +# ACPI table data and ASL sources required to boot the platform. > >> > +# > >> > +# Copyright (c) 2018, Linaro, Ltd. All rights reserved.
> >> > +# Copyright (C) 2018, Marvell International Ltd. and its > affiliates.
> >> > +# > >> > +# This program and the accompanying materials > >> > +# are licensed and made available under the terms and conditions o= f > the BSD License > >> > +# which accompanies this distribution. The full text of the > license may be found at > >> > +# http://opensource.org/licenses/bsd-license.php > >> > +# > >> > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > >> > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRES= S > OR IMPLIED. > >> > +# > >> > +## > >> > + > >> > +[Defines] > >> > + INF_VERSION =3D 0x0001001A > >> > + BASE_NAME =3D PlatformAcpiTables > >> > + FILE_GUID =3D > 7E374E25-8E01-4FEE-87F2-390C23C606CD > >> > + MODULE_TYPE =3D USER_DEFINED > >> > + VERSION_STRING =3D 1.0 > >> > + > >> > +[Sources] > >> > + Dsdt.asl > >> > + ../Fadt.aslc > >> > + ../Gtdt.aslc > >> > + ../Madt.aslc > >> > + ../Pptt.aslc > >> > + ../Spcr.aslc > >> > + > >> > >> Could we reshuffle these files so we nog longer rely relative includes= ? > >> Possibly using a Common subdirectory? > > > > Would below directory tree be acceptable? > > > > Silicon/Marvell/Armada7k8k/AcpiTables/ > > =E2=94=9C=E2=94=80=E2=94=80 AcpiHeader.h > > =E2=94=9C=E2=94=80=E2=94=80 Armada70x0Db > > =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 Dsdt.asl > > =E2=94=9C=E2=94=80=E2=94=80 Armada70x0Db.inf > > =E2=94=9C=E2=94=80=E2=94=80 Armada80x0Db > > =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 Dsdt.asl > > =E2=94=9C=E2=94=80=E2=94=80 Armada80x0Db.inf > > =E2=94=9C=E2=94=80=E2=94=80 Armada80x0McBin > > =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 Dsdt.asl > > =E2=94=9C=E2=94=80=E2=94=80 Armada80x0McBin.inf > > =E2=94=9C=E2=94=80=E2=94=80 Fadt.aslc > > =E2=94=9C=E2=94=80=E2=94=80 Gtdt.aslc > > =E2=94=9C=E2=94=80=E2=94=80 IcuInterrupts.h > > =E2=94=9C=E2=94=80=E2=94=80 Madt.aslc > > =E2=94=9C=E2=94=80=E2=94=80 Pptt.aslc > > =E2=94=94=E2=94=80=E2=94=80 Spcr.aslc > > > > This way we will have following in the .inf > > > > Armada80x0McBin/Dsdt.asl > > Fadt.aslc > > Gtdt.aslc > > Madt.aslc > > Pptt.aslc > > Spcr.aslc > > > > Works for me. Leif? > Sure. / Leif >