From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400c:c08::241; helo=mail-ua0-x241.google.com; envelope-from=sumit.garg@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-ua0-x241.google.com (mail-ua0-x241.google.com [IPv6:2607:f8b0:400c:c08::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 198A22098EAB2 for ; Fri, 20 Jul 2018 03:27:58 -0700 (PDT) Received: by mail-ua0-x241.google.com with SMTP id k8-v6so7151274uaq.12 for ; Fri, 20 Jul 2018 03:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aLMI6+n4Ta3L9ccKuYXLP/+6exBu0ds/Fz2h63CmHr8=; b=GAklMeIBHq0CX4Op7ieEi6ZOwWmRh9WhNrqSI6kKfr9B2AShBgkO+mEv/XywdY61IR u7uzoCRb+4D+GBUNgCbn9m/ROo+LXpVXsE+ZETtJCzI3UXYrIrl0T41oelFyyqj1aeru 6cY+VJr1Q2SkMZBK6Nq5UYIzvN2A/Z4OBZJDY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aLMI6+n4Ta3L9ccKuYXLP/+6exBu0ds/Fz2h63CmHr8=; b=LmQUtOxqx2It50CYgmLLvsiU9iVDWjCHd6eQaxbTpL3sB/y/mxlFLjSlzQN2zL2atJ VP8ufXHHkbn3wb4azE6TOvA2A+wPXqEvdoor1pRzHs8dv/LP+/qzqBTpZB9B+M/9gOiZ 9un30YY+GFugSgSrROlReU+SiJivMQiIGavJnftRCKBs75hrmk+HeNjbA78fd8yeIAgu ell3uVW4Kn9X+c3r/NvmY+2RgRBKvvhb7ofWCfz5XKVh1o/5tsEEs4/RY43oBLBKSTyq JkQpzzti0Jqz63JQyhgg8pmsxGsZwIvncy2ntTUJE71eVUDdhNmIOSRxNF6/foxY+YDx vWcg== X-Gm-Message-State: AOUpUlEqibHnr3W3DF7J88UzorTsXiad6fWmnaCgZWbLaz/FxGrN9C+c XZvVttBKEXgw4IOkMku2H7wfdE3rQe5G5WIoS8Zkrw== X-Google-Smtp-Source: AAOMgpcdiJQMCOixoMETGRFJv+qGaigtHO5o4sFXXPG44NCbb87D3RARntZqg674Behm13VPk0IKgjLAly0UGNN4iGE= X-Received: by 2002:ab0:3308:: with SMTP id r8-v6mr827004uao.121.1532082477678; Fri, 20 Jul 2018 03:27:57 -0700 (PDT) MIME-Version: 1.0 References: <1532070779-7544-1-git-send-email-sumit.garg@linaro.org> In-Reply-To: From: Sumit Garg Date: Fri, 20 Jul 2018 15:57:45 +0530 Message-ID: To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, Patch Tracking , Leif Lindholm Subject: Re: [PATCH edk2-platforms 1/1] Silicon/SynQuacer/DeviceTree: add OP-TEE driver node X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jul 2018 10:27:59 -0000 Content-Type: text/plain; charset="UTF-8" On Fri, 20 Jul 2018 at 15:49, Ard Biesheuvel wrote: > > On 20 July 2018 at 19:13, Sumit Garg wrote: > > On Fri, 20 Jul 2018 at 15:31, Ard Biesheuvel wrote: > >> > >> On 20 July 2018 at 16:12, Sumit Garg wrote: > >> > Cc: Ard Biesheuvel > >> > Cc: Leif Lindholm > >> > Contributed-under: TianoCore Contribution Agreement 1.1 > >> > Signed-off-by: Sumit Garg > >> > --- > >> > Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi | 7 +++++++ > >> > 1 file changed, 7 insertions(+) > >> > > >> > diff --git a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi > >> > index 37d642e4b237..d109a5742793 100644 > >> > --- a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi > >> > +++ b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi > >> > @@ -574,6 +574,13 @@ > >> > #address-cells = <1>; > >> > #size-cells = <0>; > >> > }; > >> > + > >> > + firmware { > >> > + optee { > >> > + compatible = "linaro,optee-tz"; > >> > + method = "smc"; > >> > + }; > >> > + }; > >> > }; > >> > > >> > #include "SynQuacerCaches.dtsi" > >> > >> Hello Sumit, > >> > >> Is it safe to provide this node when optee is not running? > > > > Yes it is safe. If optee is not running then Linux TEE driver exits > > gracefully with below info: > > > > [ 1.976021] optee: probing for conduit method from DT. > > [ 1.976033] optee: api uid mismatch > > > > Ok, so it is safe but it still prints a nasty error. > > So let's fix this properly: you can check the existing code to find > out how the mmc DT node gets enabled in PlatformDxe. Sure will have a look at mmc DT addition code and come up with a more clean solution. -Sumit