From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::e44; helo=mail-vs1-xe44.google.com; envelope-from=sumit.garg@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5EED72117FD45 for ; Fri, 26 Oct 2018 05:11:18 -0700 (PDT) Received: by mail-vs1-xe44.google.com with SMTP id a202so550897vsd.5 for ; Fri, 26 Oct 2018 05:11:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4OQ2QFlAX3qMkbmD7+9+MKJcpsVCWQzSP39WObTO/wY=; b=JXmEGdkCMyk3CEGjEelnEB6RQ1vuii/5ZCFgk9AmRqb+dDBh8ygo7JS+vvIuC+lWHU MrhJxYjyWkhuiyNawN4wPhIUj7mOyjEXsG42qXTxW03lrR6OH10qG7KLBMkEIskqYO/Y xM6rNB2nds0YSV5ufefxRYHR8mV01FDfEcLZk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4OQ2QFlAX3qMkbmD7+9+MKJcpsVCWQzSP39WObTO/wY=; b=na5fE2qePWKbHw/Fjt5uCmemD3O/k5cnU8Na0gs2uQCa5gx4B7fAIt7QXtsXRiKC4S 5a8wHrpLtyuGF7Zj50WYb3TnEC4z8JuJj27YtlkJMk0E2FUSZKA2VVg/VWWJ/tgBJGCV cJS14Rg4i2AFjt1INZC2s3mo5oacmA6bV35sRb/Jmq7jAocPx4hEMC9FI3C49jdFfYus q/eunDSy2lOJloP6EEAoD5eT4N/yc404H88B3sczRP+H7c1/lLy/ehHlDiorISdDF5FB o1I/rslLEbhiSDJsSR6ojREfGNnuJKtGo4iq1MwXB2rJQ9LOmzX5/fBF2fYM7wB2WfTB nMLQ== X-Gm-Message-State: AGRZ1gKn2VMfoQSCxj8alhtOr8EPgOdmy1gfupLSp75+PnjhPtgSjmR9 8lFUpX5QJyIym6BRUTscKavl7MUNlvlGtzWVhSaQyg== X-Google-Smtp-Source: AJdET5dQ7rQRngcSm8VxfSG/sJsa+2uHniKOOiJDP3GjHNoCKJt4jIW43kLeEl+5twV0ofN5Q9fGhK963mVRy5EhP1o= X-Received: by 2002:a67:f096:: with SMTP id i22mr1427963vsl.174.1540555876669; Fri, 26 Oct 2018 05:11:16 -0700 (PDT) MIME-Version: 1.0 References: <1540189776-22806-1-git-send-email-sumit.garg@linaro.org> In-Reply-To: <1540189776-22806-1-git-send-email-sumit.garg@linaro.org> From: Sumit Garg Date: Fri, 26 Oct 2018 17:41:05 +0530 Message-ID: To: Leif Lindholm Cc: edk2-devel@lists.01.org, Ard Biesheuvel , Michael D Kinney , tee-dev@lists.linaro.org, Daniel Thompson , Joakim Bech , Matteo.Carlini@arm.com, Achin.Gupta@arm.com, udit.kumar@nxp.com Subject: Re: [PATCH v5 0/1] Add ArmPkg/Optee library APIs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 12:11:18 -0000 Content-Type: text/plain; charset="UTF-8" Hi Leif, Please let me know if you have any further review comment. -Sumit On Mon, 22 Oct 2018 at 12:00, Sumit Garg wrote: > > Changes in v5: > Define RFC4122_UUID struct using network byte order instead of 16 byte > octects for passing Trusted Application UUID. > > Changes in v4: > Replaced abbreviations with full name which are not defined in [1]. Also > used EFI_GUID for Trusted Application UUIDs. > > [1] https://edk2-docs.gitbooks.io/edk-ii-c-coding-standards-specification/content/v/release/2.20/4_naming_conventions/#table-2-efi-supported-abbreviations > > Changes in v3: > Removed GlobalPlatform TEE return codes (IndustryStandard/GlobalPlatform.h) > that were rejected by EDK2 maintainers. Rather used custom ones for this > OP-TEE driver. > > Changes in v2: > 1. Separate patch for MdePkg/Include/IndustryStandard/GlobalPlatform.h. > 2. Correct comments style for struct members. > 3. Update commit message. > > Sumit Garg (1): > ArmPkg/OpteeLib: Add APIs to communicate with OP-TEE > > ArmPkg/Library/OpteeLib/OpteeLib.inf | 2 + > ArmPkg/Include/Library/OpteeLib.h | 88 +++++ > ArmPkg/Library/OpteeLib/OpteeSmc.h | 53 +++ > ArmPkg/Library/OpteeLib/Optee.c | 392 ++++++++++++++++++++ > 4 files changed, 535 insertions(+) > create mode 100644 ArmPkg/Library/OpteeLib/OpteeSmc.h > > -- > 2.7.4 >