From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400c:c05::242; helo=mail-vk0-x242.google.com; envelope-from=sumit.garg@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-vk0-x242.google.com (mail-vk0-x242.google.com [IPv6:2607:f8b0:400c:c05::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7F41C2098EAB2 for ; Fri, 20 Jul 2018 03:13:27 -0700 (PDT) Received: by mail-vk0-x242.google.com with SMTP id s17-v6so5816249vke.10 for ; Fri, 20 Jul 2018 03:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=otRy0P8dgH8Ds4dm/asKhlRmLwmxK+MMBmIqJTHOswY=; b=fa5nQkuNYy3kTPLsfZ3hW48Sd5rwLQfDwtFUTHdNmDbxHqlK9DLGNa9XXq5oTVkqWc G5Bd4BQG+FhATkySQAmF+Q5l18VbU+iTAIQ4ub3/bQ6CWElrSerKTTRfSnKAxfMLcB1p UYNF/gDJT3QAuYCC5m+Hs5+IX6/sEMHBhWeoU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=otRy0P8dgH8Ds4dm/asKhlRmLwmxK+MMBmIqJTHOswY=; b=iEReYZ0LDQSESROXNGRq0VzMiyFOH9cPmemXNzLGuJK8Y0MVeewZHi32xJKqX5shUw JYpdb3QpcWq/Nm1LrbRhmrPGewdlXiWKN6sEBw5LV3narVYLbNWJl3wq7JEbb/lWuNz5 a3qgLepYF58DY0qtZ1JCsg4WaqD+M/otzqnYgcOYM1Gb895yw8LTpp+TDuG7pkQ2HpX0 dpxCP7vKe69MosPkY0S70zvAy/08Aj1mIoNzGfk8ePyM6RsJ+ahgO51CU5qWvF71+bQb X8QPHi+dqdOZVKegCywssJuV4XNCEQGSQIG/DW4LzH1pTJYuwcLEomO3dYcnT4NT3ewN VRvg== X-Gm-Message-State: AOUpUlERWs92lq8VFf0nZN5SK/9r3/2WSu0x5J3vK9D9oyJZsUgN/FJj LFzNNVJI+ZzuJ8aiGSmwjoP+rloUWIR+8ApB/vxbtQ== X-Google-Smtp-Source: AAOMgpcHujscH5zK6ylLPZPBT45uWUtVTQjaCxUKoJLoum2caAM88n9j09hc0a4npo6UlmqKuRKjDQnJku6Rbmv+j2I= X-Received: by 2002:a1f:ee85:: with SMTP id m127-v6mr802517vkh.46.1532081605962; Fri, 20 Jul 2018 03:13:25 -0700 (PDT) MIME-Version: 1.0 References: <1532070779-7544-1-git-send-email-sumit.garg@linaro.org> In-Reply-To: From: Sumit Garg Date: Fri, 20 Jul 2018 15:43:14 +0530 Message-ID: To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, Patch Tracking , Leif Lindholm Subject: Re: [PATCH edk2-platforms 1/1] Silicon/SynQuacer/DeviceTree: add OP-TEE driver node X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jul 2018 10:13:27 -0000 Content-Type: text/plain; charset="UTF-8" On Fri, 20 Jul 2018 at 15:31, Ard Biesheuvel wrote: > > On 20 July 2018 at 16:12, Sumit Garg wrote: > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Sumit Garg > > --- > > Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi > > index 37d642e4b237..d109a5742793 100644 > > --- a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi > > +++ b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi > > @@ -574,6 +574,13 @@ > > #address-cells = <1>; > > #size-cells = <0>; > > }; > > + > > + firmware { > > + optee { > > + compatible = "linaro,optee-tz"; > > + method = "smc"; > > + }; > > + }; > > }; > > > > #include "SynQuacerCaches.dtsi" > > Hello Sumit, > > Is it safe to provide this node when optee is not running? Yes it is safe. If optee is not running then Linux TEE driver exits gracefully with below info: [ 1.976021] optee: probing for conduit method from DT. [ 1.976033] optee: api uid mismatch -Sumit > > If not, this should be made dependent on that, so we should probably > add status = 'disabled', and remove it in PlatformDxe if the DIP > switch is not set, and/or if there are other ways we might know that > optee is not running.