From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::e44; helo=mail-vs1-xe44.google.com; envelope-from=sumit.garg@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 46A802117D285 for ; Thu, 1 Nov 2018 03:55:39 -0700 (PDT) Received: by mail-vs1-xe44.google.com with SMTP id v205so9290886vsc.3 for ; Thu, 01 Nov 2018 03:55:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GCJXnTVUKweFE74XHdksURShFWW/VjdlkDZZn38CYNQ=; b=ULsm/Bmv0NUdpg+oW6Fl5aEd3ZU9znnYQZibN9BmOJrmRqepPE2XmEd+bmWhTGtaOv /dcjLHsTnAJImXs9gxxONCOgoVVgCe8XKDU9gSXh+Bg31+LY5rwQKO/nw3AU0ySwD+d9 +kwmlMZtTjKMjyIvB3WYcJ/jwc1jpkZAyDwhM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GCJXnTVUKweFE74XHdksURShFWW/VjdlkDZZn38CYNQ=; b=Cy398zTmqTw9WfW+MTWDvaqoPnwOM2/2Bs/xgHZZuIe5NDU21UOsstQVvl4hDORfei X/vUTVYNO8wEKUiQFtuV/KOrvn32Op0uIOlcI1xt7b4mnQCB1cYPtyGxH2KNL0ghsKxk ANjvstvE+h4+QAMm/t3YbESsvRx0kgEjVjGYk2vEBn/nU6Cvob950zE7+i5e9S3lqY5x pEuILO2ljR3W+uM0c3Q/YlljsvmP2Jr8cWZTgQ1XJ4pBtl0XTRFLfvUdoMSFKDptZ1wj gUPS4d8B9UfCMHVHuQv+xiBo6QKDSh6N1XuZO0GtUH3Emnu9BncszVdriy4f+62iusLv E0zQ== X-Gm-Message-State: AGRZ1gIM+7iRsKmj1o64tSUjph6HibdDdoWKieotysVOEupQ1oBuJD5o dXMD7ps1rqcKJsxcWQYUOOcf7hrvOBe2+yZRynG3+w== X-Google-Smtp-Source: AJdET5cTn6VONc6b6jvcteI8Ep6CXaz/uYWXuvVE3dxWA4xvWUwdbD0QM27KAUr1fXYq+GEn4NHz8w1XDpXXTAntGe4= X-Received: by 2002:a67:d684:: with SMTP id o4mr3027311vsj.174.1541069737761; Thu, 01 Nov 2018 03:55:37 -0700 (PDT) MIME-Version: 1.0 References: <20180921082542.35768-1-christopher.co@microsoft.com> <20180921082542.35768-2-christopher.co@microsoft.com> <20181031204305.mkivnbhnna4niy2g@bivouac.eciton.net> In-Reply-To: <20181031204305.mkivnbhnna4niy2g@bivouac.eciton.net> From: Sumit Garg Date: Thu, 1 Nov 2018 16:25:26 +0530 Message-ID: To: Christopher.Co@microsoft.com, Leif Lindholm Cc: edk2-devel@lists.01.org, Ard Biesheuvel , Michael D Kinney Subject: Re: [PATCH edk2-platforms 01/27] Platform/Microsoft: Add OpteeClientPkg dec X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 10:55:39 -0000 Content-Type: text/plain; charset="UTF-8" Hi Christopher, Optee Client library has recently been merged to edk2 source code. It tries to provide a generic interface [1] to OP-TEE based trusted applications (pseudo/early). AFAIK, you don't need any platform specific hook in client interface to work with upstream OP-TEE. So instead you should use Optee library. [1] https://github.com/tianocore/edk2/blob/master/ArmPkg/Include/Library/OpteeLib.h Regards, Sumit On Thu, 1 Nov 2018 at 02:13, Leif Lindholm wrote: > > +Sumit (just to loop you two together). Is there anything Microsoft > platform specific about what will go in here? > > / > Leif > > On Fri, Sep 21, 2018 at 08:25:53AM +0000, Chris Co wrote: > > On Windows IoT Core devices with ARM TrustZone capabilities, > > EDK2 runs in normal world and we use OP-TEE to execute > > secure world operations. The overall package will contain > > client-side support to invoke EDK2 services implemented as > > OP-TEE trusted applications that run in secure world. > > > > This commit adds the initial dec file to add some PCD settings > > needed by other packages. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Christopher Co > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > --- > > Platform/Microsoft/OpteeClientPkg/OpteeClientPkg.dec | 49 ++++++++++++++++++++ > > 1 file changed, 49 insertions(+) > > > > diff --git a/Platform/Microsoft/OpteeClientPkg/OpteeClientPkg.dec b/Platform/Microsoft/OpteeClientPkg/OpteeClientPkg.dec > > new file mode 100644 > > index 000000000000..4752eab39ce3 > > --- /dev/null > > +++ b/Platform/Microsoft/OpteeClientPkg/OpteeClientPkg.dec > > @@ -0,0 +1,49 @@ > > +## @file > > +# > > +# OP-TEE client package > > +# > > +# OP-TEE client package contains the client-side interface to invoke OP-TEE TAs. > > +# Certain EDKII services are implemented in Trusted Applications running in > > +# the secure world OP-TEE OS. > > +# > > +# Copyright (c) 2018 Microsoft Corporation. All rights reserved. > > +# > > +# This program and the accompanying materials > > +# are licensed and made available under the terms and conditions of the BSD License > > +# which accompanies this distribution. The full text of the license may be found at > > +# http://opensource.org/licenses/bsd-license.php > > +# > > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > > +# > > +## > > + > > +[Defines] > > + DEC_SPECIFICATION = 0x0001001A > > + PACKAGE_NAME = OpteeClientPkg > > + PACKAGE_GUID = 77416fcb-10ec-4693-bdc0-1bdd74ec9595 > > + PACKAGE_VERSION = 0.01 > > + > > +[Includes] > > + > > +[LibraryClasses] > > + > > +[Guids] > > + gOpteeClientPkgTokenSpaceGuid = { 0x04ad34ca, 0xdd25, 0x4156, { 0x90, 0xf5, 0x16, 0xf9, 0x40, 0xd0, 0x49, 0xe3 }} > > + > > +[PcdsFixedAtBuild] > > + gOpteeClientPkgTokenSpaceGuid.PcdTpm2AcpiBufferBase|0|UINT64|0x00000005 > > + gOpteeClientPkgTokenSpaceGuid.PcdTpm2AcpiBufferSize|0|UINT32|0x00000006 > > + > > + ## The base address of the Trust Zone OpTEE OS private memory region > > + # This memory is manager privately by the OpTEE OS. > > + gOpteeClientPkgTokenSpaceGuid.PcdTrustZonePrivateMemoryBase|0xDEAD1|UINT64|0x00000001 > > + > > + ## The size of the Trust Zone OpTEE OS private memory region > > + gOpteeClientPkgTokenSpaceGuid.PcdTrustZonePrivateMemorySize|55|UINT64|0x00000002 > > + > > + ## The base address of the Trust Zone OpTEE OS shared memory region > > + gOpteeClientPkgTokenSpaceGuid.PcdTrustZoneSharedMemoryBase|0xDEAD2|UINT64|0x00000003 > > + > > + ## The size of the Trust Zone OpTEE OS shared memory region > > + gOpteeClientPkgTokenSpaceGuid.PcdTrustZoneSharedMemorySize|0xAA|UINT64|0x00000004 > > -- > > 2.16.2.gvfs.1.33.gf5370f1 > >