public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	 Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [edk2-devel] [PATCH 0/2] ArmPkg/ArmVirtPkg: handle FEAT_VHE NS-EL2 virtual timer
Date: Tue, 19 Sep 2023 14:18:01 +0100	[thread overview]
Message-ID: <CAFEAcA_LtY=RhQk_j40SsV1G=jWyaiqPuSZdVVp1DfO9CwOPFQ@mail.gmail.com> (raw)
In-Reply-To: <20230919112015.229479-1-quic_llindhol@quicinc.com>

On Tue, 19 Sept 2023 at 12:20, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
>
> An ASSERT trips when we try to add the NS-EL2 virtual timer to qemu
> mach-virt.
>
> Add a new Pcd for the new private peripheral interrupt id,
> PcdArmArchTimerHypVirtIntrNum.
>
> Update ArmVirtTimerFdtClientLib to:
> - Only assert on receiving less information that required through DT.
> - Set PcdArmArchTimerHypVirtIntrNum if provided through DT.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>

Thanks for writing and sending out these patches. I've tested, and
they are sufficient to get EDK2 to not assert and successfully
boot a guest OS when using my QEMU RFC patchset that reports the
new interrupt ID via the dtb:
https://patchew.org/QEMU/20230919101240.2569334-1-peter.maydell@linaro.org/

-- PMM


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108835): https://edk2.groups.io/g/devel/message/108835
Mute This Topic: https://groups.io/mt/101453745/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2023-09-19 14:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19 11:20 [edk2-devel] [PATCH 0/2] ArmPkg/ArmVirtPkg: handle FEAT_VHE NS-EL2 virtual timer Leif Lindholm
2023-09-19 11:20 ` [edk2-devel] [PATCH 1/2] ArmPkg: add EL2 virtual timer interrupt Pcd Leif Lindholm
2023-09-19 11:20 ` [edk2-devel] [PATCH 2/2] ArmVirtPkg: handle virtual EL2 timer in DT Leif Lindholm
2023-09-19 13:18 ` Peter Maydell [this message]
2023-09-19 15:19   ` [edk2-devel] [PATCH 0/2] ArmPkg/ArmVirtPkg: handle FEAT_VHE NS-EL2 virtual timer Leif Lindholm
2023-09-19 15:31     ` Peter Maydell
2023-09-19 20:43   ` Leif Lindholm
2023-09-19 14:13 ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA_LtY=RhQk_j40SsV1G=jWyaiqPuSZdVVp1DfO9CwOPFQ@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox