From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2BD7C94193D for ; Tue, 19 Sep 2023 14:00:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=PVDW8g4O/2LrsWq5sg9AGo+K/KUrr84z2DhU0ub6tjs=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1695132057; v=1; b=I6PhHkVgY1Fh0B15cPWIqzSBnqbPq8B4iknEl6nsvpZLt3y26w0FK6yvds/4NtkUaFjz89kr lMsy8cVZjUqda+yAT30TsQaL4Cquv9PYAr4eylKsiT9qs0gxiAa+fuS36neqlfv2s3dLkzzjeQ/ YLPEI0BkdVg2BePSV3K+U9WM= X-Received: by 127.0.0.2 with SMTP id sFFnYY7687511xvr8MXNasH5; Tue, 19 Sep 2023 07:00:57 -0700 X-Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by mx.groups.io with SMTP id smtpd.web11.8323.1695129501605655598 for ; Tue, 19 Sep 2023 06:18:21 -0700 X-Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-52bd9ddb741so7147508a12.0 for ; Tue, 19 Sep 2023 06:18:21 -0700 (PDT) X-Gm-Message-State: JOicXx0CFxmV5YLPOihR2XBPx7686176AA= X-Google-Smtp-Source: AGHT+IHNU+eLPSstDjMEZfT6iNVX/ZLYmh+om+UJXE2pDgbU53++40vnd6TAozhbGMBnyss0SRfEs6EKNccobFPE4rk= X-Received: by 2002:a05:6402:12d1:b0:527:ab3f:4350 with SMTP id k17-20020a05640212d100b00527ab3f4350mr10054629edx.38.1695129499971; Tue, 19 Sep 2023 06:18:19 -0700 (PDT) MIME-Version: 1.0 References: <20230919112015.229479-1-quic_llindhol@quicinc.com> In-Reply-To: <20230919112015.229479-1-quic_llindhol@quicinc.com> From: Peter Maydell Date: Tue, 19 Sep 2023 14:18:01 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH 0/2] ArmPkg/ArmVirtPkg: handle FEAT_VHE NS-EL2 virtual timer To: Leif Lindholm Cc: devel@edk2.groups.io, Ard Biesheuvel , Sami Mujawar Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,peter.maydell@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=I6PhHkVg; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 19 Sept 2023 at 12:20, Leif Lindholm wrote: > > An ASSERT trips when we try to add the NS-EL2 virtual timer to qemu > mach-virt. > > Add a new Pcd for the new private peripheral interrupt id, > PcdArmArchTimerHypVirtIntrNum. > > Update ArmVirtTimerFdtClientLib to: > - Only assert on receiving less information that required through DT. > - Set PcdArmArchTimerHypVirtIntrNum if provided through DT. > > Reported-by: Peter Maydell > Cc: Ard Biesheuvel > Cc: Sami Mujawar Thanks for writing and sending out these patches. I've tested, and they are sufficient to get EDK2 to not assert and successfully boot a guest OS when using my QEMU RFC patchset that reports the new interrupt ID via the dtb: https://patchew.org/QEMU/20230919101240.2569334-1-peter.maydell@linaro.org/ -- PMM -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108835): https://edk2.groups.io/g/devel/message/108835 Mute This Topic: https://groups.io/mt/101453745/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-