From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0F396AC1779 for ; Tue, 19 Sep 2023 19:56:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=le+tcnwaZzqkDSjtBbrkps5Pusg8mWc9TpDLot/gCNM=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1695153397; v=1; b=Yfn5ZBLlkP0Zig1JnVls293pPg3vgp5vfehzFjRGfiUFemQdWuoF2OSU3d29wWONftpwM1w6 bm0/rEjghMI1ByOhPiX5z1aYIebM5T7aviUfWEl7YZpEIGEvJXxb7RuA9zB2ysx1YmboTZ7KU3E u0DKJn+kMXMNEaEWPC9AGsww= X-Received: by 127.0.0.2 with SMTP id 7yDZYY7687511xHhkgr7W3Zw; Tue, 19 Sep 2023 12:56:37 -0700 X-Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by mx.groups.io with SMTP id smtpd.web11.12683.1695137521617006461 for ; Tue, 19 Sep 2023 08:32:01 -0700 X-Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-530e721f077so3573468a12.2 for ; Tue, 19 Sep 2023 08:32:01 -0700 (PDT) X-Gm-Message-State: ky1NFPjyiQDZckGb6Qolms8Fx7686176AA= X-Google-Smtp-Source: AGHT+IH7LxOmlbcAUh3Mx2XEsR+S8pTSAo6P3E8+o0VYp/pmfOsRgBvWvzyIH5qNMJTpVPuzaok2M6Cl+1+zzjbHBdQ= X-Received: by 2002:a05:6402:516:b0:523:3e90:68b0 with SMTP id m22-20020a056402051600b005233e9068b0mr10970705edv.21.1695137519916; Tue, 19 Sep 2023 08:31:59 -0700 (PDT) MIME-Version: 1.0 References: <20230919112015.229479-1-quic_llindhol@quicinc.com> In-Reply-To: From: Peter Maydell Date: Tue, 19 Sep 2023 16:31:40 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH 0/2] ArmPkg/ArmVirtPkg: handle FEAT_VHE NS-EL2 virtual timer To: Leif Lindholm Cc: devel@edk2.groups.io, Ard Biesheuvel , Sami Mujawar Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,peter.maydell@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Yfn5ZBLl; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 19 Sept 2023 at 16:19, Leif Lindholm wrote: > > On 2023-09-19 14:18, Peter Maydell wrote: > > On Tue, 19 Sept 2023 at 12:20, Leif Lindholm wrote: > >> > >> An ASSERT trips when we try to add the NS-EL2 virtual timer to qemu > >> mach-virt. > >> > >> Add a new Pcd for the new private peripheral interrupt id, > >> PcdArmArchTimerHypVirtIntrNum. > >> > >> Update ArmVirtTimerFdtClientLib to: > >> - Only assert on receiving less information that required through DT. > >> - Set PcdArmArchTimerHypVirtIntrNum if provided through DT. > >> > >> Reported-by: Peter Maydell > >> Cc: Ard Biesheuvel > >> Cc: Sami Mujawar > > > > Thanks for writing and sending out these patches. I've tested, and > > they are sufficient to get EDK2 to not assert and successfully > > boot a guest OS when using my QEMU RFC patchset that reports the > > new interrupt ID via the dtb: > > https://patchew.org/QEMU/20230919101240.2569334-1-peter.maydell@linaro.org/ > > Are you happy for me to interpret that as Tested-by for 2/2? (1/2 just > being internal plumbing not related to preventing the ASSERT) Yes, if you do Tested-by tags in this project feel free to add that from me. -- PMM -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108855): https://edk2.groups.io/g/devel/message/108855 Mute This Topic: https://groups.io/mt/101453745/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-