On Thu, Oct 5, 2023 at 12:45 PM Pedro Falcato wrote: > On Wed, Oct 4, 2023 at 9:01 PM MrChromebox > wrote: > > > > Add the ClockRate field to the UNIVERSAL_PAYLOAD_SERIAL_PORT_INFO > > struct, so that the field can be used by UefiPayloadPkg to properly > > set up the serial port on boards using a non-standard clock rate. > > > > Signed-off-by: Matt DeVillier > > Change-Id: I9bcaf03ab63f6a45d2cf25a580f7a2eba388cbbd > > Series-generic-feedback: Remove Change-Id lines and CC the proper > maintainers for each patch > ack > > --- > > MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h > b/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h > > index 3c4459e2c0..e3c9f93654 100644 > > --- a/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h > > +++ b/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h > > @@ -19,6 +19,7 @@ typedef struct { > > BOOLEAN UseMmio; > > UINT8 RegisterStride; > > UINT32 BaudRate; > > + UINT32 ClockRate; > > I don't think you can do this? UNIVERSAL_PAYLOAD_SERIAL_PORT_INFO is > part of a spec ( > https://universalscalablefirmware.github.io/documentation/2_universal_payload.html > ) > and it doesn't even seem to be versioned, so you'd just break ABI. Am > I missing something? > The USF spec says that it is currently at version 0.7 and under development / not final. I don't see why adding a field to a hob is problematic provided it's properly documented. The alternatives are some really hacky workarounds to pass the necessary data, or the serial port not working. > > -- > Pedro > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109461): https://edk2.groups.io/g/devel/message/109461 Mute This Topic: https://groups.io/mt/101763374/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-