From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 92E7ED8094F for ; Mon, 9 Oct 2023 15:54:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wxbJ55ZAzSJH5KOekBJfB+wlZACRH94ZsTsmL2DsDaU=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1696866858; v=1; b=CSJpfcV9CSa+4+zoo733iyJoYq93vTI0o0u82pDRmybC/cni4hl5QrqP0XTNLuK/vD1GuHHv pA2ATHooJjZCb+edUjsxk8wmuT5hoxA+PFHPAaj4HjEQ/ai4DLeXc0JxBMGNhE20Kc1ewypEqnt 60+jYaAabX/Pat/yOz9QzuWY= X-Received: by 127.0.0.2 with SMTP id dTeRYY7687511x8SMsb6yold; Mon, 09 Oct 2023 08:54:18 -0700 X-Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by mx.groups.io with SMTP id smtpd.web11.66066.1696866857140697496 for ; Mon, 09 Oct 2023 08:54:17 -0700 X-Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-533f193fc8dso8224984a12.2 for ; Mon, 09 Oct 2023 08:54:16 -0700 (PDT) X-Gm-Message-State: 9aZQPlBNlEhJUljfHov4sqEAx7686176AA= X-Google-Smtp-Source: AGHT+IFUxLK2/D2g9O2mlMBStfaK//2T0179NC+92E0/2rH7rBBFKSrak7nntq9a3vtU0iGTGU1hw/SB9S9B/x8+amw= X-Received: by 2002:a17:906:76cf:b0:9b2:a7e5:c47 with SMTP id q15-20020a17090676cf00b009b2a7e50c47mr14821798ejn.9.1696866854883; Mon, 09 Oct 2023 08:54:14 -0700 (PDT) MIME-Version: 1.0 References: <9143994e6a5f37650930abfc4141c6061e5bef98.1696448945.git.matt.devillier@gmail.com> In-Reply-To: From: "MrChromebox" Date: Mon, 9 Oct 2023 08:54:03 -0700 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add ClockRate field to SerialPortInfo To: devel@edk2.groups.io Cc: Pedro Falcato , Zhiguang Liu , "Ni, Ray" , gua.guo@intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,matt.devillier@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: multipart/alternative; boundary="0000000000001de4ce06074a9a7e" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CSJpfcV9; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) --0000000000001de4ce06074a9a7e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Oct 5, 2023 at 12:45=E2=80=AFPM Pedro Falcato wrote: > On Wed, Oct 4, 2023 at 9:01=E2=80=AFPM MrChromebox > wrote: > > > > Add the ClockRate field to the UNIVERSAL_PAYLOAD_SERIAL_PORT_INFO > > struct, so that the field can be used by UefiPayloadPkg to properly > > set up the serial port on boards using a non-standard clock rate. > > > > Signed-off-by: Matt DeVillier > > Change-Id: I9bcaf03ab63f6a45d2cf25a580f7a2eba388cbbd > > Series-generic-feedback: Remove Change-Id lines and CC the proper > maintainers for each patch > ack > > --- > > MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h > b/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h > > index 3c4459e2c0..e3c9f93654 100644 > > --- a/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h > > +++ b/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h > > @@ -19,6 +19,7 @@ typedef struct { > > BOOLEAN UseMmio; > > UINT8 RegisterStride; > > UINT32 BaudRate; > > + UINT32 ClockRate; > > I don't think you can do this? UNIVERSAL_PAYLOAD_SERIAL_PORT_INFO is > part of a spec ( > https://universalscalablefirmware.github.io/documentation/2_universal_pay= load.html > ) > and it doesn't even seem to be versioned, so you'd just break ABI. Am > I missing something? > The USF spec says that it is currently at version 0.7 and under development / not final. I don't see why adding a field to a hob is problematic provided it's properly documented. The alternatives are some really hacky workarounds to pass the necessary data, or the serial port not working. > > -- > Pedro > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109461): https://edk2.groups.io/g/devel/message/109461 Mute This Topic: https://groups.io/mt/101763374/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --0000000000001de4ce06074a9a7e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Oct 5, 2023 at 12:45=E2=80=AFPM P= edro Falcato <pedro.falcato@g= mail.com> wrote:
On Wed, Oct 4, 2023 at 9:01=E2=80=AFPM M= rChromebox <matt.devillier@gmail.com> wrote:
>
> Add the ClockRate field to the UNIVERSAL_PAYLOAD_SERIAL_PORT_INFO
> struct, so that the field can be used by UefiPayloadPkg to properly > set up the serial port on boards using a non-standard clock rate.
>
> Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
> Change-Id: I9bcaf03ab63f6a45d2cf25a580f7a2eba388cbbd

Series-generic-feedback: Remove Change-Id lines and CC the proper
maintainers for each patch

ack=C2=A0
=C2=A0
> ---
>=C2=A0 MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h | 1 +
>=C2=A0 1 file changed, 1 insertion(+)
>
> diff --git a/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h b/= MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h
> index 3c4459e2c0..e3c9f93654 100644
> --- a/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h
> +++ b/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h
> @@ -19,6 +19,7 @@ typedef struct {
>=C2=A0 =C2=A0 BOOLEAN=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0UseMmio;
>=C2=A0 =C2=A0 UINT8=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0RegisterStride;<= br> >=C2=A0 =C2=A0 UINT32=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 BaudRate;
> +=C2=A0 UINT32=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ClockRate;

I don't think you can do this? UNIVERSAL_PAYLOAD_SERIAL_PORT_INFO is part of a spec (ht= tps://universalscalablefirmware.github.io/documentation/2_universal_payload= .html)
and it doesn't even seem to be versioned, so you'd just break ABI. = Am
I missing something?

The USF spec says = that it is currently at version 0.7 and under development / not final. I do= n't see why adding a field to a hob is problematic provided it's pr= operly documented. The alternatives are some really hacky workarounds to pa= ss the necessary data, or the serial port not working.
=C2=A0

--
Pedro
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#109461) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--0000000000001de4ce06074a9a7e--