public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Moritz Fischer" <moritzf@google.com>
To: devel@edk2.groups.io, guo.dong@intel.com
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Replace MEMROY_ENTRY by MEMORY_ENTRY
Date: Mon, 18 Oct 2021 17:38:35 -0700	[thread overview]
Message-ID: <CAFyOScpB_u5zjYopxy5zzgxdXHFY3sjAjJpTJ1cQoi5_+6zQMA@mail.gmail.com> (raw)
In-Reply-To: <BYAPR11MB3622870EA95FC5A97D7DF2379E589@BYAPR11MB3622.namprd11.prod.outlook.com>

On Wed, May 5, 2021 at 8:55 PM Guo Dong <guo.dong@intel.com> wrote:
>
>
> Reviewed-by: Guo Dong <guo.dong@intel.com>

How does this get picked up?

>
> > -----Original Message-----
> > From: Moritz Fischer <moritzf@google.com>
> > Sent: Wednesday, May 5, 2021 8:44 PM
> > To: devel@edk2.groups.io
> > Cc: Moritz Fischer <moritzf@google.com>; Ma, Maurice
> > <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>; You,
> > Benjamin <benjamin.you@intel.com>
> > Subject: [PATCH] UefiPayloadPkg: Replace MEMROY_ENTRY by
> > MEMORY_ENTRY
> >
> > Fixes simple typo, no behavioral change.
> >
> > Cc: Maurice Ma <maurice.ma@intel.com>
> > Cc: Guo Dong <guo.dong@intel.com>
> > Cc: Benjamin You <benjamin.you@intel.com>
> > Signed-off-by: Moritz Fischer <moritzf@google.com>
> > ---
> >  UefiPayloadPkg/Include/Guid/MemoryMapInfoGuid.h    | 6 +++---
> >  UefiPayloadPkg/Include/Library/BlParseLib.h        | 2 +-
> >  UefiPayloadPkg/Library/CbParseLib/CbParseLib.c     | 2 +-
> >  UefiPayloadPkg/Library/SblParseLib/SblParseLib.c   | 4 ++--
> >  UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 2 +-
> >  5 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/UefiPayloadPkg/Include/Guid/MemoryMapInfoGuid.h
> > b/UefiPayloadPkg/Include/Guid/MemoryMapInfoGuid.h
> > index 99187e8037cd..47922b18512a 100644
> > --- a/UefiPayloadPkg/Include/Guid/MemoryMapInfoGuid.h
> > +++ b/UefiPayloadPkg/Include/Guid/MemoryMapInfoGuid.h
> > @@ -23,14 +23,14 @@ typedef struct {
> >    UINT8  Type;
> >    UINT8  Flag;
> >    UINT8  Reserved[6];
> > -} MEMROY_MAP_ENTRY;
> > +} MEMORY_MAP_ENTRY;
> >
> >  typedef struct {
> >    UINT8  Revision;
> >    UINT8  Reserved0[3];
> >    UINT32 Count;
> > -  MEMROY_MAP_ENTRY  Entry[0];
> > -} MEMROY_MAP_INFO;
> > +  MEMORY_MAP_ENTRY  Entry[0];
> > +} MEMORY_MAP_INFO;
> >  #pragma pack()
> >
> >  #endif
> > diff --git a/UefiPayloadPkg/Include/Library/BlParseLib.h
> > b/UefiPayloadPkg/Include/Library/BlParseLib.h
> > index 20a526d15c63..fe6d9fffd408 100644
> > --- a/UefiPayloadPkg/Include/Library/BlParseLib.h
> > +++ b/UefiPayloadPkg/Include/Library/BlParseLib.h
> > @@ -20,7 +20,7 @@
> >  #define SET_BOOTLOADER_PARAMETER(Value)
> > GET_BOOTLOADER_PARAMETER()=Value
> >
> >  typedef RETURN_STATUS \
> > -        (*BL_MEM_INFO_CALLBACK) (MEMROY_MAP_ENTRY
> > *MemoryMapEntry, VOID *Param);
> > +        (*BL_MEM_INFO_CALLBACK) (MEMORY_MAP_ENTRY
> > *MemoryMapEntry, VOID *Param);
> >
> >  /**
> >    This function retrieves the parameter base address from boot loader.
> > diff --git a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
> > b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
> > index 4e23cff50e77..a3d0d9f6e3f7 100644
> > --- a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
> > +++ b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
> > @@ -381,7 +381,7 @@ ParseMemoryInfo (
> >    struct cb_memory         *rec;
> >    struct cb_memory_range   *Range;
> >    UINTN                    Index;
> > -  MEMROY_MAP_ENTRY         MemoryMap;
> > +  MEMORY_MAP_ENTRY         MemoryMap;
> >
> >    //
> >    // Get the coreboot memory table
> > diff --git a/UefiPayloadPkg/Library/SblParseLib/SblParseLib.c
> > b/UefiPayloadPkg/Library/SblParseLib/SblParseLib.c
> > index 7214fd87d20c..89bd2d7abdea 100644
> > --- a/UefiPayloadPkg/Library/SblParseLib/SblParseLib.c
> > +++ b/UefiPayloadPkg/Library/SblParseLib/SblParseLib.c
> > @@ -93,10 +93,10 @@ ParseMemoryInfo (
> >    IN  VOID                       *Params
> >    )
> >  {
> > -  MEMROY_MAP_INFO               *MemoryMapInfo;
> > +  MEMORY_MAP_INFO               *MemoryMapInfo;
> >    UINTN                          Idx;
> >
> > -  MemoryMapInfo = (MEMROY_MAP_INFO *) GetGuidHobDataFromSbl
> > (&gLoaderMemoryMapInfoGuid);
> > +  MemoryMapInfo = (MEMORY_MAP_INFO *) GetGuidHobDataFromSbl
> > (&gLoaderMemoryMapInfoGuid);
> >    if (MemoryMapInfo == NULL) {
> >      ASSERT (FALSE);
> >      return RETURN_NOT_FOUND;
> > diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
> > b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
> > index 805f5448d9a1..00f46da5efc5 100644
> > --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
> > +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
> > @@ -19,7 +19,7 @@
> >  **/
> >  EFI_STATUS
> >  MemInfoCallback (
> > -  IN MEMROY_MAP_ENTRY          *MemoryMapEntry,
> > +  IN MEMORY_MAP_ENTRY          *MemoryMapEntry,
> >    IN VOID                      *Params
> >    )
> >  {
> > --
> > 2.31.1.527.g47e6f16901-goog
>
>
>
> 
>
>

Thanks,
Moritz

  reply	other threads:[~2021-10-19  0:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06  3:44 [PATCH] UefiPayloadPkg: Replace MEMROY_ENTRY by MEMORY_ENTRY moritzf
2021-05-06  3:55 ` Guo Dong
2021-10-19  0:38   ` Moritz Fischer [this message]
2021-10-19  4:04     ` [edk2-devel] " Guo Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFyOScpB_u5zjYopxy5zzgxdXHFY3sjAjJpTJ1cQoi5_+6zQMA@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox