From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by mx.groups.io with SMTP id smtpd.web10.38349.1673150890111009193 for ; Sat, 07 Jan 2023 20:08:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@google.com header.s=20210112 header.b=Wf+ZyVOM; spf=pass (domain: google.com, ip: 209.85.160.176, mailfrom: moritzf@google.com) Received: by mail-qt1-f176.google.com with SMTP id g7so5506932qts.1 for ; Sat, 07 Jan 2023 20:08:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ddSPDjfvZdP72jJFgCa6Xa8qxA/0OvsSTMmsxwCDLk8=; b=Wf+ZyVOMCWFFysbqLconQKX2eP61X7dO47MKfAk3CsLR3ykuZaxYZ6YTTALe7/vzOW 2LXJ4YZgo2MQZBXtS7p4W+AKp4wrLv+RyMxN7IXydSgCvf1WaBnzaH7n/4SQj9kYOF53 FthDTnyFZS2FR17BGf5cHX+/2f6PoypSOyYpl8GpFpkjbXI7IOU9Kk3l/mw0DzaVczIQ F2on2j/DKhN3l4yFYGacO0R6HGQ5YWmSQPrSUhgcwlu/jOC2U0T6Ou8hYokmYNGhqGG8 fOVYV1mDVpcLne2XG7+poSdJSI7O78kXvR9DV3YCxp+rBrdyKGtBwf5zJbzr2IsMZ4pt jBEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ddSPDjfvZdP72jJFgCa6Xa8qxA/0OvsSTMmsxwCDLk8=; b=tLLAC/QaqCXt7AoSqH0xCs5q+JeLPl9PuwrqVeZ+JVPa6rbAuntrpaM6GXXxgU8gHL TMDYXMBiQPcXMpUlbRy9hmbJEWpmWUIGLE4nelSLyaBoyTrMauE+CjEQcc8TzgYtFTd6 ztgNYp6oG8kXynkO1QAF6ELh8wpAz6H9vKk8U2TEda1nMbwo7k8cfYg0gPRdmfWGbawk qNOaMqrsii5viEhLnejloNOQueNW2jhTZAAgPqcmaOEGIynHeKyfS3cbGYKWtHU2cseP Dfe7lMVAcZp4X3kNd2EoM4aYmVBTa/ztE8b8bsIPyh3B1cGVfTViT2q6ZwlXMrR8pFOX rCuQ== X-Gm-Message-State: AFqh2kqWIIoVg35UyWn4rmuzqE0Xg3qRKHCwcRyae3LbQstoODioYYNU 6FMXgPeZDZExVjtxdU937D+zbSblZKxYqOwvkuaCfg== X-Google-Smtp-Source: AMrXdXv6EdOBDzIQEygTLB/hK2bdgwAhCjM9GdPS9lGT8zCZqGPiKXlVRZugEqv6Qv68wpcswGPUWMmEs9c6PVshVzs= X-Received: by 2002:a05:622a:4:b0:3ac:5748:54a9 with SMTP id x4-20020a05622a000400b003ac574854a9mr179667qtw.373.1673150889039; Sat, 07 Jan 2023 20:08:09 -0800 (PST) MIME-Version: 1.0 References: <20230105230725.2401243-1-moritzf@google.com> In-Reply-To: From: "Moritz Fischer" Date: Sat, 7 Jan 2023 20:07:57 -0800 Message-ID: Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string To: Sami Mujawar Cc: Ard Biesheuvel , devel@edk2.groups.io, "nd@arm.com" Content-Type: text/plain; charset="UTF-8" Sami, On Fri, Jan 6, 2023 at 1:55 AM Sami Mujawar wrote: > > Hi Ard, Mortiz, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 06/01/2023 09:15 am, Ard Biesheuvel wrote: > > (cc Sami) > > > > On Fri, 6 Jan 2023 at 10:14, Ard Biesheuvel wrote: > >> On Fri, 6 Jan 2023 at 00:07, Moritz Fischer via groups.io > >> wrote: > >>> Linux' cpu DT bindings call out arm,armv8 while the code previously > >>> used arm,arm-v8. > >>> > >>> Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser") > >>> Signed-off-by: Moritz Fischer > >>> --- > >>> DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c > >>> index 2c72bd0c58..dc6e7a4d15 100644 > >>> --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c > >>> +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c > >>> @@ -22,7 +22,7 @@ > >>> */ > >>> STATIC CONST COMPATIBILITY_STR CpuCompatibleStr[] = { > >>> { "arm,arm-v7" }, > >>> - { "arm,arm-v8" }, > >>> + { "arm,armv8" }, > >> Thanks for the patch > >> > >> Should we keep both instead of removing the old one? I think adding arm,armv8 is better. I don't know why I didn't think about this from the beginning. I can resend a v2. Can't hurt to support both? > > [SAMI] I think we would need to keep both as the CPU nodes generated by > Kvmtool have compatible string as "arm,arm-v8", see > https://github.com/kvmtool/kvmtool/blob/master/arm/aarch64/arm-cpu.c#L31. > > Mortiz: Is it possible to share some information about your use case, > please? I have to deal with a DT binary that uses the other one :-) > > [/SAMI] > > >> > >>> { "arm,cortex-a15" }, > >>> { "arm,cortex-a7" }, > >>> { "arm,cortex-a57" } > >>> -- > >>> 2.39.0.314.g84b9a713c41-goog > >>> > >>> > >>> > >>> > >>> > >>> Cheers, Moritz