From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-x235.google.com (mail-vk0-x235.google.com [IPv6:2607:f8b0:400c:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 83EE521DFA8FE for ; Wed, 29 Mar 2017 16:22:38 -0700 (PDT) Received: by mail-vk0-x235.google.com with SMTP id d188so35908452vka.0 for ; Wed, 29 Mar 2017 16:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philjordan-eu.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=D30zI6ZWCloR69OgBaw2myRfrRyL0iUKt1mfmCcXGuA=; b=xUrKowhhDbVkJhYGj0rGD1ooK9gj5YLrwOTe1HnG8bwo8SEQayuDAZsOEfe1WlK2OO zqcjscsl/TeWnFapHc4MCvMEf1dqLjI2oEOeNaOyIQcJuWpGQueujNPmtZGz8BMH3079 qmMn5iuOWS96G8fqVQ+Ikyog3gI0W3hRavzRMtCUo9b4Ymuu7EpVfFxm8+Ru7KFNylsd 8rYK0HoD5PC/faW/6dbfnNIwgO+tQIgzY3eqA5YjWlA8v4z0vqY8bxYL/lDii728nDi7 mmS5IBoXd0vbeMLuunu1pHYOZG7sXTwSDuAHDf2p2JTpsdNViSFTWFvCe9RJ/cH3sZC2 IzhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=D30zI6ZWCloR69OgBaw2myRfrRyL0iUKt1mfmCcXGuA=; b=I8Uyl9uSQAzArVe4Ysdbm6SkvUqrHKt16Jybg/5y5r2XueIK5u2QgJ8SxVZPzBZT4k rzba3u1WmKjeEB9/duRabYf0lFfYANOcvhj6joeao1wGkTT9ouJI4sMmFaVXMcFCXk/H m1gyyKmkVeWzV5yYXh13HDvdDvLb1PzXNkSG7JpS8oFiTuG6kH9mj4LFkpBzs1/5AZeZ U854dMcSR76I1ZDZjpjdo0pCDjAZo0M/rViE5st7nw5ZzSWyo1YRZHIwUds1IYKtRUd/ 6Nx2G/Srbsqmf+2gX8flFPw3Ze7dg4rRqf7m4N7sNJwuuCL50Rwjl/nNsrlkb905elpn QWoQ== X-Gm-Message-State: AFeK/H0az2s5P55WF6PCGIXh/ySWEpI8IZ8yLb2hH4KW7Pp2Q//ouH3aDP5ruUEGkekeOuvGFYpt1xy0tkbF6A== X-Received: by 10.31.234.3 with SMTP id i3mr1707146vkh.36.1490829757168; Wed, 29 Mar 2017 16:22:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.58.83 with HTTP; Wed, 29 Mar 2017 16:22:16 -0700 (PDT) In-Reply-To: <1488856465-8965-1-git-send-email-gsomlo@gmail.com> References: <1488856465-8965-1-git-send-email-gsomlo@gmail.com> From: Phil Dennis-Jordan Date: Thu, 30 Mar 2017 12:22:16 +1300 Message-ID: To: "Gabriel L. Somlo" Cc: edk2-devel@ml01.01.org, Jordan Justen , Laszlo Ersek , agraf@suse.de Subject: Re: [RFC PATCH 0/6] OVMF: HFS+ (and Mac OS X boot) X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 23:22:38 -0000 Content-Type: text/plain; charset=UTF-8 Hi Gabriel, First off, thanks for going to the effort of building an HFS+ driver! Due to travel, I've only just got around to checking these out, sorry. Before I can try to help out with cleaning the patches up to the extent they can be upstreamed, I still need to get them working. boot.efi seems to load, and it finds the kernel, so the HFS+ driver is definitely working, but it fails during early boot with "Error loading drivers." This is with existing VM disk images that work with an old variant of Reza's patchset, so it's possible that the prelinked kernel image assumes something about the EFI implementation that's not true for this patchset. I'll try reinstalling the VM from scratch with the instructions from your website [1] before I try to dig deeper. It could also be something to do with the hardlink issue I mention later on, or maybe the lack of support for fragmented files. A few general comments so far on the HFS patches below: On Tue, Mar 7, 2017 at 4:14 PM, Gabriel L. Somlo wrote: > > - patch 3/6: A BSD-licensed implementation of an FSW HFS+ driver. > Based on Apple's HFS+ specification (TN1150), this is > a minimalistic, bare-bones set of FSW methods capable > of locating and loading files from an HFS+ volume. > Lots of functionality (e.g. stat, readdir, hard/sym > links, or accessing files with more than 8 fragments) > is unimplemented at this time. I only implemented the > methods necessary to support loading Apple's boot.efi > and kernel. The OS X installer disk images produced by Apple's own "createinstallmedia" tool creates hardlinks to the bootloader and kernel image, so supporting hardlinks might be a useful feature we can add, as it would simplify the installer image creation process somewhat. But I guess the higher priority is getting rid of the FSW wrapper. > If not, it might be worth factoring out the common bits and roll the > the whole thing up into a standalone HFS+ driver, which would be a > significantly different direction to go. Based on Laszlo's comments, that seems to be the preferred approach. (Not entirely unexpectedly.) I'm unfamiliar with the FSW, so I'll try to find some time to look over that and work out if I can make a sufficient time investment to help out with distilling this down. Do you think it'd be easier to start from zero, or to rip out FSW bits one by one and hard-code them into the HFS+ driver, having the whole thing working throughout? Phil