From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4864:20::e35; helo=mail-vs1-xe35.google.com; envelope-from=lists@philjordan.eu; receiver=edk2-devel@lists.01.org Received: from mail-vs1-xe35.google.com (mail-vs1-xe35.google.com [IPv6:2607:f8b0:4864:20::e35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 055FF21959CB2 for ; Fri, 9 Nov 2018 11:09:04 -0800 (PST) Received: by mail-vs1-xe35.google.com with SMTP id v205so1662981vsc.3 for ; Fri, 09 Nov 2018 11:09:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philjordan-eu.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VauWkY2qKiAaZdzsJWY2TaslcbovSjiw4YF9CxFniCc=; b=R60insZ3YLwcyUjg2cp8iG3LilfeMy7CReyUNIh3y9LuC1LL365Zgh0zeQ40LiNWUq wV88Xw+icL+mlqHpPZkrknMT7u4UurfEJ16pDbILVSl9om2IVdXPyOUuukxshYFex60C k19iTvLArPiF2RAcGIJc5hqeT87NEA3iiHp1ZqdeGd/olL3BfQ0dXOn/73kS1T3S5U4t o3Qy7KrI5dKgm/sQmmmM8Bc3A/qtycYaw2/DD4LOve7ubhPflCCdFngRwGITfjSyNg10 O7CkrLhBocNrYdzIxSaUjZukWdJ1KUXupbLp2bV9qfyXRDUprs1R6tZOPJ9zKEymERZU cnJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VauWkY2qKiAaZdzsJWY2TaslcbovSjiw4YF9CxFniCc=; b=lfCmjGU5m/bobrSnzH/+Z5jKmCkoP+sHztVhJ/iFcSnYQ7WJM/QUdF017dXw+jPnrK IOP6sGeyUBke/ih6Qj6HndzeUm+k1WTewufWG5Al69wqu0hHaSUMgPW4Lf07z6x0i9Ui b/yMmYMXqOelAMUyIOyzJmJFB3AkfLn0HLif4cEBkyB2xzZwFblvmoRkf1hzTRPNzTeU 6Q0MRj1Jw7Krb5InMzGUbAJEmll3b7FfYEt5bshKmZCHtSItkRrf6HZKAIKuB1ssGXRt gokPfwVre5bdcfDj1K65GINji8r9k74vM1a2NKMboVmoZSQbT2AkWQnkVK7qjgkDUXsb 6EZA== X-Gm-Message-State: AGRZ1gJOPG1EpRmO7vGsT0qQQr0YmTfEf0WcUAqn1MHhw3fMt3atEeTA eeshRXFukXlCvlzVbWCSA6YeEaUjqznfKehYDGmtQw== X-Google-Smtp-Source: AJdET5dz7Df5PQ59icY9Hcj7X2Ov+r0lHNVwq5qIOkYIQOkJIIXmBLe2XK3txUrxA7fEKZF7TpQlbmZ4bLUIrJz6nVw= X-Received: by 2002:a67:2ed2:: with SMTP id u201mr4234970vsu.100.1541790542724; Fri, 09 Nov 2018 11:09:02 -0800 (PST) MIME-Version: 1.0 References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3659AB@SHSMSX104.ccr.corp.intel.com> <20181107153829.juygpydwln2s5jkj@bivouac.eciton.net> <01176b5b-8826-2c82-beef-45250fd88bef@redhat.com> <8ff81475-1712-86b0-a96e-0f281bc4a734@redhat.com> In-Reply-To: <8ff81475-1712-86b0-a96e-0f281bc4a734@redhat.com> From: Phil Dennis-Jordan Date: Fri, 9 Nov 2018 20:08:51 +0100 Message-ID: To: Laszlo Ersek Cc: leif.lindholm@linaro.org, Phil Dennis-Jordan , edk2-devel-01 , liming.gao@intel.com, brian.richardson@intel.com, stephano.cetola@intel.com, michael.d.kinney@intel.com Subject: Re: [urgent] Soft Feature Freeze has started since Nov.1 for dk2-stable201811 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 19:09:05 -0000 Content-Type: text/plain; charset="UTF-8" Hi Laszlo, On Fri, Nov 9, 2018 at 5:47 PM Laszlo Ersek wrote: > > + Yuchenlin, + Gerd, + both Phils > > On 11/07/18 20:13, Laszlo Ersek wrote: > > >>> For example, I reviewed and pushed 4 patches yesterday (on 2018-Nov-06): > >>> > >>> 1 e038bde2679b Revert "OvmfPkg/QemuVideoDxe: list "UnalignedIoInternal.h" in the INF file" > >>> 2 98856a724c2a Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support" > >>> 3 438ada5aa5a1 Revert "OvmfPkg/QemuVideoDxe: Helper functions for unaligned port I/O." > >>> 4 328409ce8de7 Revert "OvmfPkg: VMWare SVGA display device register definitions" > >>> > >>> which are the first four patches (out of five) from the following > >>> series: > >>> > >>> [edk2] [PATCH v2 0/5] OvmfPkg: simply use the Bochs interface for vmsvga > >>> > >>> These reverts are arguably not bugfixes; they are preparation for > >>> re-implementing a feature from scratch (the last patch in that series). > >>> Thus, had I known we were already in the Soft Feature Freeze, I wouldn't > >>> have pushed them, because the review was not complete before the soft > >>> freeze start. > >>> > >>> But I had just returned from a week (or more) of PTO, there was no > >>> announcement on the list yet, and I didn't remember the wiki page. > >>> > >>> (In the technical sense, the reverts are not disruptive, luckily; they > >>> remove code that is dead anyway.) > > I've given this more thought. > > The reverts indeed remove dead code, but the code in question is dead > *only* on QEMU v2.10+. On QEMU v2.9 and earlier, the code is not dead. > > (See the original discussion in the thread "[edk2] [PATCH] OvmfPkg: > initialize bochs when initializing vmsvga".) > > This means that, with only the first four patches applied from the > series (= the reverts), and with the fifth patch (= the clean > re-implementation of the feature) postponed, people running > edk2-stable201811 on *old* -- v2.9 or older -- QEMU, with VMW SVGA, will > suffer a regression. > > So that leaves me with a question. Should I revert the first four > patches now, for edk2-stable201811? (I.e., revert the reverts --> > re-instate the incorrect VMW SVGA driver impl, that happens to work on > v2.9 and earlier.) > > ... Note that upstream QEMU no longer supports (= maintains stable > branches) for v2.9 and earlier releases. The QEMU homepage > currently advertizes: > - 3.1.0-rc0 > - 3.0.0 > - 2.12.1 > - 2.11.2 > > Personally I'm leaning towards keeping the reverts for > edk2-stable201811. (v2.9 is really old, and the VMW SVGA device model is > virtually unused.) For my professional integrity though, I must ask this > question publicly. I suspect the number of users relying on this feature is small, and I have my doubts that this group are running an unpatched snapshot of the master branch, let alone a stable OVMF release. But I don't have data for this, only anecdotal evidence. I personally won't be losing much sleep over it assuming we fix it for ~all versions of Qemu soon after. Phil