From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-x243.google.com (mail-ua0-x243.google.com [IPv6:2607:f8b0:400c:c08::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7228421A04820 for ; Tue, 11 Apr 2017 19:48:08 -0700 (PDT) Received: by mail-ua0-x243.google.com with SMTP id g30so782610uab.2 for ; Tue, 11 Apr 2017 19:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philjordan-eu.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9DQQjtUDnjZWbYqNLdhQsgeelski2S/NqwTyk17sH80=; b=Z2nKjWyOkcBi3dDb0gs6Ph8QSPVYXwlCj07xwwbvEdJCfJXucytmhj8IPhjYRElEyi yN3Dy9ykUKhbE0HmOzZtHPk7nyAMKeuw8tbhM5r6gT2oXYTArlasON0ovIr+Mu7B1sMs dmePCAxtgjRZ4DVd/dxlSKLVIQWjo5Z0yFESLGXcoApRYIGkBKz3o/G+nbbLxMxLOlc3 CkMnxAMnqZGXF6hkJOyemwQ5UFeeCOIbhVGO25QwpydTkoR3NtmMHIJ40Bi7mdXvGUAa gFNzGTx+zl/qOj9RUncdAOcQxkrmkRIk/SAxvB6CSqb8Ped7UWQUkuCYHTxHbGN48PjG CmMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9DQQjtUDnjZWbYqNLdhQsgeelski2S/NqwTyk17sH80=; b=i9DWTJN+YkZ6zE1J0H0BAUsgq/YXefY4So0zeR7+i4/jWEyD5SoyYbEp73IRNCCDYw HAAAkOiYBW6UF/vnSz5QHuPf83bBypgjQ4IeloRPPo2GZNAm5NB+tHRyq8oW2G0MNvSm kbOeOHrUVPh96llAB1NMuCz3/hRYIB5vhgQh1Gss67GKyx3FCc16CGiCybML29M4YUiY JmtiJcxpJ+pIb3vnSyxQZc39Vrk441j4nYaf5WB7MB7cFM9Z5MP2nBXv3mPrU1ZyP6T/ Kr7mFrg9h/WC6HBjcsx1lNIYC1NGwiXEJ/I3dTx5uTOTprulfLjEFz1nivOAi5IuzrQ2 uF3w== X-Gm-Message-State: AN3rC/52IHVIFleJygKBcOqft45B1KGxm1egX6F+Nxes+h6zt3b9dgFk0Lyoytnd0QLce//VrzelF8oC0x18sA== X-Received: by 10.176.83.97 with SMTP id y30mr406575uay.168.1491965287384; Tue, 11 Apr 2017 19:48:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.13.83 with HTTP; Tue, 11 Apr 2017 19:47:47 -0700 (PDT) In-Reply-To: <7eca0d29-c1a7-a8f0-4611-6e052ecc947d@redhat.com> References: <1491546358-58572-1-git-send-email-lists@philjordan.eu> <1491546358-58572-4-git-send-email-lists@philjordan.eu> <7eca0d29-c1a7-a8f0-4611-6e052ecc947d@redhat.com> From: Phil Dennis-Jordan Date: Wed, 12 Apr 2017 14:47:47 +1200 Message-ID: To: Laszlo Ersek Cc: Jordan Justen , edk2-devel-01 , Phil Dennis-Jordan Subject: Re: [PATCH v5 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA device support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Apr 2017 02:48:08 -0000 Content-Type: text/plain; charset=UTF-8 On Fri, Apr 7, 2017 at 10:46 PM, Laszlo Ersek wrote: > On 04/07/17 08:25, Phil Dennis-Jordan wrote: >> From: Phil Dennis-Jordan >> >> In addition to the QXL, Cirrus, etc. VGA adapters, Qemu also implements >> a basic version of VMWare's SVGA display device. Drivers for this >> device exist for some guest OSes which do not support Qemu's other >> display adapters, so supporting it in OVMF is useful in conjunction >> with those OSes. >> >> This change adds support for the SVGA device's framebuffer to >> QemuVideoDxe's graphics output protocol implementation, based on >> VMWare's documentation. The most basic initialisation, framebuffer >> layout query, and mode setting operations are implemented. >> >> The device relies on port-based 32-bit I/O, unfortunately on misaligned >> addresses. This limits the driver's support to the x86 family of >> platforms. >> >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Phil Dennis-Jordan >> --- >> >> Notes: > >> v5: >> - Removed duplicate hw register read in QemuVideoVmwareSvgaModeSetup. [Laszlo] >> - Fixed memory leak of VMWare SVGA specific modelist. [Laszlo] > > Phil, I considered these changes minor enough for you to carry forward > Jordan's and my R-b from version 4. I did think a separate v5 was going > to be best, but I figured a quick inter-diff before committing v5 would > be sufficient from my side or Jordan's (with the carried forward R-b's). Sorry about that - I wasn't sure on the protocol for this situation and preferred to err on the side of caution. > With that in mind (and also given that Jordan actually commented on the > dupe register read, before giving his R-b for v4), I have now carried > forward both R-b's from v4 to this patch, after verifying the v5 updates: > > Reviewed-by: Laszlo Ersek > Reviewed-by: Jordan Justen > > I hope that's fine with you, Jordan -- I wanted neither to delay this > series any longer (I promised Phil Friday and he's been very quick to > address our observations) nor to lose your R-b. Again, I think the > changes are minor enough to preserve our R-b's from v4. > > Series pushed as 59a36f21ac2b..c137d9508169. > > Phil, thanks for the contribution, Thanks for your help and patience with this patchset Laszlo and Jordan! Phil