public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Narinder Dhillon <ndhillonv2@gmail.com>
To: edk2-devel@lists.01.org
Subject: MdeModulePkg/Universal/Network/IScsiDxe
Date: Wed, 30 Nov 2016 11:19:57 -0800	[thread overview]
Message-ID: <CAGLD-8yokLR8UtOyUc6GHjbx7HQeq0MgSa0ew2o0SQiBjRsg5w@mail.gmail.com> (raw)

Hi All,

In IScsiDxe driver, IScsiPublishIbft ( ) is called from both
IScsiDriverBindingStart and IScsiDriverBindingStop functions. In a
system with more than one network interface and no I_NAME variable, it
is possible that no iBFT tables are installed in start but during exit
boot services, in stop iBFT tables get installed temporarily for
network interfaces other than the first one as driver stop function
gets executed for all network interfaces one at a time.

This happens because the IScsiPublishIbft function removes the iBFT
table and then re-installs it if there are any interfaces detected
leaving out the current one that is being stopped.

How can we improve the decision making logic around the iBFT install
call that works both while starting and stopping the driver but avoids
the temporary installation of ACPI tables ?

Thanx,
Narinder Dhillon


                 reply	other threads:[~2016-11-30 19:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGLD-8yokLR8UtOyUc6GHjbx7HQeq0MgSa0ew2o0SQiBjRsg5w@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox