From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-x232.google.com (mail-ua0-x232.google.com [IPv6:2607:f8b0:400c:c08::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4B2DC81C98 for ; Wed, 30 Nov 2016 11:19:59 -0800 (PST) Received: by mail-ua0-x232.google.com with SMTP id b35so223389080uaa.3 for ; Wed, 30 Nov 2016 11:19:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=jO0mdIQwIUqzXSA1c6a5q3dm1dfjlXPOTwIgN7YD2W4=; b=heySUfCvvKm6if687jnk1lw3+Jb8Hup1G1ef3irJx1mUJ3YwhUpp8vX6qPBAE3b65Q 8tOK6uEMtqFf+ZsA97/EBYIPn66pUXdKSlfoHvOsUaJi9Y3wWVjsd4wHb5lNXm3NjuR+ Ex4cQt/8polbozdBoef+KZQQKUJ1X9lyroojEy5O+zej1G9KvXMGFVfMVvHZ4lvIYpX4 gP6ZPKDcBcHBp6tqvc3CBfP0Ro+WRjtCYZDDaPvwkj1qkfVmZmwKSLQ+e4ycqkOgwIrl LD/rDo7xwG4v4pRSQJaX4KSbAw9b24lkw6fsWu3AwRVwLDvpVzuSyzI+pNq3RtxzSl1I mGYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=jO0mdIQwIUqzXSA1c6a5q3dm1dfjlXPOTwIgN7YD2W4=; b=J6e4Sh/mTs1hPHiWQfb2zs1Abd4wh9+c8XiKDOVtQwjotBY1kjk3DwmXtAAIh7b+9q 3omd9VDplrQeh/aaESMHfReybBEVd4DL+x72WcZKIRgLiwLADBCs2DFj0dqLYiuIAhIA Wkl4TYI4Em3gat143Sr6o+yT9++jb9iTaEj18K7YOqfYZQRi2RrXU/lhda1t8zJ92exx SN2tZ4N00luXAHa6n6xj+WCXh2pefX/u+Dsd7wDVWYZIBohMbmp66FGcriOr1cmglcLv i8cqf7BuWM1xeNwhcZZ9/2WRfTf5c1hF1oqhqV0rXmhvugyz9YVPOebLabVRuga8BEtb JtfA== X-Gm-Message-State: AKaTC00V56SiNbwAfXlZ6y4Wgryq8ys0AxzkFledOYSlT6oILjz9XESjHiNIM0h5sQ7qdW+H/ldaQQ/cnbI0Qw== X-Received: by 10.176.2.110 with SMTP id 101mr27435256uas.8.1480533598035; Wed, 30 Nov 2016 11:19:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.128.21 with HTTP; Wed, 30 Nov 2016 11:19:57 -0800 (PST) From: Narinder Dhillon Date: Wed, 30 Nov 2016 11:19:57 -0800 Message-ID: To: edk2-devel@lists.01.org Subject: MdeModulePkg/Universal/Network/IScsiDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2016 19:19:59 -0000 Content-Type: text/plain; charset=UTF-8 Hi All, In IScsiDxe driver, IScsiPublishIbft ( ) is called from both IScsiDriverBindingStart and IScsiDriverBindingStop functions. In a system with more than one network interface and no I_NAME variable, it is possible that no iBFT tables are installed in start but during exit boot services, in stop iBFT tables get installed temporarily for network interfaces other than the first one as driver stop function gets executed for all network interfaces one at a time. This happens because the IScsiPublishIbft function removes the iBFT table and then re-installs it if there are any interfaces detected leaving out the current one that is being stopped. How can we improve the decision making logic around the iBFT install call that works both while starting and stopping the driver but avoids the temporary installation of ACPI tables ? Thanx, Narinder Dhillon