public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Patryk Duda <pdk@semihalf.com>
To: Marcin Wojtas <mw@semihalf.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	 Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"jsd@semihalf.com" <jsd@semihalf.com>
Subject: Re: [edk2-platforms: PATCH 0/2] Armada 7k8k SPI flash driver improvements
Date: Fri, 27 Sep 2019 16:48:46 +0200	[thread overview]
Message-ID: <CAGOBvLo4fGPMe9v59bsok72gMdf38dup5X6Mt8=3ra6113iCqw@mail.gmail.com> (raw)
In-Reply-To: <CAPv3WKc0LaM6b=Xfp=pZ6nV1mr5NAx0=d0Az-KRRSGN5VBhWag@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]

Hi,

Do you have any remarks to the patchset?

Best regards,
Patryk

wt., 10 wrz 2019 o 08:23 Marcin Wojtas <mw@semihalf.com> napisał(a):

> pon., 9 wrz 2019 o 17:52 Patryk Duda <pdk@semihalf.com> napisał(a):
> >
> > Hi,
> >
> > This patchset contains progress bar implementation for MvSpiFlash driver
> and
> > small fix in calculating number of sectors to write.
> >
> > Progress bar implementation was mostly borrowed from TFTP module.
> > During implementation it turned out that when size is multiplication of
> > sector size, then last sector was not copied because remainder was 0.
> > This was fixed by increasing number of sectors to write.
> >
> > I'm looking forward to your comments or remarks.
> >
> > Best regards,
> > Patryk
> >
> > Patryk Duda (2):
> >   Marvell/Drivers: MvSpiFlashDxe: Fix sector number obtaining
> >   Marvell/Drivers: MvSpiFlashDxe: Implement progress bar
> >
> >  Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.inf |  1 +
> >  Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.h   |  1 +
> >  Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.c   | 59
> ++++++++++++++++----
> >  3 files changed, 51 insertions(+), 10 deletions(-)
> >
>
> Tested-by: Marcin Wojtas <mw@semihalf.com>
>

[-- Attachment #2: Type: text/html, Size: 1884 bytes --]

      reply	other threads:[~2019-09-27 14:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-09 15:52 [edk2-platforms: PATCH 0/2] Armada 7k8k SPI flash driver improvements Patryk Duda
2019-09-09 15:52 ` [edk2-platforms: PATCH 1/2] Marvell/Drivers: MvSpiFlashDxe: Fix sector number obtaining Patryk Duda
2019-09-28 22:37   ` Leif Lindholm
2019-09-09 15:52 ` [edk2-platforms: PATCH 2/2] Marvell/Drivers: MvSpiFlashDxe: Implement progress bar Patryk Duda
2019-09-28 22:47   ` Leif Lindholm
2019-09-10  6:23 ` [edk2-platforms: PATCH 0/2] Armada 7k8k SPI flash driver improvements Marcin Wojtas
2019-09-27 14:48   ` Patryk Duda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGOBvLo4fGPMe9v59bsok72gMdf38dup5X6Mt8=3ra6113iCqw@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox