From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=luXtF2Py; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.167.65, mailfrom: pdk@semihalf.com) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by groups.io with SMTP; Fri, 27 Sep 2019 07:49:31 -0700 Received: by mail-lf1-f65.google.com with SMTP id r134so2111631lff.12 for ; Fri, 27 Sep 2019 07:49:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2P1+p4CpONAXBxVYHbEVmedGGhRf6x1u8lso+nIs3jM=; b=luXtF2Py/LfpbyStXQeb+SZWJfBegyGQbMAaAvTFyys0cwrXikBJbnkFj2xjaWJOcI KwUIXRe3i05qXWqi/5IR1TtPKfuvBWiR3/h/HGKCPBVVyr3/8hSbe1iwcnaxZWaus32E qF066iYsk4MDvnGe+W082dsNp3aslkSXW0MMCZ3ou57In18siTuItTa/tnvSucRcwZq1 FIhr+6WZMKK1YBXT8yqMLAibHl/qlbHEyWBiMVM9RrGgUHwVnC/qWVA1dfndDfSjZasd E9eMk5D0c6IgFzygdqA64z5sl1eoCs4n/E/CNNiXSddLMSW5tiN1RyUtlOM1akIoIapN /gFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2P1+p4CpONAXBxVYHbEVmedGGhRf6x1u8lso+nIs3jM=; b=jOgd/f9P1lC0ChNnxhRvseOAgBu3GGjOh/aQRRvj3MGnlfkxROiPziuRWhlymGSmhS rbBXQqx+3KL3+8/iiW2FDzEHPYwpCOEwQgAhvd9jGScnUhL/D8VopVS2R3ZawU5xOMbJ ReWoHZ2ZlC1URAdRTqFz37aA2sCAv/nQlhSyOCFrITCtMrtfoFT96lZN0iVHZFn6i9FN dv6K5wc2Gcpql0uoj87NHLaTCxJ5MrZxg61XptGPk+DSlTXVtmlK2qLE+KOuMhi3lF4a YVgecAD7K8CLdXkbLyYbwCqe5PYvK9CUThmqmRnyovzbFpTkWfzeVqNDvDIlco2dKlZL enAg== X-Gm-Message-State: APjAAAXxDhv86z/xod1TdWzZDUXM84a5EQeUzpbKVXGv86PiVxP2wwhJ cQU4znaxwkBdW2tr4fVKeAjyrXWSCGXdqIeioc0MPw== X-Google-Smtp-Source: APXvYqwT87vcT4QdEEnzcsf9V315SvtPV1J3+WAF7EFZAG9abS/0Ym8z9Kl8tbe89W5QlztYuKv/LFPtIwHKmv5rLOo= X-Received: by 2002:a19:ef17:: with SMTP id n23mr2973361lfh.109.1569595769558; Fri, 27 Sep 2019 07:49:29 -0700 (PDT) MIME-Version: 1.0 References: <20190909155212.30338-1-pdk@semihalf.com> In-Reply-To: From: Patryk Duda Date: Fri, 27 Sep 2019 16:48:46 +0200 Message-ID: Subject: Re: [edk2-platforms: PATCH 0/2] Armada 7k8k SPI flash driver improvements To: Marcin Wojtas Cc: edk2-devel-groups-io , Leif Lindholm , Ard Biesheuvel , "jsd@semihalf.com" Content-Type: multipart/alternative; boundary="000000000000492af0059389fed4" --000000000000492af0059389fed4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Do you have any remarks to the patchset? Best regards, Patryk wt., 10 wrz 2019 o 08:23 Marcin Wojtas napisa=C5=82(a): > pon., 9 wrz 2019 o 17:52 Patryk Duda napisa=C5=82(a): > > > > Hi, > > > > This patchset contains progress bar implementation for MvSpiFlash drive= r > and > > small fix in calculating number of sectors to write. > > > > Progress bar implementation was mostly borrowed from TFTP module. > > During implementation it turned out that when size is multiplication of > > sector size, then last sector was not copied because remainder was 0. > > This was fixed by increasing number of sectors to write. > > > > I'm looking forward to your comments or remarks. > > > > Best regards, > > Patryk > > > > Patryk Duda (2): > > Marvell/Drivers: MvSpiFlashDxe: Fix sector number obtaining > > Marvell/Drivers: MvSpiFlashDxe: Implement progress bar > > > > Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.inf | 1 + > > Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.h | 1 + > > Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.c | 59 > ++++++++++++++++---- > > 3 files changed, 51 insertions(+), 10 deletions(-) > > > > Tested-by: Marcin Wojtas > --000000000000492af0059389fed4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Do you have any remarks = to the patchset?

Best regards,
Patryk

wt., 10 wrz 2019 o 08:23=C2=A0Marcin Wojtas <mw@semihalf.com> napisa=C5=82(a):
pon., 9 wrz 2019 o 17:52 Patryk Dud= a <pdk@semihalf.co= m> napisa=C5=82(a):
>
> Hi,
>
> This patchset contains progress bar implementation for MvSpiFlash driv= er and
> small fix in calculating number of sectors to write.
>
> Progress bar implementation was mostly borrowed from TFTP module.
> During implementation it turned out that when size is multiplication o= f
> sector size, then last sector was not copied because remainder was 0.<= br> > This was fixed by increasing number of sectors to write.
>
> I'm looking forward to your comments or remarks.
>
> Best regards,
> Patryk
>
> Patryk Duda (2):
>=C2=A0 =C2=A0Marvell/Drivers: MvSpiFlashDxe: Fix sector number obtainin= g
>=C2=A0 =C2=A0Marvell/Drivers: MvSpiFlashDxe: Implement progress bar
>
>=C2=A0 Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.inf |=C2= =A0 1 +
>=C2=A0 Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.h=C2=A0 = =C2=A0|=C2=A0 1 +
>=C2=A0 Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.c=C2=A0 = =C2=A0| 59 ++++++++++++++++----
>=C2=A0 3 files changed, 51 insertions(+), 10 deletions(-)
>

Tested-by: Marcin Wojtas <mw@semihalf.com>
--000000000000492af0059389fed4--