Re: [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev

[Patryk Duda <pdk@semihalf.com>]

[-- Attachment #1: Type: text/plain, Size: 1531 bytes --]

Hi,

Do you have any remarks to this patch?

Best Regards,
Patryk

wt., 10 wrz 2019 o 08:24 Marcin Wojtas <mw@semihalf.com> napisał(a):

> pon., 9 wrz 2019 o 17:53 Patryk Duda <pdk@semihalf.com> napisał(a):
> >
> > This patch fixes missing MdioIndex copying during initialization.
> > This bug appeared as inability to communicate with PHY connected
> > to MDIO other than first.
> >
> > Signed-off-by: Patryk Duda <pdk@semihalf.com>
> > ---
> >  Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> > index 6cdef42391..2d2aad7e38 100644
> > --- a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> > +++ b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> > @@ -419,8 +419,12 @@ MvPhyInit (
> >    PhyDev = AllocateZeroPool (sizeof (PHY_DEVICE));
> >    PhyDev->Addr = PhySmiAddresses[PhyIndex];
> >    PhyDev->Connection = PhyConnection;
> > -  DEBUG((DEBUG_INFO, "MvPhyDxe: PhyAddr is %d, connection %d\n",
> > -        PhyDev->Addr, PhyConnection));
> > +  PhyDev->MdioIndex = MdioIndex;
> > +  DEBUG ((DEBUG_INFO,
> > +    "MvPhyDxe: MdioIndex is %d, PhyAddr is %d, connection %d\n",
> > +    PhyDev->MdioIndex,
> > +    PhyDev->Addr,
> > +    PhyConnection));
> >    *OutPhyDev = PhyDev;
> >
> >    DeviceIds = PcdGetPtr (PcdPhyDeviceIds);
> > --
>
> Tested-by: Marcin Wojtas <mw@semihalf.com>
>

[-- Attachment #2: Type: text/html, Size: 2266 bytes --]