From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=HVyTT/hO; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.208.195, mailfrom: pdk@semihalf.com) Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by groups.io with SMTP; Fri, 27 Sep 2019 08:12:19 -0700 Received: by mail-lj1-f195.google.com with SMTP id n14so2834482ljj.10 for ; Fri, 27 Sep 2019 08:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wqJi8GTjYsj90lJXZALo87o8rxGlClhkfOgY/SJeoLY=; b=HVyTT/hO8djCPMS+41mgP9qtWR2qbLdnRIyfIlAdP7BzpUukJgCmN9B7yb2ZOZ8gWT G7Zo3bHUcwudj9MGZP7++FjPftjXvnU+hsnbG3eWInxqaOJcGFxaYczlNfpEYLx4jfI1 +MD1VFB424mIVQImB0lYd7BWIPdq/LEW9m4+q/WbNYJffuDmbfMrpxzeurMTds8ueH9H vah5gGbLLVl0CI97SSfmbU3UF+zWwQsTLbFDFxcviSURpIyWKf7AbwmZvVTguUYFvRzz KLIr7irfjvkMLMXCtMM7z8XUmJhnqVtFoAtD8sikrfw7LBiZ06TM4GJyQzZBJsKcver8 Dnxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wqJi8GTjYsj90lJXZALo87o8rxGlClhkfOgY/SJeoLY=; b=auJVxvmFyVA14QFJzaaCKTzbns4BjAy/VYAIATpxVFgWL8ETgTsERxVg7vI3ODy0ru MgQK8RpjeEVDnldbIa7Gr8h6EyG7Efpa97QJIJP7lmSg6tZiIz+UNO6l9Ftw1uj/1u/k O6Wye/nq4+2MH/rhabPpkSZI0EdRAApkZEaZUVUlRkSQ1cSm/zYxdXP0SlnPe95IXM5x PPZsQqFmTxxwZb3vR+63AQO9IXYTjKMRJUW0AlB1GFcvHRKs+Yd5wwmENZEEkq0zf8Jc eplrdA1R0YywZnXrlkm1nKbX2nmOar9pkQLhDQ+pDT27tN6FzPnmRuLtEJtQEoBVw4i5 EHOQ== X-Gm-Message-State: APjAAAV3ZLQRPOFcg1LXlgNzRGyIKuIk6lxcC7xMHBswNZHfL6jfNIQW xmSIcfeSSDO7f/F1xYvy1tUhCClUp1ypErEm5p+8BQ== X-Google-Smtp-Source: APXvYqzssdUEjlNcqvf7K5/DMqfW28oE0IlMWgJ6msRRrQNxnud2qEb9M559l6p8Zd/twLJnnpC9IU9+V84T3e3HZCw= X-Received: by 2002:a05:651c:154:: with SMTP id c20mr3289975ljd.83.1569597137398; Fri, 27 Sep 2019 08:12:17 -0700 (PDT) MIME-Version: 1.0 References: <20190909155310.30427-1-pdk@semihalf.com> In-Reply-To: From: Patryk Duda Date: Fri, 27 Sep 2019 17:11:34 +0200 Message-ID: Subject: Re: [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev To: Marcin Wojtas Cc: edk2-devel-groups-io , Leif Lindholm , Ard Biesheuvel , "jsd@semihalf.com" Content-Type: multipart/alternative; boundary="000000000000d0c17a05938a4f84" --000000000000d0c17a05938a4f84 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Do you have any remarks to this patch? Best Regards, Patryk wt., 10 wrz 2019 o 08:24 Marcin Wojtas napisa=C5=82(a): > pon., 9 wrz 2019 o 17:53 Patryk Duda napisa=C5=82(a): > > > > This patch fixes missing MdioIndex copying during initialization. > > This bug appeared as inability to communicate with PHY connected > > to MDIO other than first. > > > > Signed-off-by: Patryk Duda > > --- > > Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > > index 6cdef42391..2d2aad7e38 100644 > > --- a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > > +++ b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > > @@ -419,8 +419,12 @@ MvPhyInit ( > > PhyDev =3D AllocateZeroPool (sizeof (PHY_DEVICE)); > > PhyDev->Addr =3D PhySmiAddresses[PhyIndex]; > > PhyDev->Connection =3D PhyConnection; > > - DEBUG((DEBUG_INFO, "MvPhyDxe: PhyAddr is %d, connection %d\n", > > - PhyDev->Addr, PhyConnection)); > > + PhyDev->MdioIndex =3D MdioIndex; > > + DEBUG ((DEBUG_INFO, > > + "MvPhyDxe: MdioIndex is %d, PhyAddr is %d, connection %d\n", > > + PhyDev->MdioIndex, > > + PhyDev->Addr, > > + PhyConnection)); > > *OutPhyDev =3D PhyDev; > > > > DeviceIds =3D PcdGetPtr (PcdPhyDeviceIds); > > -- > > Tested-by: Marcin Wojtas > --000000000000d0c17a05938a4f84 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Do you have any remarks = to this patch?

Best Regards,
Patryk
<= /div>

wt., 10 wrz 2019 o 08:24=C2=A0Marcin Wojtas <mw@semihalf.com> napisa=C5=82(a):
pon., 9 wrz 2019 o 17:53 Patryk Duda = <pdk@semihalf.com<= /a>> napisa=C5=82(a):
>
> This patch fixes missing MdioIndex copying during initialization.
> This bug appeared as inability to communicate with PHY connected
> to MDIO other than first.
>
> Signed-off-by: Patryk Duda <pdk@semihalf.com>
> ---
>=C2=A0 Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 8 ++++++--
>=C2=A0 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c b/Silicon= /Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> index 6cdef42391..2d2aad7e38 100644
> --- a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> +++ b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> @@ -419,8 +419,12 @@ MvPhyInit (
>=C2=A0 =C2=A0 PhyDev =3D AllocateZeroPool (sizeof (PHY_DEVICE));
>=C2=A0 =C2=A0 PhyDev->Addr =3D PhySmiAddresses[PhyIndex];
>=C2=A0 =C2=A0 PhyDev->Connection =3D PhyConnection;
> -=C2=A0 DEBUG((DEBUG_INFO, "MvPhyDxe: PhyAddr is %d, connection %= d\n",
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 PhyDev->Addr, PhyConnection));
> +=C2=A0 PhyDev->MdioIndex =3D MdioIndex;
> +=C2=A0 DEBUG ((DEBUG_INFO,
> +=C2=A0 =C2=A0 "MvPhyDxe: MdioIndex is %d, PhyAddr is %d, connect= ion %d\n",
> +=C2=A0 =C2=A0 PhyDev->MdioIndex,
> +=C2=A0 =C2=A0 PhyDev->Addr,
> +=C2=A0 =C2=A0 PhyConnection));
>=C2=A0 =C2=A0 *OutPhyDev =3D PhyDev;
>
>=C2=A0 =C2=A0 DeviceIds =3D PcdGetPtr (PcdPhyDeviceIds);
> --

Tested-by: Marcin Wojtas <mw@semihalf.com>
--000000000000d0c17a05938a4f84--