From: Roman Bacik <roman.bacik@broadcom.com>
To: edk2-devel@lists.01.org
Cc: Ruiyu Ni <ruiyu.ni@intel.com>,
Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>
Subject: Re: [PATCH] [PATCH v1] MdeModulePkg/Core: Fix MaxAddress in Gcd
Date: Mon, 30 Apr 2018 08:46:36 -0700 [thread overview]
Message-ID: <CAGQAs7wHkctPZ_SNF49UvjV8OkaPw17a0wTsZNcZ8eJr0+79tQ@mail.gmail.com> (raw)
Will change subject to: "[edk2] [PATCH v2] MdeModulePkg/Core: Fix
MaxAddress in Gcd" for the next version if required.
On Fri, Apr 27, 2018 at 3:36 PM, Roman Bacik <roman.bacik@broadcom.com>
wrote:
> When BottomUp search is used the MaxAddress is incorrectly chosen to
> be BaseAddress instead of EndAddress.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Roman Bacik <roman.bacik@broadcom.com>
> ---
> MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
> b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
> index e17e98230b79..9eeb2bd74599 100644
> --- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
> +++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
> @@ -1170,8 +1170,8 @@ CoreAllocateSpace (
> //
> // Compute the maximum address to use in the search algorithm
> //
> - if (GcdAllocateType == EfiGcdAllocateMaxAddressSearchBottomUp ||
> - GcdAllocateType == EfiGcdAllocateMaxAddressSearchTopDown ) {
> + if (GcdAllocateType == EfiGcdAllocateMaxAddressSearchTopDown ||
> + GcdAllocateType == EfiGcdAllocateAnySearchTopDown ) {
> MaxAddress = *BaseAddress;
> } else {
> MaxAddress = Entry->EndAddress;
> --
> 1.9.1
>
next reply other threads:[~2018-04-30 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 15:46 Roman Bacik [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-27 22:36 [PATCH] [PATCH v1] MdeModulePkg/Core: Fix MaxAddress in Gcd Roman Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGQAs7wHkctPZ_SNF49UvjV8OkaPw17a0wTsZNcZ8eJr0+79tQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox