From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::136; helo=mail-it1-x136.google.com; envelope-from=df7729@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-it1-x136.google.com (mail-it1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3AA4E211963F0 for ; Mon, 10 Dec 2018 23:11:58 -0800 (PST) Received: by mail-it1-x136.google.com with SMTP id b5so2139155iti.2 for ; Mon, 10 Dec 2018 23:11:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hcH6lACgQP0ngHKJP6Nzr2cWwaBIynM7Qbg82TndJ9o=; b=M2YdI9lZQMDzNSVJrUgVLDMSOSyv2fcvc+y3v7FW1uLwoBBkBxhYuLqnC9BgdWIoUR LGnryUBttpBcYiM4V1mklY/Pcb+hFtmoYsSR8iV4I82SMT75HvlE6rhxZ38fql0qCpcr i9lhPTY24TH27b42Nduvu7yFx0B6pYY2RqYLVqcHJiikAUMOTbEsHftzmlZWgqty/lI2 OmkUghy0PrHbtPIJvAiM3kFcrIXqDbclK9YvEETQNkHSmc/NTgmTF0bvh68Qq0Xf2abl JiOse4brgwq1zd2Ub0quYDeEDAq6/ekW7Bqc0Vq3gFGScPcKvII9HyXJMoD2ts9K/BbC pSTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hcH6lACgQP0ngHKJP6Nzr2cWwaBIynM7Qbg82TndJ9o=; b=U9uqkHhjxnqZF5akBr+fXbtnIH42n/ywBz/Wjbll3//wD2JJWZef2JD8HMvbY79YXf Fwk0pplk6aZkmo/CuzxTIq81n6CI1at/MRnQDgYAnWKkjdB8vRIV985p13rR1xieoGSp e93+l9tXsVKVOkMYFaNVZ4DFIrnhu4+mW1jCAdsd8AxjAAr+mZAb5GaRZJAmIwaFBMyv QmjVDKMBU025my3kq1V6n/NJ11yIqkoigP6xmp0W9/r/Ua0HT8faFs8liFM6FVVuFij5 0Hdk9Fp4fOfUy7g42l1jM/q8fQaRA+sFtbV25hX6ULnshYrQBs4XLO/uqSUlXr8zHsEY NlHw== X-Gm-Message-State: AA+aEWaKO3+A1Wf7ONu3kr49afth8PU+DrBZeDfM9rh62myrrFQXImHw n6oSc2tXXnIyMB0yTCs4mSbfX0oBS1rUPU3MUw4= X-Google-Smtp-Source: AFSGD/UwE3g4bE9t5efq1yuyeImV1F7eQXIfK1svKzHMt86sTe5arlX9++tot21EXzZIC+q33otsNjTFaN6Pr1WjZPw= X-Received: by 2002:a24:1dce:: with SMTP id 197mr1368893itj.154.1544512317217; Mon, 10 Dec 2018 23:11:57 -0800 (PST) MIME-Version: 1.0 References: <20181130224537.18936-1-ard.biesheuvel@linaro.org> <20181130224537.18936-7-ard.biesheuvel@linaro.org> <4a244c8f-8f59-2936-f543-2bd43f78af9c@redhat.com> In-Reply-To: <4a244c8f-8f59-2936-f543-2bd43f78af9c@redhat.com> From: "David F." Date: Mon, 10 Dec 2018 23:11:46 -0800 Message-ID: To: Laszlo Ersek Cc: ard.biesheuvel@linaro.org, edk2 developers list , "Carsey, Jaben" , "Gao, Liming" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH v2 6/6] BaseTools/CommonLib: drop definition of MAX_UINTN X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2018 07:11:58 -0000 Content-Type: text/plain; charset="UTF-8" Not sure why you'd take that out when someone using UINTN for variables may want to use MAX_UINTN ? Future may be different. On Mon, Dec 3, 2018 at 5:08 AM Laszlo Ersek wrote: > On 11/30/18 23:45, Ard Biesheuvel wrote: > > The maximum value that can be represented by the native word size > > of the *target* should be irrelevant when compiling tools that > > run on the build *host*. So drop the definition of MAX_UINTN, now > > that we no longer use it. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > Reviewed-by: Jaben Carsey > > --- > > BaseTools/Source/C/Common/CommonLib.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/BaseTools/Source/C/Common/CommonLib.h > b/BaseTools/Source/C/Common/CommonLib.h > > index 6930d9227b87..b1c6c00a3478 100644 > > --- a/BaseTools/Source/C/Common/CommonLib.h > > +++ b/BaseTools/Source/C/Common/CommonLib.h > > @@ -22,7 +22,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, > EITHER EXPRESS OR IMPLIED. > > > > #define MAX_LONG_FILE_PATH 500 > > > > -#define MAX_UINTN MAX_ADDRESS > > #define MAX_UINT64 ((UINT64)0xFFFFFFFFFFFFFFFFULL) > > #define MAX_UINT16 ((UINT16)0xFFFF) > > #define MAX_UINT8 ((UINT8)0xFF) > > > > Reviewed-by: Laszlo Ersek > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >