stdlib broken strncasecmp.c

stdlib broken strncasecmp.c

[David F.]

I would submit a patch but over the years of fixes and enhancements,
they don't go anywhere. Then a couple years later someone does a
half-baked fix and I have to run merge resolution on svn.

Anyway, the problem with that is the s1 compare to 0 should be before
the s1++ (otherwise it matches when the s1 string is shorter than the
s2 string).

Re: stdlib broken strncasecmp.c

[Laszlo Ersek]

Hi,

On 11/10/17 20:09, David F. wrote:
> I would submit a patch but over the years of fixes and enhancements,
> they don't go anywhere. Then a couple years later someone does a
> half-baked fix and I have to run merge resolution on svn.

I've been subscribed to edk2-devel (wherever it lived whenever) since
approx. April 2012. So, I checked all my yearly archives, and the only
year where the search expression "df7729 patch" returns at least one hit
is 2013. Please don't judge the project's development process from a
four year old experience, there have been many changes.

Please consider submitting a patch with git:

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

(Optional reading:
<https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers>.)

Please don't forget to CC the StdLib maintainers on your patch -- they
are listed in "Maintainers.txt".

> Anyway, the problem with that is the s1 compare to 0 should be before
> the s1++ (otherwise it matches when the s1 string is shorter than the
> s2 string).

If you don't feel like posting a patch with git, can you perhaps
register in the TianoCore Bugzilla, and file a bug report there?

  https://bugzilla.tianocore.org/

  Product:   EDK2
  Component: Code
  Package:   StdLib

Thanks!
Laszlo

Re: stdlib broken strncasecmp.c

[Michael Zimmermann]

> I've been subscribed to edk2-devel (wherever it lived whenever) since
> approx. April 2012. So, I checked all my yearly archives, and the only
> year where the search expression "df7729 patch" returns at least one hit
> is 2013. Please don't judge the project's development process from a
> four year old experience, there have been many changes.
For StdLib I actually have the same experience(from 1-2 years ago).
Patches either never get responded to or just forgotten after a long discussion.

Thanks
Michael

On Mon, Nov 13, 2017 at 2:28 PM, Laszlo Ersek <lersek@redhat.com> wrote:
> Hi,
>
> On 11/10/17 20:09, David F. wrote:
>> I would submit a patch but over the years of fixes and enhancements,
>> they don't go anywhere. Then a couple years later someone does a
>> half-baked fix and I have to run merge resolution on svn.
>
> I've been subscribed to edk2-devel (wherever it lived whenever) since
> approx. April 2012. So, I checked all my yearly archives, and the only
> year where the search expression "df7729 patch" returns at least one hit
> is 2013. Please don't judge the project's development process from a
> four year old experience, there have been many changes.
>
> Please consider submitting a patch with git:
>
> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
>
> (Optional reading:
> <https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers>.)
>
> Please don't forget to CC the StdLib maintainers on your patch -- they
> are listed in "Maintainers.txt".
>
>> Anyway, the problem with that is the s1 compare to 0 should be before
>> the s1++ (otherwise it matches when the s1 string is shorter than the
>> s2 string).
>
> If you don't feel like posting a patch with git, can you perhaps
> register in the TianoCore Bugzilla, and file a bug report there?
>
>   https://bugzilla.tianocore.org/
>
>   Product:   EDK2
>   Component: Code
>   Package:   StdLib
>
> Thanks!
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: stdlib broken strncasecmp.c

[Carsey, Jaben]

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Michael Zimmermann
> Sent: Monday, November 13, 2017 11:58 AM
> To: Laszlo Ersek <lersek@redhat.com>
> Cc: edk2 developers list <edk2-devel@lists.01.org>
> Subject: Re: [edk2] stdlib broken strncasecmp.c
> 
> > I've been subscribed to edk2-devel (wherever it lived whenever) since
> > approx. April 2012. So, I checked all my yearly archives, and the only
> > year where the search expression "df7729 patch" returns at least one hit
> > is 2013. Please don't judge the project's development process from a
> > four year old experience, there have been many changes.
> For StdLib I actually have the same experience(from 1-2 years ago).
> Patches either never get responded to or just forgotten after a long
> discussion.

I am trying to stay on top of patches.  

I get lots of email.  If I don't get CC'd on the email, I freely admit that I have a higher risk of missing your email.  I know I got poked just today about a patch that did not CC me and I had missed it.  But that patch has been pushed.  This is not saying that patches were not missed in the past, but the goal is to fix the situation going forwards.

-Jaben


> 
> Thanks
> Michael
> 
> On Mon, Nov 13, 2017 at 2:28 PM, Laszlo Ersek <lersek@redhat.com> wrote:
> > Hi,
> >
> > On 11/10/17 20:09, David F. wrote:
> >> I would submit a patch but over the years of fixes and enhancements,
> >> they don't go anywhere. Then a couple years later someone does a
> >> half-baked fix and I have to run merge resolution on svn.
> >
> > I've been subscribed to edk2-devel (wherever it lived whenever) since
> > approx. April 2012. So, I checked all my yearly archives, and the only
> > year where the search expression "df7729 patch" returns at least one hit
> > is 2013. Please don't judge the project's development process from a
> > four year old experience, there have been many changes.
> >
> > Please consider submitting a patch with git:
> >
> > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-
> Development-Process
> >
> > (Optional reading:
> > <https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-
> git-guide-for-edk2-contributors-and-maintainers>.)
> >
> > Please don't forget to CC the StdLib maintainers on your patch -- they
> > are listed in "Maintainers.txt".
> >
> >> Anyway, the problem with that is the s1 compare to 0 should be before
> >> the s1++ (otherwise it matches when the s1 string is shorter than the
> >> s2 string).
> >
> > If you don't feel like posting a patch with git, can you perhaps
> > register in the TianoCore Bugzilla, and file a bug report there?
> >
> >   https://bugzilla.tianocore.org/
> >
> >   Product:   EDK2
> >   Component: Code
> >   Package:   StdLib
> >
> > Thanks!
> > Laszlo
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel