From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c00::22f; helo=mail-pf0-x22f.google.com; envelope-from=df7729@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-pf0-x22f.google.com (mail-pf0-x22f.google.com [IPv6:2607:f8b0:400e:c00::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 757262034D83F for ; Fri, 10 Nov 2017 11:05:45 -0800 (PST) Received: by mail-pf0-x22f.google.com with SMTP id b79so7318639pfk.5 for ; Fri, 10 Nov 2017 11:09:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=OgK8wA+jlibLdpMfrJZHrKm+4VKDWiWzFZ2DWreUuaI=; b=J6ygg9NPLb/4NulfVT7xkFRnSij7E0cyzaSuuSe8MsR/8PRWPWeCdIO9U2OXlHcqMq pdhi2WLPzW2xUlI0QVpWMzthwd43e+blzTwW7a3mse0i1NCz1ZL+j3fsB727F6jmq7Nd UBfukphvK+TUxioo3rvREPS2sKnncAkQxO62t+ZBVd6qFhDlmXNJ+YN+Vmgh3/ao+8fZ XpJAqHiFemYSp+mn7algbsCVVIrtTWhgohQHrKbHGxHN68v2w8FxfNQMzoqvdydimbME ldFOkFXQ/skxw/ONLiPWwh1XF+/8Luz9nuO0pRdD/TSripHwPPO4O/1vOD9bXLYMuouT ixDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=OgK8wA+jlibLdpMfrJZHrKm+4VKDWiWzFZ2DWreUuaI=; b=PlPF2eUHGTBQO/Yef0+62WidTLwqTDvr5tZ0EQ6bKb6piziHK9RQs73D6Pf7DBGNDi qh/2hLqt/zcoEpURsnm2u45CnhNSiygLj/2FeqSXNzZvtDgyPW4pWClIE8PFqMdJbwz+ OLUcHFBRNNjjtoNLYWIE6WimVUI2vaVYkoTRVkqchAGyLxxLYyzyMRntYsfv2ewScCWT I//vIR74927HHfIUb2bYw3vsNZ93TKEzJx9S7ad1gJdVfEjzRDThZkxqzxoTREH93I3K gU3jI+tVuzfUwmELE0dBJNFw2Ctu+SdbnjV9o3aFS5iSvprN+T5LdPG2ypa3NetGxBIj 5NIA== X-Gm-Message-State: AJaThX5e7sw8kJRo6YQL/BAs7I/tadVBR9fIxtDII6U7bZri5Boimqlr Rl72e+Yk4MocxsTYyCzDuIWgwF1hB1GLolIm050= X-Google-Smtp-Source: AGs4zMYTsw+zngQXEgX2jeuwsuWecnsz12Ht8bOniSNcrf6yqPa14pmzD94OP6Wu54Kh7nGQFOLAMeAA5pf5/Nsa7VY= X-Received: by 10.98.181.1 with SMTP id y1mr1378756pfe.240.1510340988058; Fri, 10 Nov 2017 11:09:48 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.162.204 with HTTP; Fri, 10 Nov 2017 11:09:47 -0800 (PST) From: "David F." Date: Fri, 10 Nov 2017 11:09:47 -0800 Message-ID: To: edk2 developers list Subject: stdlib broken strncasecmp.c X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Nov 2017 19:05:45 -0000 Content-Type: text/plain; charset="UTF-8" I would submit a patch but over the years of fixes and enhancements, they don't go anywhere. Then a couple years later someone does a half-baked fix and I have to run merge resolution on svn. Anyway, the problem with that is the s1 compare to 0 should be before the s1++ (otherwise it matches when the s1 string is shorter than the s2 string).