From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::131; helo=mail-it1-x131.google.com; envelope-from=df7729@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-it1-x131.google.com (mail-it1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 442F2211982E6 for ; Mon, 10 Dec 2018 23:16:31 -0800 (PST) Received: by mail-it1-x131.google.com with SMTP id p197so2178161itp.0 for ; Mon, 10 Dec 2018 23:16:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R0BiaA8GTW3PHZDp9H1cbc+6UpvGbNj/Ma+wYDBM52Y=; b=dLGi8TG8UlLH73KqO56VJFx/5L9GePqpiaq4fo/yXS0feJkPvU6cvrAoRWaBcRckXf EFTsBEnS7ZR+0tmqKrHs+373roeUhaEebikZlLrG8Zh9zD30CFRDtWXv//lYY5N/B2oE tPVyxH8N/fbpNwR/Rpj5FntUFeZJft87ppfQm2jgoYe8ZhwPaSNb137WjBx76CtjAgRg GOyazWqm9plO3jP342XurndBiFwvQfnGK1kDmOxChPOKJ+hqzXRDfeatbVBGj3httUkw fea1m/r33+GPBPEHTEZAvrEU60TzFsddGMsgO1xNsXCu4iSoL+lT5j7IBG4Ln8hjVznl rcGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R0BiaA8GTW3PHZDp9H1cbc+6UpvGbNj/Ma+wYDBM52Y=; b=gqEAt1wb1wFmjIVonZ0Io2HVhisiDbvE7lOHphBx6EeQ4EQBdaZSHj0lSOfmRxmEFF Pm2vnRfeWi2gpakd7+ULgm3KTZEXB3u387V64h7mfCVVRs9VzZ2+OSKLYQ1prczpnxEh 4gQ0BhgC1edyvWpFuBTu3nheD/8v8WnJQxjrbD3m6dZPzZIEEbR1FKBfVw4ai8p8CYS6 RQorv0naqfVqbXWUelGEVEIVY+M6hc6B+/1V/UljAc87NF0MUdU+vDS06Ppoehra3m0v /Ts8hl03yeo8wWdjEdDAErYii2Icwls/CCkZyNSN/6o8ylx9zJowPxDRgV8hZenjBO7M Wlmg== X-Gm-Message-State: AA+aEWbtp/vHQC7HyFaiP1pjh2sQNESgxM6dPeIhm9zqtYLjABPoAaOe Cy19iwq+x7cm0qr48HFbEECG95LeeHNQzubu5X4= X-Google-Smtp-Source: AFSGD/Um7TxhbBdR1Q+qSMx8h07frVix+qVxF/jOFvwZriYMplI3+d6kLBceci971ndWyPj4WxZc/4Wg0sa4DvGrFBM= X-Received: by 2002:a02:9d27:: with SMTP id n36mr13620427jak.30.1544512590291; Mon, 10 Dec 2018 23:16:30 -0800 (PST) MIME-Version: 1.0 References: <20181115074528.8024-1-shenglei.zhang@intel.com> <20181210185726.grk3rrbbekntreeu@bivouac.eciton.net> In-Reply-To: <20181210185726.grk3rrbbekntreeu@bivouac.eciton.net> From: "David F." Date: Mon, 10 Dec 2018 23:16:19 -0800 Message-ID: To: leif.lindholm@linaro.org Cc: mw@semihalf.com, "Carsey, Jaben" , ruiyu.ni@intel.com, edk2 developers list X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH] ShellPkg: Remove ShellPkg wrapper header files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2018 07:16:31 -0000 Content-Type: text/plain; charset="UTF-8" I ran in to it too, it was easy fix, the headers changed to those in MDEPKG and the header file name changed. IIRC it was the same name minus the leading Efi, so EfiShellParameters.h became ShellParameters.h. I don't have a full list but one of the notes on that change points out the new names. On Mon, Dec 10, 2018 at 10:57 AM Leif Lindholm wrote: > Hi Marcin, > > This EDK2 patch has been pushed, making all of the Armada platforms > stop building. Can you have a look please? > > Regards, > > Leif > > On Thu, Nov 15, 2018 at 03:45:28PM +0800, Shenglei Zhang wrote: > > These wrapper header files are not referenced by all > > open source, so they are removed. > > https://bugzilla.tianocore.org/show_bug.cgi?id=158 > > > > Cc: Jaben Carsey > > Cc: Ruiyu Ni > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Shenglei Zhang > > --- > > ShellPkg/Include/Protocol/EfiShell.h | 21 ------------------- > > .../Include/Protocol/EfiShellDynamicCommand.h | 21 ------------------- > > .../Include/Protocol/EfiShellParameters.h | 20 ------------------ > > ShellPkg/Include/ShellBase.h | 20 ------------------ > > 4 files changed, 82 deletions(-) > > delete mode 100644 ShellPkg/Include/Protocol/EfiShell.h > > delete mode 100644 ShellPkg/Include/Protocol/EfiShellDynamicCommand.h > > delete mode 100644 ShellPkg/Include/Protocol/EfiShellParameters.h > > delete mode 100644 ShellPkg/Include/ShellBase.h > > > > diff --git a/ShellPkg/Include/Protocol/EfiShell.h > b/ShellPkg/Include/Protocol/EfiShell.h > > deleted file mode 100644 > > index 8e3c2fe4de..0000000000 > > --- a/ShellPkg/Include/Protocol/EfiShell.h > > +++ /dev/null > > @@ -1,21 +0,0 @@ > > -/** @file > > - EFI Shell protocol as defined in the UEFI Shell 2.0 specification > including errata. > > - > > - (C) Copyright 2014 Hewlett-Packard Development Company, L.P.
> > - Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> > - This program and the accompanying materials > > - are licensed and made available under the terms and conditions of the > BSD License > > - which accompanies this distribution. The full text of the license > may be found at > > - http://opensource.org/licenses/bsd-license.php > > - > > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > > - > > -**/ > > - > > -#ifndef __EFI_SHELL_PROTOCOL_H__WRAPPER__ > > -#define __EFI_SHELL_PROTOCOL_H__WRAPPER__ > > - > > -#include > > - > > -#endif > > diff --git a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h > b/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h > > deleted file mode 100644 > > index 50f9398ec6..0000000000 > > --- a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h > > +++ /dev/null > > @@ -1,21 +0,0 @@ > > -/** @file > > - EFI Shell Dynamic Command registration protocol > > - > > - (C) Copyright 2012-2014 Hewlett-Packard Development Company, L.P.
> > - Copyright (c) 2016, Intel Corporation. All rights reserved.
> > - This program and the accompanying materials > > - are licensed and made available under the terms and conditions of the > BSD License > > - which accompanies this distribution. The full text of the license > may be found at > > - http://opensource.org/licenses/bsd-license.php > > - > > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > > - > > -**/ > > - > > -#ifndef __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__ > > -#define __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__ > > - > > -#include > > - > > -#endif > > diff --git a/ShellPkg/Include/Protocol/EfiShellParameters.h > b/ShellPkg/Include/Protocol/EfiShellParameters.h > > deleted file mode 100644 > > index 184b029ffa..0000000000 > > --- a/ShellPkg/Include/Protocol/EfiShellParameters.h > > +++ /dev/null > > @@ -1,20 +0,0 @@ > > -/** @file > > - EFI Shell protocol as defined in the UEFI Shell 2.0 specification. > > - > > - Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> > - This program and the accompanying materials > > - are licensed and made available under the terms and conditions of the > BSD License > > - which accompanies this distribution. The full text of the license > may be found at > > - http://opensource.org/licenses/bsd-license.php > > - > > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > > - > > -**/ > > - > > -#ifndef __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__ > > -#define __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__ > > - > > -#include > > - > > -#endif > > diff --git a/ShellPkg/Include/ShellBase.h b/ShellPkg/Include/ShellBase.h > > deleted file mode 100644 > > index 725ce5242f..0000000000 > > --- a/ShellPkg/Include/ShellBase.h > > +++ /dev/null > > @@ -1,20 +0,0 @@ > > -/** @file > > - Root include file for Shell Package modules that utilize the > SHELL_RETURN type > > - > > - Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.
> > - This program and the accompanying materials > > - are licensed and made available under the terms and conditions of the > BSD License > > - which accompanies this distribution. The full text of the license > may be found at > > - http://opensource.org/licenses/bsd-license.php > > - > > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > > - > > -**/ > > - > > -#ifndef _SHELL_BASE_ > > -#define _SHELL_BASE_ > > - > > -#include > > - > > -#endif //__SHELL_BASE_ > > -- > > 2.18.0.windows.1 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >