From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by mx.groups.io with SMTP id smtpd.web08.11593.1613754621815081818 for ; Fri, 19 Feb 2021 09:10:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@corthon-com.20150623.gappssmtp.com header.s=20150623 header.b=bnoxoh7i; spf=pass (domain: gmail.com, ip: 209.85.210.41, mailfrom: debtech@gmail.com) Received: by mail-ot1-f41.google.com with SMTP id b16so5743428otq.1 for ; Fri, 19 Feb 2021 09:10:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corthon-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K0jDTAUztPKllVtWPNn7PLmFtVQck7fqNJP5dk8Gy/c=; b=bnoxoh7iNiUnccTVek9yw6zk4NioiB3z+XAYFJciiTMYYTP3f4PQ06KKsoQyL2zEiy zJEvUTYir4ioRAil/1oBe2B3lfFATjFb+d+atWlTcpHOVxWkrVYnwvkYz1bBxoRh1Ykq 2+apjU5ydsROP8pmQeCb0bztaX5xC/L9I2q+99oi9++erPk7y6sCeZf8hu7Gw7cNzG02 0uBPQzWUltZtX9qQWNNBBgmjVi/7FdKdcuqkKAUXmjAI8qFn0XBdjQQgFosyLDVJJFjd z3sFFL6I9yEcDCls0PB/owijmUOFAkWybAOkfeN2knwf0cPlbFuJnn78hFrSO8H2QeoA LmpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K0jDTAUztPKllVtWPNn7PLmFtVQck7fqNJP5dk8Gy/c=; b=expK5jZi0o5On/3r/YIrRurLRwvV/xVOPwCn9feWtL6iBJ2muQU1ERY80A6rTHTvOq rIoxuI053wzMO/H6+2qpky4FsCRhYTWRcpS6uJ+9DLVd4ZpnPycx7jBxJT6lQ1QXn+ZH tofTO30YF9hi/o7eWacYp13ZXmRP4gcaV2gKgIdmoor9l1nta7MqCs4bTW9MJqfT/u/T H0xBmrLarSIWjMqjDFowP0YMFYb6O/92QoM/oDUvk8KMxLze3KfZ1Nmpqcq/OjWpmKyk YT16nGS2ZH6EEd76rVPz1ovmedwETYG/W2jxc+sFY6bsb0YCPHmC1janNpiXybsVUIQ5 SMvw== X-Gm-Message-State: AOAM531EVBdK5M6BWpUezkpf6hggrEpfnMaUtuCxHoYFT9QcF1V92Lhh CS3bOCrvyYxO7MVVJLIbvXzpO9fdZ3H6geUwDn8= X-Google-Smtp-Source: ABdhPJxXIUEAYeBVnM0YneZUXoJyNPiKmsvgMiOlQghEoJc/ojWPgF72XPT4r9BXOKugb96UCSqd390tHpCnKWoXCP4= X-Received: by 2002:a9d:a77:: with SMTP id 110mr7680783otg.74.1613754621154; Fri, 19 Feb 2021 09:10:21 -0800 (PST) MIME-Version: 1.0 References: <20210212204926.1114-1-bret.barkelew@microsoft.com> <9dd900ea-5b9f-aa54-04b9-cddf4a0f3ede@redhat.com> <000f01d705a7$9c1c59e0$d4550da0$@byosoft.com.cn> In-Reply-To: From: "Bret Barkelew" Date: Fri, 19 Feb 2021 09:10:09 -0800 Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update the NASM dependency To: Laszlo Ersek Cc: gaoliming , devel@edk2.groups.io Content-Type: multipart/alternative; boundary="000000000000f2d78405bbb386c5" --000000000000f2d78405bbb386c5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Good note. Is there an easy way to resubmit? Just edit the patch as is, or does there need to be a v2? On Fri, Feb 19, 2021 at 6:30 AM Laszlo Ersek wrote: > On 02/18/21 05:07, Bret Barkelew wrote: > > I'm not opposed to moving to 2.15.03 for consistency, but we'll have t= o > > publish a new package. This one is already pushed to Nuget. > > Thanks for the answers. From Liming's answer, I understand we don't try > to keep CI strictly in sync with edk2's (internal) BaseTools. > > So the patch should be fine; however, I think the subject line could be > clarified. "BaseTools: Update the NASM dependency" doesn't make it clear > that the CI builds are targeted primarily. > > Thanks > Laszlo > > > > > On Wed, Feb 17, 2021 at 7:39 PM gaoliming > wrote: > > > >> Laszlo: > >> > >>> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > >>> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+71686+4905953+8761045@grou= ps.io > >>> =E4=BB=A3=E8=A1=A8 La= szlo Ersek > >>> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B42=E6=9C=8816=E6= =97=A5 5:00 > >>> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; bret@corthon.com > >>> =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Updat= e the NASM > >>> dependency > >>> > >>> Hi Bret, > >>> > >>> On 02/12/21 21:49, Bret Barkelew wrote: > >>>> This is primarily used by CI builds, but may also be used by > platforms. > >>>> > >>>> Update NASM to support newer structures and features, as agreed in > >> recent > >>>> community meetings: > >>>> https://edk2.groups.io/g/devel/message/71289 > >>>> --- > >>>> BaseTools/Bin/nasm_ext_dep.yaml | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/BaseTools/Bin/nasm_ext_dep.yaml > >>> b/BaseTools/Bin/nasm_ext_dep.yaml > >>>> index 60b1f71b56aa..56703d4c18e7 100644 > >>>> --- a/BaseTools/Bin/nasm_ext_dep.yaml > >>>> +++ b/BaseTools/Bin/nasm_ext_dep.yaml > >>>> @@ -13,6 +13,6 @@ > >>>> "type": "nuget", > >>>> "name": "mu_nasm", > >>>> "source": "https://api.nuget.org/v3/index.json", > >>>> - "version": "2.14.02", > >>>> + "version": "2.15.5", > >>>> "flags": ["set_path", "host_specific"] > >>>> } > >>>> > >>> > >>> (1) I'm confused by the "patchlevel" number being "5" and not "05", = in > >>> the "2.15.5" version. Per > >>> , my understanding has > >>> been that the latest release is "2.15.05". > >>> > >>> (2) The minimum required version, according to > >>> , is "2.15.01". In the > >>> RHEL build environments that matter to me, I can satisfy a NASM > >>> dependency up to 2.15.03, at this time, but not beyond. And this > matters > >>> because... > >>> > >> I understand CI environment tries to use the latest tool version for > >> verification. > >> > >>> (3) ... arguably, the NASM requirement in > >>> "BaseTools/Conf/tools_def.template" should be updated too, in the sa= me > >>> patch: > >>> > >>> # - NASM 2.10 or later for use with the GCC toolchain family > >>> # - NASM 2.12.01 or later for use with all other toolchain familie= s > >>> > >> This is edk2 build environment requirement. It will be updated when t= he > >> source code change is added. > >> > >> Thanks > >> Liming > >>> Thanks > >>> Laszlo > >>> > >>> > >>> > >>>=20 > >>> > >> > >> > >> > >> > > > > --000000000000f2d78405bbb386c5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Good note. Is there an easy way to resubmit? Just edit the= patch as is, or does there need to be a v2?

On Fri, Feb 19, 2021 at 6:30 AM= Laszlo Ersek <lersek@redhat.com> wrote:
On = 02/18/21 05:07, Bret Barkelew wrote:
> I'm not opposed to moving to 2.15.03 for consistency, but we'= ll have to
> publish a new package. This one is already pushed to Nuget.

Thanks for the answers. From Liming's answer, I understand we don'= t try
to keep CI strictly in sync with edk2's (internal) BaseTools.

So the patch should be fine; however, I think the subject line could be clarified. "BaseTools: Update the NASM dependency" doesn't m= ake it clear
that the CI builds are targeted primarily.

Thanks
Laszlo

>
> On Wed, Feb 17, 2021 at 7:39 PM gaoliming <gaoliming@byosoft.com.cn> wro= te:
>
>> Laszlo:
>>
>>> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
>>> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+7168= 6+4905953+8761045@groups.io
>>> <bounce+27952+71686+4905953+8761045@groups.= io> =E4=BB=A3=E8=A1=A8 Laszlo Ersek
>>> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B42=E6=9C=88= 16=E6=97=A5 5:00
>>> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; bret@corthon.com
>>> =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 1/1] BaseTools= : Update the NASM
>>> dependency
>>>
>>> Hi Bret,
>>>
>>> On 02/12/21 21:49, Bret Barkelew wrote:
>>>> This is primarily used by CI builds, but may also be used= by platforms.
>>>>
>>>> Update NASM to support newer structures and features, as = agreed in
>> recent
>>>> community meetings:
>>>> https://edk2.groups.io/g/devel/message= /71289
>>>> ---
>>>>=C2=A0 BaseTools/Bin/nasm_ext_dep.yaml | 2 +-
>>>>=C2=A0 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/BaseTools/Bin/nasm_ext_dep.yaml
>>> b/BaseTools/Bin/nasm_ext_dep.yaml
>>>> index 60b1f71b56aa..56703d4c18e7 100644
>>>> --- a/BaseTools/Bin/nasm_ext_dep.yaml
>>>> +++ b/BaseTools/Bin/nasm_ext_dep.yaml
>>>> @@ -13,6 +13,6 @@
>>>>=C2=A0 =C2=A0 "type": "nuget",
>>>>=C2=A0 =C2=A0 "name": "mu_nasm",
>>>>=C2=A0 =C2=A0 "source": "https://= api.nuget.org/v3/index.json",
>>>> -=C2=A0 "version": "2.14.02",
>>>> +=C2=A0 "version": "2.15.5",
>>>>=C2=A0 =C2=A0 "flags": ["set_path", &q= uot;host_specific"]
>>>>=C2=A0 }
>>>>
>>>
>>> (1) I'm confused by the "patchlevel" number bei= ng "5" and not "05", in
>>> the "2.15.5" version. Per
>>> <https://edk2.groups.io/g/devel/message= /71045>, my understanding has
>>> been that the latest release is "2.15.05".
>>>
>>> (2) The minimum required version, according to
>>> <https://edk2.groups.io/g/devel/message= /71070>, is "2.15.01". In the
>>> RHEL build environments that matter to me, I can satisfy a NA= SM
>>> dependency up to 2.15.03, at this time, but not beyond. And t= his matters
>>> because...
>>>
>> I understand CI environment tries to use the latest tool version = for
>> verification.
>>
>>> (3) ... arguably, the NASM requirement in
>>> "BaseTools/Conf/tools_def.template" should be updat= ed too, in the same
>>> patch:
>>>
>>> #=C2=A0 =C2=A0- NASM 2.10 or later for use with the GCC toolc= hain family
>>> #=C2=A0 =C2=A0- NASM 2.12.01 or later for use with all other = toolchain families
>>>
>> This is edk2 build environment requirement. It will be updated wh= en the
>> source code change is added.
>>
>> Thanks
>> Liming
>>> Thanks
>>> Laszlo
>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>>
>

--000000000000f2d78405bbb386c5--