Re: [PATCH v1 07/16] ArmPkg and MdePkg: Move the AsmMacroIoLib from ArmPkg to MdePkg

["Bret Barkelew" <bret@corthon.com>]

[-- Attachment #1: Type: text/plain, Size: 1669 bytes --]

Will address. Thanks!

On Tue, Nov 2, 2021 at 2:25 AM Leif Lindholm <leif@nuviainc.com> wrote:

> On Mon, Nov 01, 2021 at 12:56:39 -0700, brbarkel@microsoft.com wrote:
> > From: Bret Barkelew <brbarkel@microsoft.com>
> >
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Signed-off-by: Bret Barkelew <bret.barkelew@microsoft.com>
> > ---
> >  {ArmPkg => MdePkg}/Include/AsmMacroIoLib.h | 0
>
> I approve of this move, but if it goes into MdePkg, it needs some form
> of arch-specific handling (like ProcessorBind.h, and indeed for x86,
> Nasm.inc).
>
> I also note that the AArch64 version is not moved at the same time.
> That seems counterintuituve.
>
> So could you:
> Move
> ArmPkg/Include/AsmMacroIoLib.h => MdePkg/Include/ARM/AsmMacroIoLib.h
> ArmPkg/Include/AsmMacroIoLibV8.h =>
> MdePkg/Include/AArch64/AsmMacroIoLibV8.h
> ?
>
> Ideally, the AArch64 version should also lose its spectacularly
> incorrect suffix, but that can wait for another day due to the
> resulting fallout.
>
> Ideally2, the VS .inc files ought to move with the ARM header, but that
> feels like a bit much of a can of worms to ask for.
>
> /
>     Leif
>
> >  1 file changed, 0 insertions(+), 0 deletions(-)
> >
> > diff --git a/ArmPkg/Include/AsmMacroIoLib.h
> b/MdePkg/Include/AsmMacroIoLib.h
> > similarity index 100%
> > rename from ArmPkg/Include/AsmMacroIoLib.h
> > rename to MdePkg/Include/AsmMacroIoLib.h
> > --
> > 2.31.1.windows.1
> >
>

[-- Attachment #2: Type: text/html, Size: 2761 bytes --]