From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by mx.groups.io with SMTP id smtpd.web12.422.1635882492753214633 for ; Tue, 02 Nov 2021 12:48:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@corthon-com.20210112.gappssmtp.com header.s=20210112 header.b=4+NUP90g; spf=pass (domain: gmail.com, ip: 209.85.219.174, mailfrom: debtech@gmail.com) Received: by mail-yb1-f174.google.com with SMTP id j75so986617ybj.6 for ; Tue, 02 Nov 2021 12:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corthon-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5M+c7yAeX7kgvQ0A6113/JwvEEJDhhuyH/QP9hVZUEU=; b=4+NUP90ghmSKIiI4Abh1qGMPNLMjOkAx556Cn5ZgGGXZiFCXeZHIrhrrwahVHidylR UNuUE5AU82LvPOjL1RDEts0NwXNWBo30zst6tlTrhjqK0DJqCFkDrx5aSUyIl75okSeX EEGIpEMpMkUtlIRpSblwo4pAbCV/fXsQNzo3xJMzEm+JKk0AYJh0ya2sOp8InlqySeL2 YnK1t0efqN/+ky4wqvQXpemFcTVs2FbyXOt6gm0tLkoaFaNQrrRlmhl5LG52lTU0mDHa yP+xER+cRKlO49JMEoYJ6r3cNbmtT8qGwua0ariWDUhnxQtjnsfUIKrRMM6KCfOC9V8b r3iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5M+c7yAeX7kgvQ0A6113/JwvEEJDhhuyH/QP9hVZUEU=; b=2eS15kX0uxFfDiC/kEF2RLuwgU3Nv0ZbuBA8WG/9sG/++Ln5pc6l4Z1vE3DoceAer3 /NRENrSkpjcPxgCJTyf0F6RGaPXfJx6VVa5mzlX6La4p/lOJohJYOpf/nY50NnyakKtI n943L/g8EEoFHtqpwzHbZwSX57FyxTpdjTwCVLaSf5/TPv0xqz/KhUH1Pcgkx/X1VUva WsM3V1VcwCZvB8kE3jCEbZKdgw4ztkyw7KOmk598sDlkNJmsWAU2mFmBfr9Hq0sSfBRO yExeTwgXFTOaEfaPPKyUno+5SRwLR8bUk5dtS1r+0oWniaYLPt99otJzdsV5Jg5BKvZI 25xA== X-Gm-Message-State: AOAM530xpw3a78fBZU2sdobvFl1TO/LN83bgGKanw6xbYe4jUYUyIOWZ rTeDfBf78wEXT+bZ7cVPfPyV5hXSIUtTk6JXOSg= X-Google-Smtp-Source: ABdhPJx8UQnYlEx/ld0VDcebW5RUTiV/DfnhISw9eBw9bQ3EOGEdRJ52Lmlf8la91vob/aqXt1HIvGNo8+g2Sw2PCmU= X-Received: by 2002:a25:aca8:: with SMTP id x40mr7957156ybi.174.1635882491895; Tue, 02 Nov 2021 12:48:11 -0700 (PDT) MIME-Version: 1.0 References: <20211101195648.6420-1-brbarkel@microsoft.com> <20211101195648.6420-8-brbarkel@microsoft.com> <20211102092459.p32fpnudv4gco5tr@leviathan> In-Reply-To: <20211102092459.p32fpnudv4gco5tr@leviathan> From: "Bret Barkelew" Date: Tue, 2 Nov 2021 12:48:02 -0700 Message-ID: Subject: Re: [PATCH v1 07/16] ArmPkg and MdePkg: Move the AsmMacroIoLib from ArmPkg to MdePkg To: Leif Lindholm Cc: devel@edk2.groups.io, Ard Biesheuvel , Michael D Kinney , Liming Gao , Zhiguang Liu , Sean Brogan Content-Type: multipart/alternative; boundary="000000000000d2e32205cfd392b4" --000000000000d2e32205cfd392b4 Content-Type: text/plain; charset="UTF-8" Will address. Thanks! On Tue, Nov 2, 2021 at 2:25 AM Leif Lindholm wrote: > On Mon, Nov 01, 2021 at 12:56:39 -0700, brbarkel@microsoft.com wrote: > > From: Bret Barkelew > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Sean Brogan > > Signed-off-by: Bret Barkelew > > --- > > {ArmPkg => MdePkg}/Include/AsmMacroIoLib.h | 0 > > I approve of this move, but if it goes into MdePkg, it needs some form > of arch-specific handling (like ProcessorBind.h, and indeed for x86, > Nasm.inc). > > I also note that the AArch64 version is not moved at the same time. > That seems counterintuituve. > > So could you: > Move > ArmPkg/Include/AsmMacroIoLib.h => MdePkg/Include/ARM/AsmMacroIoLib.h > ArmPkg/Include/AsmMacroIoLibV8.h => > MdePkg/Include/AArch64/AsmMacroIoLibV8.h > ? > > Ideally, the AArch64 version should also lose its spectacularly > incorrect suffix, but that can wait for another day due to the > resulting fallout. > > Ideally2, the VS .inc files ought to move with the ARM header, but that > feels like a bit much of a can of worms to ask for. > > / > Leif > > > 1 file changed, 0 insertions(+), 0 deletions(-) > > > > diff --git a/ArmPkg/Include/AsmMacroIoLib.h > b/MdePkg/Include/AsmMacroIoLib.h > > similarity index 100% > > rename from ArmPkg/Include/AsmMacroIoLib.h > > rename to MdePkg/Include/AsmMacroIoLib.h > > -- > > 2.31.1.windows.1 > > > --000000000000d2e32205cfd392b4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Will address. Thanks!

=
On Tue, Nov 2, 2021 at 2:25 AM Leif L= indholm <leif@nuviainc.com> = wrote:
On Mon, N= ov 01, 2021 at 12:56:39 -0700, brbarkel@microsoft.com wrote:
> From: Bret Barkelew <brbarkel@microsoft.com>
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Bret Barkelew <bret.barkelew@microsoft.com>
> ---
>=C2=A0 {ArmPkg =3D> MdePkg}/Include/AsmMacroIoLib.h | 0

I approve of this move, but if it goes into MdePkg, it needs some form
of arch-specific handling (like ProcessorBind.h, and indeed for x86,
Nasm.inc).

I also note that the AArch64 version is not moved at the same time.
That seems counterintuituve.

So could you:
Move
ArmPkg/Include/AsmMacroIoLib.h =3D> MdePkg/Include/ARM/AsmMacroIoLib.h ArmPkg/Include/AsmMacroIoLibV8.h =3D> MdePkg/Include/AArch64/AsmMacroIoL= ibV8.h
?

Ideally, the AArch64 version should also lose its spectacularly
incorrect suffix, but that can wait for another day due to the
resulting fallout.

Ideally2, the VS .inc files ought to move with the ARM header, but that
feels like a bit much of a can of worms to ask for.

/
=C2=A0 =C2=A0 Leif

>=C2=A0 1 file changed, 0 insertions(+), 0 deletions(-)
>
> diff --git a/ArmPkg/Include/AsmMacroIoLib.h b/MdePkg/Include/AsmMacroI= oLib.h
> similarity index 100%
> rename from ArmPkg/Include/AsmMacroIoLib.h
> rename to MdePkg/Include/AsmMacroIoLib.h
> --
> 2.31.1.windows.1
>
--000000000000d2e32205cfd392b4--