From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) by mx.groups.io with SMTP id smtpd.web12.2479.1613621252037179139 for ; Wed, 17 Feb 2021 20:07:32 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@corthon-com.20150623.gappssmtp.com header.s=20150623 header.b=Qvbz3On4; spf=pass (domain: gmail.com, ip: 209.85.167.180, mailfrom: debtech@gmail.com) Received: by mail-oi1-f180.google.com with SMTP id 18so584930oiz.7 for ; Wed, 17 Feb 2021 20:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corthon-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7Ifo0LN7hN5mBE+oHp21SUZ1UulDVeBYwVoX4zxXPh4=; b=Qvbz3On45rvRwl1RBmKXLiyFKafAEMcS1tFIqml1ZDut9BLZJAFa/o/e+ysDmd9UFM wK6LenfGS3EliV7iQ5/bZVWzBHm3wWe3tw3u6+XIwbM75hStbyZJ+hqVkTMzep/AbqQw EZeoC3atpMuQib5MlhJhvNNTwsSOXNd9ugiERZZbvrjfjPFBIS06peLz6BnQQlD5E1yj YiNI9Dktx/dCmusjHcbmNahYD64cFMB3UyKsSE8S7o21/pthTlq+7x8oyNMqdK4tkhYw ZjDxpnGKNX+5L9yg1PrzdvnH6EYos5zoLdUT9tJhFTWQn+o/SFPe3twTjzj+LSaR/pJv w2DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7Ifo0LN7hN5mBE+oHp21SUZ1UulDVeBYwVoX4zxXPh4=; b=MQeqnLqWxYT2Y2w5CrcUUNgw3HrSi594OuNi1wQwCSZQwURiQeafx4inF4tIB/IuS7 hA3Q8kkxqIp83jzLyp65QhWcXAiAZaOthgIOYe2KXWvHmSvSm11QcIPYznSiKCRABi+v FSWT2mPwInkIFBwwkK9bf5jgVi2YXwBh22p5CtaoLzbHKnx7pbORONxOigqNqURGo5fj IUW9Xmhw+e2islP/DnUs1OEG/Yb/U6QolJuIEeV/MlvDiVQHgObv6so2hMLGlJKlNhgZ MSfbp4fcpNdR+e49w7nfV6m1g1Sqy+aIQHmDNYXNHe+iQJ+iCg+XCOg+ENpBFsi+zP3J KFdg== X-Gm-Message-State: AOAM531O5TtOAGAnCVOJglxvyiPCsYaKRY/cwfu9ckuG/c+4+pQUl3rw dG+G0qf38W2ga/+F9lA+qW/ZgvYMWyIJssHrdVI= X-Google-Smtp-Source: ABdhPJzCPuY3nWag6BEoiHgFHNXJCTceOMZaUTdaV4qtLd4aIlwK7TE6QhtvCqU/fWncA0EHYS4Fr/SM6ZEZ5R814XY= X-Received: by 2002:aca:5dd7:: with SMTP id r206mr1466531oib.133.1613621251401; Wed, 17 Feb 2021 20:07:31 -0800 (PST) MIME-Version: 1.0 References: <20210212204926.1114-1-bret.barkelew@microsoft.com> <9dd900ea-5b9f-aa54-04b9-cddf4a0f3ede@redhat.com> <000f01d705a7$9c1c59e0$d4550da0$@byosoft.com.cn> In-Reply-To: <000f01d705a7$9c1c59e0$d4550da0$@byosoft.com.cn> From: "Bret Barkelew" Date: Wed, 17 Feb 2021 20:07:23 -0800 Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update the NASM dependency To: gaoliming Cc: devel@edk2.groups.io, Laszlo Ersek Content-Type: multipart/alternative; boundary="0000000000007dea9905bb947954" --0000000000007dea9905bb947954 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I'm not opposed to moving to 2.15.03 for consistency, but we'll have to publish a new package. This one is already pushed to Nuget. On Wed, Feb 17, 2021 at 7:39 PM gaoliming wrote= : > Laszlo: > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+71686+4905953+8761045@groups= .io > > =E4=BB=A3=E8=A1=A8 Lasz= lo Ersek > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B42=E6=9C=8816=E6=97= =A5 5:00 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; bret@corthon.com > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update = the NASM > > dependency > > > > Hi Bret, > > > > On 02/12/21 21:49, Bret Barkelew wrote: > > > This is primarily used by CI builds, but may also be used by platfor= ms. > > > > > > Update NASM to support newer structures and features, as agreed in > recent > > > community meetings: > > > https://edk2.groups.io/g/devel/message/71289 > > > --- > > > BaseTools/Bin/nasm_ext_dep.yaml | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/BaseTools/Bin/nasm_ext_dep.yaml > > b/BaseTools/Bin/nasm_ext_dep.yaml > > > index 60b1f71b56aa..56703d4c18e7 100644 > > > --- a/BaseTools/Bin/nasm_ext_dep.yaml > > > +++ b/BaseTools/Bin/nasm_ext_dep.yaml > > > @@ -13,6 +13,6 @@ > > > "type": "nuget", > > > "name": "mu_nasm", > > > "source": "https://api.nuget.org/v3/index.json", > > > - "version": "2.14.02", > > > + "version": "2.15.5", > > > "flags": ["set_path", "host_specific"] > > > } > > > > > > > (1) I'm confused by the "patchlevel" number being "5" and not "05", in > > the "2.15.5" version. Per > > , my understanding has > > been that the latest release is "2.15.05". > > > > (2) The minimum required version, according to > > , is "2.15.01". In the > > RHEL build environments that matter to me, I can satisfy a NASM > > dependency up to 2.15.03, at this time, but not beyond. And this matte= rs > > because... > > > I understand CI environment tries to use the latest tool version for > verification. > > > (3) ... arguably, the NASM requirement in > > "BaseTools/Conf/tools_def.template" should be updated too, in the same > > patch: > > > > # - NASM 2.10 or later for use with the GCC toolchain family > > # - NASM 2.12.01 or later for use with all other toolchain families > > > This is edk2 build environment requirement. It will be updated when the > source code change is added. > > Thanks > Liming > > Thanks > > Laszlo > > > > > > > >=20 > > > > > > --0000000000007dea9905bb947954 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I'm not opposed to moving to 2.15.03 = for consistency, but we'll have to publish a new package. This one is a= lready pushed to Nuget.

On Wed, Feb 17, 2021 at 7:39 PM gaoliming &l= t;gaoliming@byosoft.com.cn&= gt; wrote:
Laszl= o:

> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+71686+490595= 3+8761045@groups.io
> <bounce+27952+71686+4905953+8761045@groups.io&g= t; =E4=BB=A3=E8=A1=A8 Laszlo Ersek
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B42=E6=9C=8816=E6=97= = =A5 5:00
> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; bret@corthon.com
> =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update= the NASM
> dependency
>
> Hi Bret,
>
> On 02/12/21 21:49, Bret Barkelew wrote:
> > This is primarily used by CI builds, but may also be used by pla= tforms.
> >
> > Update NASM to support newer structures and features, as agreed = in recent
> > community meetings:
> > https://edk2.groups.io/g/devel/message/71289<= /a>
> > ---
> >=C2=A0 BaseTools/Bin/nasm_ext_dep.yaml | 2 +-
> >=C2=A0 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/BaseTools/Bin/nasm_ext_dep.yaml
> b/BaseTools/Bin/nasm_ext_dep.yaml
> > index 60b1f71b56aa..56703d4c18e7 100644
> > --- a/BaseTools/Bin/nasm_ext_dep.yaml
> > +++ b/BaseTools/Bin/nasm_ext_dep.yaml
> > @@ -13,6 +13,6 @@
> >=C2=A0 =C2=A0 "type": "nuget",
> >=C2=A0 =C2=A0 "name": "mu_nasm",
> >=C2=A0 =C2=A0 "source": "https://api.nug= et.org/v3/index.json",
> > -=C2=A0 "version": "2.14.02",
> > +=C2=A0 "version": "2.15.5",
> >=C2=A0 =C2=A0 "flags": ["set_path", "hos= t_specific"]
> >=C2=A0 }
> >
>
> (1) I'm confused by the "patchlevel" number being "= ;5" and not "05", in
> the "2.15.5" version. Per
> <https://edk2.groups.io/g/devel/message/71045>, my understanding has
> been that the latest release is "2.15.05".
>
> (2) The minimum required version, according to
> <https://edk2.groups.io/g/devel/message/71070>, is "2.15.01". In the
> RHEL build environments that matter to me, I can satisfy a NASM
> dependency up to 2.15.03, at this time, but not beyond. And this matt= ers
> because...
>
I understand CI environment tries to use the latest tool version for verif= ication.

> (3) ... arguably, the NASM requirement in
> "BaseTools/Conf/tools_def.template" should be updated too, = in the same
> patch:
>
> #=C2=A0 =C2=A0- NASM 2.10 or later for use with the GCC toolchain fam= ily
> #=C2=A0 =C2=A0- NASM 2.12.01 or later for use with all other toolchai= n families
>
This is edk2 build environment requirement. It will be updated when the so= urce code change is added.

Thanks
Liming
> Thanks
> Laszlo
>
>
>
>
>



--0000000000007dea9905bb947954--