From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by mx.groups.io with SMTP id smtpd.web11.858.1636046645444433331 for ; Thu, 04 Nov 2021 10:24:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@corthon-com.20210112.gappssmtp.com header.s=20210112 header.b=CDvuRfJY; spf=pass (domain: gmail.com, ip: 209.85.219.175, mailfrom: debtech@gmail.com) Received: by mail-yb1-f175.google.com with SMTP id t127so16098975ybf.13 for ; Thu, 04 Nov 2021 10:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corthon-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jMwL37MTI3KZpGo8RbbB2PKmXBurlU/nstqqDWuMVEA=; b=CDvuRfJY6524KJDEpq6wxfexZbRjjfOf+VkT4X3qyg+tXahWIkM7rhJ/pGgmgQ0nwK EpjIpCzGjmgzPDIrx3LZ5XYqMxvN6XbblGKZn+awSRvyyjt8fQZht6kXW4E0tz7YCe7S +utx0UeDeDAqImszT6IL82p9S4Q+j37DaI3NIKmsHwrfQKOSk8vMbxv2LuGg3uhdVKr8 qArSrc8YxWLoWqc0W7rPOOEE1tp4NFAhY2+ywTVn0IixUgf96PeHVBXCVxTrsjnavfHf eHHXv+ah4b9iXBDHzPKCx6c+oFkYoT/+25Mx4n/dnyWb86F6R+ZqKf0+X9+uZ4mTQpZ8 36pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jMwL37MTI3KZpGo8RbbB2PKmXBurlU/nstqqDWuMVEA=; b=sXhs7xCNwL4tT24F7uPEnghl92tIWWLAo5qIJtOHyo/VVwdN7YE30YQWedyXVzAwUh yKolbe4us8oBNsMsT5kU/1sOLQYg+JHXOu8FKI3wpxpf5lHH77FZsx/UXjNdNitpOH02 I4RDCpwTgrXwt3w9kB0XJJ31N5Ga2Uy1hSCo+Toci5iXXPmz3GWy3n2JBJRdpkKUuIs5 GSfd6OHfNsSJ1lVihGSViRu/LO78IhiZwbI6YoSikKXWvolyikJ5lissCuTVUS8rjNMo LgY8KlGmaS9QfxbC/0BjC/mu0ujmJQBuOAHDJ9Ms/yK8vOo7LZgghHRGC+gSLudSBy5X Faug== X-Gm-Message-State: AOAM531vHY5USq/6wHq2+aJlH71DHx9FLMKyL/KG+qwaXp7zI9CCryIP WsO5x9ImI97McmdK4glu/5KB1pooNK/Q9VOUY9o= X-Google-Smtp-Source: ABdhPJxCGjcfaE3H0DIWsbHd3gkrlCoRooIYBIn6oyiDCVAUFL5MSYOyT88sXH3hl559p07Ih+yk7uS41XCk6SqNp/Q= X-Received: by 2002:a5b:381:: with SMTP id k1mr58774962ybp.271.1636046644517; Thu, 04 Nov 2021 10:24:04 -0700 (PDT) MIME-Version: 1.0 References: <20211101195648.6420-1-brbarkel@microsoft.com> <20211101195648.6420-6-brbarkel@microsoft.com> <20211102095048.op7qudfi6cgmkb55@leviathan> <009101d7d144$7a2c8bc0$6e85a340$@byosoft.com.cn> In-Reply-To: From: "Bret Barkelew" Date: Thu, 4 Nov 2021 10:23:53 -0700 Message-ID: Subject: Re: [edk2-devel] [PATCH v1 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg To: Andrew Fish Cc: edk2-devel-groups-io , Liming Gao , "Lindholm, Leif" , Ard Biesheuvel , Mike Kinney , Zhiguang Liu , Sami Mujawar , Jiewen Yao , Supreeth Venkatesh , Maciej Rabeda , Jiaxin Wu , Siyuan Fu , Ray Ni , Zhichao Gao , Sean Brogan Content-Type: multipart/alternative; boundary="000000000000151fb405cff9cb3a" --000000000000151fb405cff9cb3a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Will address. On Wed, Nov 3, 2021 at 11:24 PM Andrew Fish wrote: > > > > On Nov 3, 2021, at 11:23 PM, gaoliming wrote= : > > > > Lefi: > > > >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > >> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Leif Lindholm > >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B411=E6=9C=882=E6=97= =A5 17:51 > >> =E6=94=B6=E4=BB=B6=E4=BA=BA: brbarkel@microsoft.com > >> =E6=8A=84=E9=80=81: devel@edk2.groups.io; Ard Biesheuvel ; > >> Michael D Kinney ; Liming Gao > >> ; Zhiguang Liu ; Sam= i > >> Mujawar ; Jiewen Yao ; > >> Supreeth Venkatesh ; Maciej Rabeda > >> ; Jiaxin Wu ; > Siyuan > >> Fu ; Ray Ni ; Zhichao Gao > >> ; Sean Brogan > >> =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 05/16] ArmPkg and MdePk= g: Move the Arm > >> CompilerIntrinsicsLib to MdePkg > >> > >> On Mon, Nov 01, 2021 at 12:56:37 -0700, brbarkel@microsoft.com wrote: > >>> From: Bret Barkelew > >>> > >>> This aligns better with Mu's philosophy around dependency structuring > >>> and is one of the steps to enable Basecore to have zero CI dependenci= es > >>> on other Mu repos. > >>> > >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3649 > >>> > >> > >> Only one comment on this patch really. > >> > >>> ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf =3D> > >> MdePkg/Library/CompilerIntrinsicsLib/ArmCompilerIntrinsicsLib.inf | 3 > +-- > >> > >> Could we just keep the .inf name as is? > >> > > I agree your suggestion. CompilerIntrinsicsLib can support X86 in futur= e. > > So, > > CompilerIntrinsicsLib.inf should be used. > > > > +1 > > Thanks, > > Andrew Fish > > > Thanks > > Liming > > > >> I think we're getting closer to the x86 folk accepting that they > >> need this too, rather than keep inventing new dialects of C in the > >> desperate hope that the compiler won't generate stdlib calls it's > >> fully permitted to generate whenever it feels like. > >> > >> / > >> Leif > >> > >> > >> > >> > > > > > > > > > > > >=20 > > > > > > --000000000000151fb405cff9cb3a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Will address.

On Wed, Nov 3, 2021 at 11:24 PM Andrew Fish &= lt;afish@apple.com> wrote:


> On Nov 3, 2021, at 11:23 PM, gaoliming <gaoliming@byosoft.com.cn> wrote:<= br> >
> Lefi:
>
>> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
>> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io <devel@edk2.groups.io> =E4=BB=A3=E8= =A1=A8 Leif Lindholm
>> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B411=E6=9C=882=E6= =97=A5 17:51
>> =E6=94=B6=E4=BB=B6=E4=BA=BA: brbarkel@microsoft.com <bret@corthon.com>
>> =E6=8A=84=E9=80=81: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianocore@kernel.org>;
>> Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
>> <= gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Sami >> Mujawar <sami.mujawar@arm.com>; Jiewen Yao <jiewen.yao@intel.com>;
>> Supreeth Venkatesh <supreeth.venkatesh@arm.com>; Maciej Rabeda
>> <maciej.rabeda@linux.intel.com>; Jiaxin Wu <jiaxin.wu@intel.com>; Siyuan=
>> Fu <si= yuan.fu@intel.com>; Ray Ni <ray.ni@intel.com>; Zhichao Gao
>> <zhi= chao.gao@intel.com>; Sean Brogan <sean.brogan@microsoft.com>
>> =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 05/16] ArmPkg and M= dePkg: Move the Arm
>> CompilerIntrinsicsLib to MdePkg
>>
>> On Mon, Nov 01, 2021 at 12:56:37 -0700, brbarkel@microsoft.com wrote:
>>> From: Bret Barkelew <brbarkel@microsoft.com>
>>>
>>> This aligns better with Mu's philosophy around dependency = structuring
>>> and is one of the steps to enable Basecore to have zero CI dep= endencies
>>> on other Mu repos.
>>>
>>> REF: https://bugzilla.tianocore.or= g/show_bug.cgi?id=3D3649
>>>
>>
>> Only one comment on this patch really.
>>
>>> ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf= =3D>
>> MdePkg/Library/CompilerIntrinsicsLib/ArmCompilerIntrinsicsLib.inf = | 3 +--
>>
>> Could we just keep the .inf name as is?
>>
> I agree your suggestion. CompilerIntrinsicsLib can support X86 in futu= re.
> So,
> CompilerIntrinsicsLib.inf should be used.
>

+1

Thanks,

Andrew Fish

> Thanks
> Liming
>
>> I think we're getting closer to the x86 folk accepting that th= ey
>> need this too, rather than keep inventing new dialects of C in the=
>> desperate hope that the compiler won't generate stdlib calls i= t's
>> fully permitted to generate whenever it feels like.
>>
>> /
>>=C2=A0 =C2=A0 Leif
>>
>>
>>
>>
>
>
>
>
>
>
>
>

--000000000000151fb405cff9cb3a--