From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by mx.groups.io with SMTP id smtpd.web12.490.1635882805522907161 for ; Tue, 02 Nov 2021 12:53:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@corthon-com.20210112.gappssmtp.com header.s=20210112 header.b=5wiYTWGH; spf=pass (domain: gmail.com, ip: 209.85.219.171, mailfrom: debtech@gmail.com) Received: by mail-yb1-f171.google.com with SMTP id q74so953967ybq.11 for ; Tue, 02 Nov 2021 12:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corthon-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1O9i7pwOLnrBHIy6jypD1imRgIXhS9ecOf0SQc3uTVY=; b=5wiYTWGHGLkPVLkOj0KgzG+/hyXcsEw7uzkFHSEiyIim1q1M2RU6eD8EysmjiN73ts DFJBFMDWwSbkRbybmLgkyFB3H8xMtFFEU0hGvbQOItrcxMBYZgheL+B4UHCjnjH9bKIk o2B86jdNMByINUKAx+N1LkONFWrmQsW0elDXYcE9V+mK9hw/zz3bD0Mg+dWiA9WhDZ7W +PQ8IsAFtss5PhN/2rxDDA9wRaBQL1sBhnAhvNQQLZl486SpXU7UcQmxaBdSR2/uYdFV SsCp58t1AU5THvPNlV2D8Dc3gCX2awl1z1ALRyLIWUNsmx/MNtt1Yx5iEhNUcDL5cRdt z2ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1O9i7pwOLnrBHIy6jypD1imRgIXhS9ecOf0SQc3uTVY=; b=K0EAJYgNyXRThlZonH2RkQ6b4IE+/nW5fnIRZs2dZh7BXTg2s0u7e1VnzKfxAR5FOQ XOeZA3c0evAI4/dhtNBySEzy5kPnN1wJJl/TrLa46RjgurOrCSWGBWiyIM1jyHnZuNpx 8TkPVgpXAqq8UJFFwHU7hQxUcHE5F1v9qMSHUncSCanUVDyeuoYcP1i3KTOeoVjn4t6v 0ZtY6NhF0XGIIFR0IWt8nxJJueWtitYoi/1OHSrn7TjRN9QdyXUosZ7KRb8cWwcl1zLg z7Oe1NW7CwBW3CFG8/EzLlb0t85DN/tf7qVwzL6yIebpqQUEhUhNTm9G4/8Rxiw/Bis2 ICvA== X-Gm-Message-State: AOAM533mUHQoGA8osjrG4iotcbHxOf2Zlrvi3uE0Z9iEWYp38NWhlRk6 //yaXCWWrnFP/ScBQB0x2H+opNPWLBNrIDrxBYo= X-Google-Smtp-Source: ABdhPJw+tGdlGi/VnUF2tymlEQ4Iu4iASCfPNG6HVUB0nVDDn8Wi6av51lhwF0juoQ/wnODmwsIqljcme4ijH3p7nOY= X-Received: by 2002:a25:a2cd:: with SMTP id c13mr25093511ybn.95.1635882804696; Tue, 02 Nov 2021 12:53:24 -0700 (PDT) MIME-Version: 1.0 References: <20211101195648.6420-1-brbarkel@microsoft.com> <20211101195648.6420-13-brbarkel@microsoft.com> <20211102100010.ddx7klcot5zhkxxl@leviathan> In-Reply-To: <20211102100010.ddx7klcot5zhkxxl@leviathan> From: "Bret Barkelew" Date: Tue, 2 Nov 2021 12:53:15 -0700 Message-ID: Subject: Re: [PATCH v1 12/16] ArmPkg: Move the StandaloneMmCpu driver to ArmPkg To: Leif Lindholm Cc: devel@edk2.groups.io, Ard Biesheuvel , Sami Mujawar , Jiewen Yao , Supreeth Venkatesh , Sean Brogan Content-Type: multipart/alternative; boundary="00000000000077d89205cfd3a538" --00000000000077d89205cfd3a538 Content-Type: text/plain; charset="UTF-8" If the implementation didn't make so many calls into Arm-specific libs for SMC servicing, it could stay right where it is. It's just that untangling that Gordian knot is outside my ken. On Tue, Nov 2, 2021 at 3:00 AM Leif Lindholm wrote: > On Mon, Nov 01, 2021 at 12:56:44 -0700, brbarkel@microsoft.com wrote: > > From: Bret Barkelew > > > > This aligns better with Mu's philosophy around dependency structuring > > and is one of the steps to enable Basecore to have zero CI dependencies > > on other Mu repos. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 > > I much prefer moving things out of ArmPkg (which shouldn't exist), > than moving things into it. Where would be the logical place for this > to go if ARM wasn't so special it needed its own top-level package? > > / > Leif > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Sami Mujawar > > Cc: Jiewen Yao > > Cc: Supreeth Venkatesh > > Cc: Sean Brogan > > Signed-off-by: Bret Barkelew > > --- > > {StandaloneMmPkg => ArmPkg}/Drivers/StandaloneMmCpu/EventHandle.c > | 0 > > {StandaloneMmPkg => ArmPkg}/Drivers/StandaloneMmCpu/StandaloneMmCpu.c > | 0 > > {StandaloneMmPkg => ArmPkg}/Drivers/StandaloneMmCpu/StandaloneMmCpu.h > | 0 > > {StandaloneMmPkg => ArmPkg}/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf > | 0 > > 4 files changed, 0 insertions(+), 0 deletions(-) > > > > diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c > b/ArmPkg/Drivers/StandaloneMmCpu/EventHandle.c > > similarity index 100% > > rename from StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c > > rename to ArmPkg/Drivers/StandaloneMmCpu/EventHandle.c > > diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c > b/ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c > > similarity index 100% > > rename from StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c > > rename to ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c > > diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.h > b/ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.h > > similarity index 100% > > rename from StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.h > > rename to ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.h > > diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf > b/ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf > > similarity index 100% > > rename from StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf > > rename to ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf > > -- > > 2.31.1.windows.1 > > > --00000000000077d89205cfd3a538 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
If the implementation didn't make so many calls into A= rm-specific libs for SMC servicing, it could stay right where it is.
It= 's just that untangling that Gordian knot is outside my ken.

On Tu= e, Nov 2, 2021 at 3:00 AM Leif Lindholm <leif@nuviainc.com> wrote:
On Mon, Nov 01, 2021 at 12:56:44 -0700, brbarkel@microsoft.com = wrote:
> From: Bret Barkelew <brbarkel@microsoft.com>
>
> This aligns better with Mu's philosophy around dependency structur= ing
> and is one of the steps to enable Basecore to have zero CI dependencie= s
> on other Mu repos.
>
> REF: https://bugzilla.tianocore.org/show_b= ug.cgi?id=3D3652

I much prefer moving things out of ArmPkg (which shouldn't exist),
than moving things into it. Where would be the logical place for this
to go if ARM wasn't so special it needed its own top-level package?

/
=C2=A0 =C2=A0 Leif

> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Bret Barkelew <bret.barkelew@microsoft.com>
> ---
>=C2=A0 {StandaloneMmPkg =3D> ArmPkg}/Drivers/StandaloneMmCpu/EventHa= ndle.c=C2=A0 =C2=A0 =C2=A0 =C2=A0| 0
>=C2=A0 {StandaloneMmPkg =3D> ArmPkg}/Drivers/StandaloneMmCpu/Standal= oneMmCpu.c=C2=A0 =C2=A0| 0
>=C2=A0 {StandaloneMmPkg =3D> ArmPkg}/Drivers/StandaloneMmCpu/Standal= oneMmCpu.h=C2=A0 =C2=A0| 0
>=C2=A0 {StandaloneMmPkg =3D> ArmPkg}/Drivers/StandaloneMmCpu/Standal= oneMmCpu.inf | 0
>=C2=A0 4 files changed, 0 insertions(+), 0 deletions(-)
>
> diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c b/A= rmPkg/Drivers/StandaloneMmCpu/EventHandle.c
> similarity index 100%
> rename from StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c
> rename to ArmPkg/Drivers/StandaloneMmCpu/EventHandle.c
> diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c= b/ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c
> similarity index 100%
> rename from StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c<= br> > rename to ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c
> diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.h= b/ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.h
> similarity index 100%
> rename from StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.h<= br> > rename to ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.h
> diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.i= nf b/ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf
> similarity index 100%
> rename from StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.in= f
> rename to ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf
> --
> 2.31.1.windows.1
>
--00000000000077d89205cfd3a538--