Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

["King Sumo" <kingsumos@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2709 bytes --]

Hi All,

This patch broke the coreboot payload loading. Tested with:
build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t
GCC5 -D BOOTLOADER=COREBOOT

Basically the coreboot cbfstool reports the following error when creating
the CBFS / flash image:
"Not a usable UEFI firmware volume"

Trying to boot coreboot results in an exception and the following error
message:
"Payload not loaded"

Probably it broke the interface.

commit 4bac086e8e007c7143e33f87bb96238326d1d6ba
Author: Zhiguang Liu <zhiguang.liu@intel.com>
Date:   Wed Jul 14 14:24:45 2021 +0800

    UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

    Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
    Reviewed-by: Ray Ni <ray.ni@intel.com>
    Reviewed-by: Guo Dong <guo.dong@intel.com>


Kind regards,
Sumo

On Wed, Jul 14, 2021 at 1:08 PM Guo Dong <guo.dong@intel.com> wrote:

>
> Signed-off-by: Guo Dong <guo.dong@intel.com>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Zhiguang Liu
> > Sent: Tuesday, July 13, 2021 11:25 PM
> > To: devel@edk2.groups.io
> > Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and
> > PLDFV
> >
> > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > ---
> >  UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> > b/UefiPayloadPkg/UefiPayloadPkg.fdf
> > index 2d51fdbacb..041fed842c 100644
> > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> > @@ -34,6 +34,7 @@ FV = PLDFV
> >
> >
> >
> > ##########################################################
> > ######################
> >
> >  [FV.PLDFV]
> >
> > +FvNameGuid         = 96E75986-6FDD-491E-9FD5-35E21AC45B45
> >
> >  BlockSize          = $(FD_BLOCK_SIZE)
> >
> >  FvAlignment        = 16
> >
> >  ERASE_POLARITY     = 1
> >
> > @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-
> > E77F1DB2D793 {
> >
> > ##########################################################
> > ######################
> >
> >
> >
> >  [FV.DXEFV]
> >
> > +FvNameGuid         = 8063C21A-8E58-4576-95CE-089E87975D23
> >
> >  BlockSize          = $(FD_BLOCK_SIZE)
> >
> >  FvForceRebase      = FALSE
> >
> >  FvAlignment        = 16
> >
> > --
> > 2.30.0.windows.2
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762
> > Mute This Topic: https://groups.io/mt/84196221/1781375
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com]
> > -=-=-=-=-=-=
> >
>
>
>
> 
>
>
>

[-- Attachment #2: Type: text/html, Size: 4610 bytes --]